[PATCH] checkpolicy: add missing forward declaration

[PATCH] checkpolicy: add missing forward declaration

[Christian Göttsche]

policy_scan.l:294:3: warning: implicit declaration of function 'yyerror' is

      invalid in C99 [-Wimplicit-function-declaration]

{ yyerror("unrecognized character");}

  ^

policy_scan.l:294:3: warning: this function declaration is not a prototype

      [-Wstrict-prototypes]

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 checkpolicy/policy_scan.l | 1 +
 1 file changed, 1 insertion(+)

diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l
index 094645d1..4067268b 100644
--- a/checkpolicy/policy_scan.l
+++ b/checkpolicy/policy_scan.l
@@ -37,6 +37,7 @@ typedef int (* require_func_t)(void);
 static char linebuf[2][255];
 static unsigned int lno = 0;
 int werror = 0;
+int yyerror(const char *msg);
 int yywarn(const char *msg);
 
 void set_source_file(const char *name);
-- 
2.26.0.rc2

RE: [PATCH] checkpolicy: add missing forward declaration

[Roberts, William C]

> -----Original Message-----
> From: selinux-owner@vger.kernel.org [mailto:selinux-owner@vger.kernel.org]
> On Behalf Of Christian Göttsche
> Sent: Monday, March 23, 2020 1:27 PM
> To: selinux@vger.kernel.org
> Subject: [PATCH] checkpolicy: add missing forward declaration
> 
> policy_scan.l:294:3: warning: implicit declaration of function 'yyerror' is
> 
>       invalid in C99 [-Wimplicit-function-declaration]
> 
> { yyerror("unrecognized character");}
> 
>   ^
> 
> policy_scan.l:294:3: warning: this function declaration is not a prototype
> 
>       [-Wstrict-prototypes]
> 
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
>  checkpolicy/policy_scan.l | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l index
> 094645d1..4067268b 100644
> --- a/checkpolicy/policy_scan.l
> +++ b/checkpolicy/policy_scan.l
> @@ -37,6 +37,7 @@ typedef int (* require_func_t)(void);  static char
> linebuf[2][255];  static unsigned int lno = 0;  int werror = 0;
> +int yyerror(const char *msg);
>  int yywarn(const char *msg);
> 
>  void set_source_file(const char *name);
> --
> 2.26.0.rc2

Acked-by: William Roberts <william.c.roberts@intel.com>

Re: [PATCH] checkpolicy: add missing forward declaration

[William Roberts]

On Mon, Mar 23, 2020 at 2:03 PM Roberts, William C
<william.c.roberts@intel.com> wrote:
>
> > -----Original Message-----
> > From: selinux-owner@vger.kernel.org [mailto:selinux-owner@vger.kernel.org]
> > On Behalf Of Christian Göttsche
> > Sent: Monday, March 23, 2020 1:27 PM
> > To: selinux@vger.kernel.org
> > Subject: [PATCH] checkpolicy: add missing forward declaration
> >
> > policy_scan.l:294:3: warning: implicit declaration of function 'yyerror' is
> >
> >       invalid in C99 [-Wimplicit-function-declaration]
> >
> > { yyerror("unrecognized character");}
> >
> >   ^
> >
> > policy_scan.l:294:3: warning: this function declaration is not a prototype
> >
> >       [-Wstrict-prototypes]
> >
> > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> > ---
> >  checkpolicy/policy_scan.l | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l index
> > 094645d1..4067268b 100644
> > --- a/checkpolicy/policy_scan.l
> > +++ b/checkpolicy/policy_scan.l
> > @@ -37,6 +37,7 @@ typedef int (* require_func_t)(void);  static char
> > linebuf[2][255];  static unsigned int lno = 0;  int werror = 0;
> > +int yyerror(const char *msg);
> >  int yywarn(const char *msg);
> >
> >  void set_source_file(const char *name);
> > --
> > 2.26.0.rc2
>
> Acked-by: William Roberts <william.c.roberts@intel.com>
Merged: https://github.com/SELinuxProject/selinux/pull/212