From: Pingfan Liu <kernelfans@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dave Young <dyoung@redhat.com>, Joerg Roedel <jroedel@suse.de>,
Baoquan He <bhe@redhat.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
x86@kernel.org, Randy Dunlap <rdunlap@infradead.org>,
kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Yinghai Lu <yinghai@kernel.org>,
vgoyal@redhat.com, iommu@lists.linux-foundation.org,
konrad.wilk@oracle.com
Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr
Date: Fri, 1 Mar 2019 11:04:19 +0800 [thread overview]
Message-ID: <CAFgQCTvP-YDUEcHTgupr+ar+qeoj5rw1y8k+6kzrzHPzTqBkaw@mail.gmail.com> (raw)
In-Reply-To: <20190225113003.GE26145@zn.tnic>
Hi Borislav,
Do you think the following patch is good at present?
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 81f9d23..9213073 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -460,7 +460,7 @@ static void __init
memblock_x86_reserve_range_setup_data(void)
# define CRASH_ADDR_LOW_MAX (512 << 20)
# define CRASH_ADDR_HIGH_MAX (512 << 20)
#else
-# define CRASH_ADDR_LOW_MAX (896UL << 20)
+# define CRASH_ADDR_LOW_MAX (1 << 32)
# define CRASH_ADDR_HIGH_MAX MAXMEM
#endif
For documentation, I will send another patch to improve the description.
Thanks,
Pingfan
On Mon, Feb 25, 2019 at 7:30 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Mon, Feb 25, 2019 at 07:12:16PM +0800, Dave Young wrote:
> > If we move to high as default, it will allocate 160M high + 256M low. It
>
> We won't move to high by default - we will *fall* back to high if the
> default allocation fails.
>
> > To make the process less fragile maybe we can remove the 896M limitation
> > and only try <4G then go to high.
>
> Sure, the more robust for the user, the better.
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Pingfan Liu <kernelfans@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Joerg Roedel <jroedel@suse.de>, Baoquan He <bhe@redhat.com>,
konrad.wilk@oracle.com, Yinghai Lu <yinghai@kernel.org>,
x86@kernel.org, kexec@lists.infradead.org,
Jerry Hoemann <jerry.hoemann@hpe.com>,
LKML <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Young <dyoung@redhat.com>,
vgoyal@redhat.com
Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr
Date: Fri, 1 Mar 2019 11:04:19 +0800 [thread overview]
Message-ID: <CAFgQCTvP-YDUEcHTgupr+ar+qeoj5rw1y8k+6kzrzHPzTqBkaw@mail.gmail.com> (raw)
In-Reply-To: <20190225113003.GE26145@zn.tnic>
Hi Borislav,
Do you think the following patch is good at present?
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 81f9d23..9213073 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -460,7 +460,7 @@ static void __init
memblock_x86_reserve_range_setup_data(void)
# define CRASH_ADDR_LOW_MAX (512 << 20)
# define CRASH_ADDR_HIGH_MAX (512 << 20)
#else
-# define CRASH_ADDR_LOW_MAX (896UL << 20)
+# define CRASH_ADDR_LOW_MAX (1 << 32)
# define CRASH_ADDR_HIGH_MAX MAXMEM
#endif
For documentation, I will send another patch to improve the description.
Thanks,
Pingfan
On Mon, Feb 25, 2019 at 7:30 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Mon, Feb 25, 2019 at 07:12:16PM +0800, Dave Young wrote:
> > If we move to high as default, it will allocate 160M high + 256M low. It
>
> We won't move to high by default - we will *fall* back to high if the
> default allocation fails.
>
> > To make the process less fragile maybe we can remove the 896M limitation
> > and only try <4G then go to high.
>
> Sure, the more robust for the user, the better.
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-03-01 3:04 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 5:16 [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr Pingfan Liu
2019-01-21 5:16 ` Pingfan Liu
2019-01-21 6:24 ` Baoquan He
2019-01-21 6:24 ` Baoquan He
2019-01-25 10:39 ` Borislav Petkov
2019-01-25 10:39 ` Borislav Petkov
2019-01-25 13:45 ` Dave Young
2019-01-25 13:45 ` Dave Young
2019-01-25 14:08 ` Borislav Petkov
2019-01-25 14:08 ` Borislav Petkov
2019-01-28 9:58 ` Dave Young
2019-01-28 9:58 ` Dave Young
2019-01-28 10:18 ` Borislav Petkov
2019-01-28 10:18 ` Borislav Petkov
2019-06-07 17:30 ` Borislav Petkov
2019-06-07 17:30 ` Borislav Petkov
2019-06-10 6:51 ` Dave Young
2019-06-10 6:51 ` Dave Young
2019-01-29 5:25 ` Pingfan Liu
2019-01-29 5:25 ` Pingfan Liu
2019-01-31 7:42 ` Dave Young
2019-01-31 7:42 ` Dave Young
2019-01-31 7:59 ` Dave Young
2019-01-31 7:59 ` Dave Young
2019-01-31 10:57 ` Borislav Petkov
2019-01-31 10:57 ` Borislav Petkov
2019-01-31 22:27 ` Jerry Hoemann
2019-01-31 22:27 ` Jerry Hoemann
2019-01-31 23:47 ` Borislav Petkov
2019-01-31 23:47 ` Borislav Petkov
2019-02-04 22:30 ` Jerry Hoemann
2019-02-04 22:30 ` Jerry Hoemann
2019-02-05 8:15 ` Borislav Petkov
2019-02-05 8:15 ` Borislav Petkov
2019-02-06 12:08 ` Dave Young
2019-02-06 12:08 ` Dave Young
2019-02-11 20:48 ` Dave Young
2019-02-11 20:48 ` Dave Young
2019-02-12 5:35 ` Pingfan Liu
2019-02-12 5:35 ` Pingfan Liu
2019-02-15 10:24 ` Borislav Petkov
2019-02-15 10:24 ` Borislav Petkov
2019-02-18 1:48 ` Dave Young
2019-02-18 1:48 ` Dave Young
2019-02-18 1:48 ` Dave Young
2019-02-20 7:38 ` Pingfan Liu
2019-02-20 7:38 ` Pingfan Liu
2019-02-20 7:38 ` Pingfan Liu
2019-02-20 8:32 ` Borislav Petkov
2019-02-20 8:32 ` Borislav Petkov
2019-02-20 9:41 ` Dave Young
2019-02-20 9:41 ` Dave Young
2019-02-20 12:51 ` Pingfan Liu
2019-02-20 12:51 ` Pingfan Liu
2019-02-21 17:13 ` Borislav Petkov
2019-02-21 17:13 ` Borislav Petkov
2019-02-22 2:11 ` Dave Young
2019-02-22 2:11 ` Dave Young
2019-02-22 8:42 ` Joerg Roedel
2019-02-22 8:42 ` Joerg Roedel
2019-02-22 13:00 ` Borislav Petkov
2019-02-22 13:00 ` Borislav Petkov
2019-02-24 13:25 ` Pingfan Liu
2019-02-24 13:25 ` Pingfan Liu
2019-02-25 1:53 ` Dave Young
2019-02-25 1:53 ` Dave Young
2019-02-25 9:39 ` Borislav Petkov
2019-02-25 9:39 ` Borislav Petkov
2019-02-25 11:00 ` Joerg Roedel
2019-02-25 11:00 ` Joerg Roedel
2019-02-25 11:12 ` Dave Young
2019-02-25 11:12 ` Dave Young
2019-02-25 11:30 ` Borislav Petkov
2019-02-25 11:30 ` Borislav Petkov
2019-02-25 11:30 ` Borislav Petkov
2019-03-01 3:04 ` Pingfan Liu [this message]
2019-03-01 3:04 ` Pingfan Liu
2019-03-01 3:19 ` Pingfan Liu
2019-03-01 3:19 ` Pingfan Liu
2019-03-22 8:22 ` Dave Young
2019-03-22 8:22 ` Dave Young
2019-01-29 5:51 ` Pingfan Liu
2019-01-29 5:51 ` Pingfan Liu
2019-01-31 10:50 ` Borislav Petkov
2019-01-31 10:50 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2019-01-15 8:07 Pingfan Liu
2019-01-15 8:07 ` Pingfan Liu
2019-01-18 3:43 ` Dave Young
2019-01-18 3:43 ` Dave Young
2019-01-19 1:25 ` Jerry Hoemann
2019-01-19 1:25 ` Jerry Hoemann
2019-01-21 5:11 ` Pingfan Liu
2019-01-21 5:11 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFgQCTvP-YDUEcHTgupr+ar+qeoj5rw1y8k+6kzrzHPzTqBkaw@mail.gmail.com \
--to=kernelfans@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jerry.hoemann@hpe.com \
--cc=jroedel@suse.de \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.