* [PATCH v2 0/6] PCI: altera: Cleanups
@ 2016-10-12 12:46 Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 1/6] PCI: altera: Add local struct device pointers Bjorn Helgaas
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:46 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
- Add local "dev" pointers to reduce repetition of things like
"&pdev->dev".
- Remove platform drvdata because it appears unused (we called
platform_set_drvdata() but not platform_get_drvdata()).
- Removed an unnecessary platform_get_resource() return value check.
- Rework TLB_CFG_DW0 and TLP_CFG_DW1 to make the code prettier.
Nothing here should change the behavior of the driver.
Changes from v1:
I dropped the following patches because they were a lot of churn for
questionable benefit:
PCI: altera: Name private struct pointer "altera" consistently
PCI: altera: Rename _altera_pcie_cfg_read() to altera_raw_cfg_read()
PCI: altera: Rename CRA accessors
PCI: altera: Swap order of altera_cra_writel() reg/val arguments
---
Bjorn Helgaas (6):
PCI: altera: Add local struct device pointers
PCI: altera: Remove unused platform data
PCI: altera: Remove redundant platform_get_resource() return value check
PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device()
PCI: altera: Simplify TLB_CFG_DW0 usage
PCI: altera: Simplify TLP_CFG_DW1 usage
drivers/pci/host/pcie-altera.c | 77 +++++++++++++++++-----------------------
1 file changed, 33 insertions(+), 44 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/6] PCI: altera: Add local struct device pointers
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
@ 2016-10-12 12:47 ` Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 2/6] PCI: altera: Remove unused platform data Bjorn Helgaas
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:47 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
Use a local "struct device *dev" for brevity and consistency with other
drivers. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-altera.c | 34 ++++++++++++++++++----------------
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index c24e965..eac548b 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -394,6 +394,7 @@ static int altera_write_cap_word(struct altera_pcie *pcie, u8 busno,
static void altera_wait_link_retrain(struct altera_pcie *pcie)
{
+ struct device *dev = &pcie->pdev->dev;
u16 reg16;
unsigned long start_jiffies;
@@ -406,7 +407,7 @@ static void altera_wait_link_retrain(struct altera_pcie *pcie)
break;
if (time_after(jiffies, start_jiffies + LINK_RETRAIN_TIMEOUT)) {
- dev_err(&pcie->pdev->dev, "link retrain timeout\n");
+ dev_err(dev, "link retrain timeout\n");
break;
}
udelay(100);
@@ -419,7 +420,7 @@ static void altera_wait_link_retrain(struct altera_pcie *pcie)
break;
if (time_after(jiffies, start_jiffies + LINK_UP_TIMEOUT)) {
- dev_err(&pcie->pdev->dev, "link up timeout\n");
+ dev_err(dev, "link up timeout\n");
break;
}
udelay(100);
@@ -460,7 +461,6 @@ static int altera_pcie_intx_map(struct irq_domain *domain, unsigned int irq,
{
irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq);
irq_set_chip_data(irq, domain->host_data);
-
return 0;
}
@@ -472,12 +472,14 @@ static void altera_pcie_isr(struct irq_desc *desc)
{
struct irq_chip *chip = irq_desc_get_chip(desc);
struct altera_pcie *pcie;
+ struct device *dev;
unsigned long status;
u32 bit;
u32 virq;
chained_irq_enter(chip, desc);
pcie = irq_desc_get_handler_data(desc);
+ dev = &pcie->pdev->dev;
while ((status = cra_readl(pcie, P2A_INT_STATUS)
& P2A_INT_STS_ALL) != 0) {
@@ -489,8 +491,7 @@ static void altera_pcie_isr(struct irq_desc *desc)
if (virq)
generic_handle_irq(virq);
else
- dev_err(&pcie->pdev->dev,
- "unexpected IRQ, INT%d\n", bit);
+ dev_err(dev, "unexpected IRQ, INT%d\n", bit);
}
}
@@ -549,30 +550,30 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
static int altera_pcie_parse_dt(struct altera_pcie *pcie)
{
- struct resource *cra;
+ struct device *dev = &pcie->pdev->dev;
struct platform_device *pdev = pcie->pdev;
+ struct resource *cra;
cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
if (!cra) {
- dev_err(&pdev->dev, "no Cra memory resource defined\n");
+ dev_err(dev, "no Cra memory resource defined\n");
return -ENODEV;
}
- pcie->cra_base = devm_ioremap_resource(&pdev->dev, cra);
+ pcie->cra_base = devm_ioremap_resource(dev, cra);
if (IS_ERR(pcie->cra_base)) {
- dev_err(&pdev->dev, "failed to map cra memory\n");
+ dev_err(dev, "failed to map cra memory\n");
return PTR_ERR(pcie->cra_base);
}
/* setup IRQ */
pcie->irq = platform_get_irq(pdev, 0);
if (pcie->irq <= 0) {
- dev_err(&pdev->dev, "failed to get IRQ: %d\n", pcie->irq);
+ dev_err(dev, "failed to get IRQ: %d\n", pcie->irq);
return -EINVAL;
}
irq_set_chained_handler_and_data(pcie->irq, altera_pcie_isr, pcie);
-
return 0;
}
@@ -583,12 +584,13 @@ static void altera_pcie_host_init(struct altera_pcie *pcie)
static int altera_pcie_probe(struct platform_device *pdev)
{
+ struct device *dev = &pdev->dev;
struct altera_pcie *pcie;
struct pci_bus *bus;
struct pci_bus *child;
int ret;
- pcie = devm_kzalloc(&pdev->dev, sizeof(*pcie), GFP_KERNEL);
+ pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
if (!pcie)
return -ENOMEM;
@@ -596,7 +598,7 @@ static int altera_pcie_probe(struct platform_device *pdev)
ret = altera_pcie_parse_dt(pcie);
if (ret) {
- dev_err(&pdev->dev, "Parsing DT failed\n");
+ dev_err(dev, "Parsing DT failed\n");
return ret;
}
@@ -604,13 +606,13 @@ static int altera_pcie_probe(struct platform_device *pdev)
ret = altera_pcie_parse_request_of_pci_ranges(pcie);
if (ret) {
- dev_err(&pdev->dev, "Failed add resources\n");
+ dev_err(dev, "Failed add resources\n");
return ret;
}
ret = altera_pcie_init_irq_domain(pcie);
if (ret) {
- dev_err(&pdev->dev, "Failed creating IRQ Domain\n");
+ dev_err(dev, "Failed creating IRQ Domain\n");
return ret;
}
@@ -620,7 +622,7 @@ static int altera_pcie_probe(struct platform_device *pdev)
cra_writel(pcie, P2A_INT_ENA_ALL, P2A_INT_ENABLE);
altera_pcie_host_init(pcie);
- bus = pci_scan_root_bus(&pdev->dev, pcie->root_bus_nr, &altera_pcie_ops,
+ bus = pci_scan_root_bus(dev, pcie->root_bus_nr, &altera_pcie_ops,
pcie, &pcie->resources);
if (!bus)
return -ENOMEM;
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/6] PCI: altera: Remove unused platform data
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 1/6] PCI: altera: Add local struct device pointers Bjorn Helgaas
@ 2016-10-12 12:47 ` Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 3/6] PCI: altera: Remove redundant platform_get_resource() return value check Bjorn Helgaas
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:47 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
The altera driver never uses the platform drvdata pointer, so don't bother
setting it. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-altera.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index eac548b..b26695c 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -635,8 +635,6 @@ static int altera_pcie_probe(struct platform_device *pdev)
pcie_bus_configure_settings(child);
pci_bus_add_devices(bus);
-
- platform_set_drvdata(pdev, pcie);
return ret;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/6] PCI: altera: Remove redundant platform_get_resource() return value check
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 1/6] PCI: altera: Add local struct device pointers Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 2/6] PCI: altera: Remove unused platform data Bjorn Helgaas
@ 2016-10-12 12:47 ` Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 4/6] PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device() Bjorn Helgaas
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:47 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
devm_ioremap_resource() fails gracefully when given a NULL resource
pointer, so we don't need to check separately for failure from
platform_get_resource_byname(). Remove the redundant check.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-altera.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index b26695c..931c51e 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -74,7 +74,7 @@
struct altera_pcie {
struct platform_device *pdev;
- void __iomem *cra_base;
+ void __iomem *cra_base; /* DT Cra */
int irq;
u8 root_bus_nr;
struct irq_domain *irq_domain;
@@ -555,11 +555,6 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
struct resource *cra;
cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
- if (!cra) {
- dev_err(dev, "no Cra memory resource defined\n");
- return -ENODEV;
- }
-
pcie->cra_base = devm_ioremap_resource(dev, cra);
if (IS_ERR(pcie->cra_base)) {
dev_err(dev, "failed to map cra memory\n");
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 4/6] PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device()
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
` (2 preceding siblings ...)
2016-10-12 12:47 ` [PATCH v2 3/6] PCI: altera: Remove redundant platform_get_resource() return value check Bjorn Helgaas
@ 2016-10-12 12:47 ` Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 5/6] PCI: altera: Simplify TLB_CFG_DW0 usage Bjorn Helgaas
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:47 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
Rename altera_pcie_valid_config() to altera_pcie_valid_device().
No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-altera.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index 931c51e..a99765a 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -131,7 +131,7 @@ static void tlp_write_tx(struct altera_pcie *pcie,
cra_writel(pcie, tlp_rp_regdata->ctrl, RP_TX_CNTRL);
}
-static bool altera_pcie_valid_config(struct altera_pcie *pcie,
+static bool altera_pcie_valid_device(struct altera_pcie *pcie,
struct pci_bus *bus, int dev)
{
/* If there is no link, then there is no device */
@@ -342,7 +342,7 @@ static int altera_pcie_cfg_read(struct pci_bus *bus, unsigned int devfn,
if (altera_pcie_hide_rc_bar(bus, devfn, where))
return PCIBIOS_BAD_REGISTER_NUMBER;
- if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) {
+ if (!altera_pcie_valid_device(pcie, bus, PCI_SLOT(devfn))) {
*value = 0xffffffff;
return PCIBIOS_DEVICE_NOT_FOUND;
}
@@ -359,7 +359,7 @@ static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn,
if (altera_pcie_hide_rc_bar(bus, devfn, where))
return PCIBIOS_BAD_REGISTER_NUMBER;
- if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn)))
+ if (!altera_pcie_valid_device(pcie, bus, PCI_SLOT(devfn)))
return PCIBIOS_DEVICE_NOT_FOUND;
return _altera_pcie_cfg_write(pcie, bus->number, devfn, where, size,
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 5/6] PCI: altera: Simplify TLB_CFG_DW0 usage
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
` (3 preceding siblings ...)
2016-10-12 12:47 ` [PATCH v2 4/6] PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device() Bjorn Helgaas
@ 2016-10-12 12:47 ` Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 6/6] PCI: altera: Simplify TLP_CFG_DW1 usage Bjorn Helgaas
2016-10-12 16:00 ` [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
6 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:47 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
All TLP_CFG_DW0() uses follow the same pattern based on the root bus
number, so pull that into the macro itself to declutter the users. No
functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-altera.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index a99765a..8240130 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -55,7 +55,10 @@
#define TLP_PAYLOAD_SIZE 0x01
#define TLP_READ_TAG 0x1d
#define TLP_WRITE_TAG 0x10
-#define TLP_CFG_DW0(fmttype) (((fmttype) << 24) | TLP_PAYLOAD_SIZE)
+#define TLP_CFG_DW0(pcie, bus) \
+ ((((bus == pcie->root_bus_nr) ? TLP_FMTTYPE_CFGRD0 \
+ : TLP_FMTTYPE_CFGRD1) << 24) | \
+ TLP_PAYLOAD_SIZE)
#define TLP_CFG_DW1(reqid, tag, be) (((reqid) << 16) | (tag << 8) | (be))
#define TLP_CFG_DW2(bus, devfn, offset) \
(((bus) << 24) | ((devfn) << 16) | (offset))
@@ -218,11 +221,7 @@ static int tlp_cfg_dword_read(struct altera_pcie *pcie, u8 bus, u32 devfn,
{
u32 headers[TLP_HDR_SIZE];
- if (bus == pcie->root_bus_nr)
- headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGRD0);
- else
- headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGRD1);
-
+ headers[0] = TLP_CFG_DW0(pcie, bus);
headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, RP_DEVFN),
TLP_READ_TAG, byte_en);
headers[2] = TLP_CFG_DW2(bus, devfn, where);
@@ -238,11 +237,7 @@ static int tlp_cfg_dword_write(struct altera_pcie *pcie, u8 bus, u32 devfn,
u32 headers[TLP_HDR_SIZE];
int ret;
- if (bus == pcie->root_bus_nr)
- headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGWR0);
- else
- headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGWR1);
-
+ headers[0] = TLP_CFG_DW0(pcie, bus);
headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, RP_DEVFN),
TLP_WRITE_TAG, byte_en);
headers[2] = TLP_CFG_DW2(bus, devfn, where);
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 6/6] PCI: altera: Simplify TLP_CFG_DW1 usage
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
` (4 preceding siblings ...)
2016-10-12 12:47 ` [PATCH v2 5/6] PCI: altera: Simplify TLB_CFG_DW0 usage Bjorn Helgaas
@ 2016-10-12 12:47 ` Bjorn Helgaas
2016-10-12 16:00 ` [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
6 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:47 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: linux-pci, rfi
TLP_CFG_DW1() was only used with altera->root_bus_nr and RP_DEVFN, so
encode that directly into the macro so we don't have to clutter the uses
with the TLP_REQ_ID() usage. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-altera.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index 8240130..b0ac4df 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -55,18 +55,19 @@
#define TLP_PAYLOAD_SIZE 0x01
#define TLP_READ_TAG 0x1d
#define TLP_WRITE_TAG 0x10
+#define RP_DEVFN 0
+#define TLP_REQ_ID(bus, devfn) (((bus) << 8) | (devfn))
#define TLP_CFG_DW0(pcie, bus) \
((((bus == pcie->root_bus_nr) ? TLP_FMTTYPE_CFGRD0 \
: TLP_FMTTYPE_CFGRD1) << 24) | \
TLP_PAYLOAD_SIZE)
-#define TLP_CFG_DW1(reqid, tag, be) (((reqid) << 16) | (tag << 8) | (be))
+#define TLP_CFG_DW1(pcie, tag, be) \
+ (((TLP_REQ_ID(pcie->root_bus_nr, RP_DEVFN)) << 16) | (tag << 8) | (be))
#define TLP_CFG_DW2(bus, devfn, offset) \
(((bus) << 24) | ((devfn) << 16) | (offset))
-#define TLP_REQ_ID(bus, devfn) (((bus) << 8) | (devfn))
#define TLP_COMP_STATUS(s) (((s) >> 12) & 7)
#define TLP_HDR_SIZE 3
#define TLP_LOOP 500
-#define RP_DEVFN 0
#define LINK_UP_TIMEOUT HZ
#define LINK_RETRAIN_TIMEOUT HZ
@@ -222,8 +223,7 @@ static int tlp_cfg_dword_read(struct altera_pcie *pcie, u8 bus, u32 devfn,
u32 headers[TLP_HDR_SIZE];
headers[0] = TLP_CFG_DW0(pcie, bus);
- headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, RP_DEVFN),
- TLP_READ_TAG, byte_en);
+ headers[1] = TLP_CFG_DW1(pcie, TLP_READ_TAG, byte_en);
headers[2] = TLP_CFG_DW2(bus, devfn, where);
tlp_write_packet(pcie, headers, 0, false);
@@ -238,8 +238,7 @@ static int tlp_cfg_dword_write(struct altera_pcie *pcie, u8 bus, u32 devfn,
int ret;
headers[0] = TLP_CFG_DW0(pcie, bus);
- headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, RP_DEVFN),
- TLP_WRITE_TAG, byte_en);
+ headers[1] = TLP_CFG_DW1(pcie, TLP_WRITE_TAG, byte_en);
headers[2] = TLP_CFG_DW2(bus, devfn, where);
/* check alignment to Qword */
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/6] PCI: altera: Cleanups
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
` (5 preceding siblings ...)
2016-10-12 12:47 ` [PATCH v2 6/6] PCI: altera: Simplify TLP_CFG_DW1 usage Bjorn Helgaas
@ 2016-10-12 16:00 ` Bjorn Helgaas
2016-10-13 10:28 ` Ley Foon Tan
6 siblings, 1 reply; 9+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 16:00 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Ley Foon Tan, linux-pci, rfi
On Wed, Oct 12, 2016 at 07:46:59AM -0500, Bjorn Helgaas wrote:
> - Add local "dev" pointers to reduce repetition of things like
> "&pdev->dev".
>
> - Remove platform drvdata because it appears unused (we called
> platform_set_drvdata() but not platform_get_drvdata()).
>
> - Removed an unnecessary platform_get_resource() return value check.
>
> - Rework TLB_CFG_DW0 and TLP_CFG_DW1 to make the code prettier.
>
> Nothing here should change the behavior of the driver.
>
> Changes from v1:
> I dropped the following patches because they were a lot of churn for
> questionable benefit:
> PCI: altera: Name private struct pointer "altera" consistently
> PCI: altera: Rename _altera_pcie_cfg_read() to altera_raw_cfg_read()
> PCI: altera: Rename CRA accessors
> PCI: altera: Swap order of altera_cra_writel() reg/val arguments
>
> ---
>
> Bjorn Helgaas (6):
> PCI: altera: Add local struct device pointers
> PCI: altera: Remove unused platform data
> PCI: altera: Remove redundant platform_get_resource() return value check
> PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device()
> PCI: altera: Simplify TLB_CFG_DW0 usage
> PCI: altera: Simplify TLP_CFG_DW1 usage
I applied these to pci/host-altera for v4.9. I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/6] PCI: altera: Cleanups
2016-10-12 16:00 ` [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
@ 2016-10-13 10:28 ` Ley Foon Tan
0 siblings, 0 replies; 9+ messages in thread
From: Ley Foon Tan @ 2016-10-13 10:28 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Bjorn Helgaas, linux-pci, Rocketboard Maillist
On Thu, Oct 13, 2016 at 12:00 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Wed, Oct 12, 2016 at 07:46:59AM -0500, Bjorn Helgaas wrote:
>> - Add local "dev" pointers to reduce repetition of things like
>> "&pdev->dev".
>>
>> - Remove platform drvdata because it appears unused (we called
>> platform_set_drvdata() but not platform_get_drvdata()).
>>
>> - Removed an unnecessary platform_get_resource() return value check.
>>
>> - Rework TLB_CFG_DW0 and TLP_CFG_DW1 to make the code prettier.
>>
>> Nothing here should change the behavior of the driver.
>>
>> Changes from v1:
>> I dropped the following patches because they were a lot of churn for
>> questionable benefit:
>> PCI: altera: Name private struct pointer "altera" consistently
>> PCI: altera: Rename _altera_pcie_cfg_read() to altera_raw_cfg_read()
>> PCI: altera: Rename CRA accessors
>> PCI: altera: Swap order of altera_cra_writel() reg/val arguments
>>
>> ---
>>
>> Bjorn Helgaas (6):
>> PCI: altera: Add local struct device pointers
>> PCI: altera: Remove unused platform data
>> PCI: altera: Remove redundant platform_get_resource() return value check
>> PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device()
>> PCI: altera: Simplify TLB_CFG_DW0 usage
>> PCI: altera: Simplify TLP_CFG_DW1 usage
>
> I applied these to pci/host-altera for v4.9. I hope to ask Linus to
> pull them tomorrow, so if you see any issues, let me know soon.
Acked-by: Ley Foon Tan <lftan@altera.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-10-13 10:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 1/6] PCI: altera: Add local struct device pointers Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 2/6] PCI: altera: Remove unused platform data Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 3/6] PCI: altera: Remove redundant platform_get_resource() return value check Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 4/6] PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device() Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 5/6] PCI: altera: Simplify TLB_CFG_DW0 usage Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 6/6] PCI: altera: Simplify TLP_CFG_DW1 usage Bjorn Helgaas
2016-10-12 16:00 ` [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
2016-10-13 10:28 ` Ley Foon Tan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.