From: Ley Foon Tan <lftan@altera.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Russell King <linux@arm.linux.org.uk>,
Marc Zyngier <marc.zyngier@arm.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver
Date: Wed, 14 Oct 2015 16:32:25 +0800 [thread overview]
Message-ID: <CAFiDJ58Uwpv=xUXbBNQcd4FQq=fHGhtCnjTb7TKQBJ0TOxRLig@mail.gmail.com> (raw)
In-Reply-To: <6044983.WR9BTgsOaA@wuerfel>
On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote:
>> +static int altera_pcie_remove(struct platform_device *pdev)
>> +{
>> + struct altera_pcie *pcie = platform_get_drvdata(pdev);
>> +
>> + altera_pcie_free_irq_domain(pcie);
>> + platform_set_drvdata(pdev, NULL);
>> + return 0;
>> +}
>
> I just noticed this. Does it actually work to unload the module
> and tear down all the pci_dev structures in a safe way?
Good catch. It only can be compiled as builtin-moduley now, so we can
remove this _remove callback function.
Thanks.
Regards
Ley Foon
WARNING: multiple messages have this Message-ID (diff)
From: lftan@altera.com (Ley Foon Tan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver
Date: Wed, 14 Oct 2015 16:32:25 +0800 [thread overview]
Message-ID: <CAFiDJ58Uwpv=xUXbBNQcd4FQq=fHGhtCnjTb7TKQBJ0TOxRLig@mail.gmail.com> (raw)
In-Reply-To: <6044983.WR9BTgsOaA@wuerfel>
On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote:
>> +static int altera_pcie_remove(struct platform_device *pdev)
>> +{
>> + struct altera_pcie *pcie = platform_get_drvdata(pdev);
>> +
>> + altera_pcie_free_irq_domain(pcie);
>> + platform_set_drvdata(pdev, NULL);
>> + return 0;
>> +}
>
> I just noticed this. Does it actually work to unload the module
> and tear down all the pci_dev structures in a safe way?
Good catch. It only can be compiled as builtin-moduley now, so we can
remove this _remove callback function.
Thanks.
Regards
Ley Foon
next prev parent reply other threads:[~2015-10-14 8:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 2:41 [PATCH v9 0/6] Altera PCIe host controller driver with MSI support Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` [PATCH v9 1/6] arm: add msi.h to Kbuild Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` [PATCH v9 2/6] pci: add Altera PCI vendor ID Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 8:20 ` Arnd Bergmann
2015-10-14 8:20 ` Arnd Bergmann
2015-10-14 8:32 ` Ley Foon Tan [this message]
2015-10-14 8:32 ` Ley Foon Tan
2015-10-14 9:09 ` Arnd Bergmann
2015-10-14 9:09 ` Arnd Bergmann
2015-10-14 9:28 ` Ley Foon Tan
2015-10-14 9:28 ` Ley Foon Tan
2015-10-14 9:36 ` Arnd Bergmann
2015-10-14 9:36 ` Arnd Bergmann
2015-10-14 10:01 ` Ley Foon Tan
2015-10-14 10:01 ` Ley Foon Tan
2015-10-14 13:32 ` Arnd Bergmann
2015-10-14 13:32 ` Arnd Bergmann
2015-10-16 8:48 ` Ley Foon Tan
2015-10-16 8:48 ` Ley Foon Tan
2015-10-14 2:41 ` [PATCH v9 4/6] pci: altera: Add Altera PCIe MSI driver Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` [PATCH v9 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` [PATCH v9 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
2015-10-14 2:41 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiDJ58Uwpv=xUXbBNQcd4FQq=fHGhtCnjTb7TKQBJ0TOxRLig@mail.gmail.com' \
--to=lftan@altera.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.