* [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node
@ 2019-03-22 9:05 Ley Foon Tan
2019-03-22 9:08 ` Ley Foon Tan
2019-03-22 11:38 ` Simon Goldschmidt
0 siblings, 2 replies; 5+ messages in thread
From: Ley Foon Tan @ 2019-03-22 9:05 UTC (permalink / raw)
To: u-boot
Add QSPI device tree to Stratix 10.
Sync from Linux Stratix 10 dts.
Tested on Stratix 10 SoC devkit.
SOCFPGA_STRATIX10 # sf probe 0:0
SF: Detected mt25qu02g with page size 256 Bytes, erase size 64 KiB, total 256 MiB
Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
arch/arm/dts/socfpga_stratix10.dtsi | 16 ++++++++++++++++
arch/arm/dts/socfpga_stratix10_socdk.dts | 21 +++++++++++++++++++++
2 files changed, 37 insertions(+)
diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi
index ee93725d64..1690f0e0bb 100644
--- a/arch/arm/dts/socfpga_stratix10.dtsi
+++ b/arch/arm/dts/socfpga_stratix10.dtsi
@@ -391,5 +391,21 @@
resets = <&rst WATCHDOG3_RESET>;
status = "disabled";
};
+
+ qspi: spi at ff8d2000 {
+ compatible = "cdns,qspi-nor";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0xff8d2000 0x100>,
+ <0xff900000 0x100000>;
+ interrupts = <0 3 4>;
+ cdns,fifo-depth = <128>;
+ cdns,fifo-width = <4>;
+ cdns,trigger-address = <0x00000000>;
+ bus-num = <0>;
+ /*spi-max-frequency = <50000000>;*/
+ status = "disabled";
+ u-boot,dm-pre-reloc;
+ };
};
};
diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts b/arch/arm/dts/socfpga_stratix10_socdk.dts
index c59b77d829..4c47415b51 100644
--- a/arch/arm/dts/socfpga_stratix10_socdk.dts
+++ b/arch/arm/dts/socfpga_stratix10_socdk.dts
@@ -10,6 +10,7 @@
aliases {
serial0 = &uart0;
+ spi0 = &qspi;
};
chosen {
@@ -87,6 +88,26 @@
smplsel = <0>;
};
+&qspi {
+ status = "okay";
+
+ flash at 0 {
+ u-boot,dm-pre-reloc;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "spi-flash";
+ reg = <0>; /* chip select */
+ spi-max-frequency = <50000000>;
+
+ page-size = <256>;
+ block-size = <16>; /* 2^16, 64KB */
+ cdns,tshsl-ns = <50>;
+ cdns,tsd2d-ns = <50>;
+ cdns,tchsh-ns = <4>;
+ cdns,tslch-ns = <4>;
+ };
+};
+
&uart0 {
status = "okay";
};
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node
2019-03-22 9:05 [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node Ley Foon Tan
@ 2019-03-22 9:08 ` Ley Foon Tan
2019-03-22 10:51 ` Marek Vasut
2019-03-22 11:38 ` Simon Goldschmidt
1 sibling, 1 reply; 5+ messages in thread
From: Ley Foon Tan @ 2019-03-22 9:08 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 5:05 PM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>
> Add QSPI device tree to Stratix 10.
> Sync from Linux Stratix 10 dts.
>
> Tested on Stratix 10 SoC devkit.
> SOCFPGA_STRATIX10 # sf probe 0:0
> SF: Detected mt25qu02g with page size 256 Bytes, erase size 64 KiB, total 256 MiB
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> arch/arm/dts/socfpga_stratix10.dtsi | 16 ++++++++++++++++
> arch/arm/dts/socfpga_stratix10_socdk.dts | 21 +++++++++++++++++++++
> 2 files changed, 37 insertions(+)
>
> diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi
> index ee93725d64..1690f0e0bb 100644
> --- a/arch/arm/dts/socfpga_stratix10.dtsi
> +++ b/arch/arm/dts/socfpga_stratix10.dtsi
> @@ -391,5 +391,21 @@
> resets = <&rst WATCHDOG3_RESET>;
> status = "disabled";
> };
> +
> + qspi: spi at ff8d2000 {
> + compatible = "cdns,qspi-nor";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0xff8d2000 0x100>,
> + <0xff900000 0x100000>;
> + interrupts = <0 3 4>;
> + cdns,fifo-depth = <128>;
> + cdns,fifo-width = <4>;
> + cdns,trigger-address = <0x00000000>;
> + bus-num = <0>;
> + /*spi-max-frequency = <50000000>;*/
Please ignore this patch. Just noticed add this unused /* */ line here.
Will resend again.
Regards
Ley Foon
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node
2019-03-22 9:08 ` Ley Foon Tan
@ 2019-03-22 10:51 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2019-03-22 10:51 UTC (permalink / raw)
To: u-boot
On 3/22/19 10:08 AM, Ley Foon Tan wrote:
> On Fri, Mar 22, 2019 at 5:05 PM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>>
>> Add QSPI device tree to Stratix 10.
>> Sync from Linux Stratix 10 dts.
>>
>> Tested on Stratix 10 SoC devkit.
>> SOCFPGA_STRATIX10 # sf probe 0:0
>> SF: Detected mt25qu02g with page size 256 Bytes, erase size 64 KiB, total 256 MiB
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> ---
>> arch/arm/dts/socfpga_stratix10.dtsi | 16 ++++++++++++++++
>> arch/arm/dts/socfpga_stratix10_socdk.dts | 21 +++++++++++++++++++++
>> 2 files changed, 37 insertions(+)
>>
>> diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi
>> index ee93725d64..1690f0e0bb 100644
>> --- a/arch/arm/dts/socfpga_stratix10.dtsi
>> +++ b/arch/arm/dts/socfpga_stratix10.dtsi
>> @@ -391,5 +391,21 @@
>> resets = <&rst WATCHDOG3_RESET>;
>> status = "disabled";
>> };
>> +
>> + qspi: spi at ff8d2000 {
>> + compatible = "cdns,qspi-nor";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0xff8d2000 0x100>,
>> + <0xff900000 0x100000>;
>> + interrupts = <0 3 4>;
>> + cdns,fifo-depth = <128>;
>> + cdns,fifo-width = <4>;
>> + cdns,trigger-address = <0x00000000>;
>> + bus-num = <0>;
>> + /*spi-max-frequency = <50000000>;*/
> Please ignore this patch. Just noticed add this unused /* */ line here.
> Will resend again.
Then it'd be V2 .
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node
2019-03-22 9:05 [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node Ley Foon Tan
2019-03-22 9:08 ` Ley Foon Tan
@ 2019-03-22 11:38 ` Simon Goldschmidt
2019-03-25 2:29 ` Ley Foon Tan
1 sibling, 1 reply; 5+ messages in thread
From: Simon Goldschmidt @ 2019-03-22 11:38 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 10:05 AM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>
> Add QSPI device tree to Stratix 10.
> Sync from Linux Stratix 10 dts.
>
> Tested on Stratix 10 SoC devkit.
> SOCFPGA_STRATIX10 # sf probe 0:0
> SF: Detected mt25qu02g with page size 256 Bytes, erase size 64 KiB, total 256 MiB
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> arch/arm/dts/socfpga_stratix10.dtsi | 16 ++++++++++++++++
> arch/arm/dts/socfpga_stratix10_socdk.dts | 21 +++++++++++++++++++++
> 2 files changed, 37 insertions(+)
>
> diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi
> index ee93725d64..1690f0e0bb 100644
> --- a/arch/arm/dts/socfpga_stratix10.dtsi
> +++ b/arch/arm/dts/socfpga_stratix10.dtsi
> @@ -391,5 +391,21 @@
> resets = <&rst WATCHDOG3_RESET>;
> status = "disabled";
> };
> +
> + qspi: spi at ff8d2000 {
> + compatible = "cdns,qspi-nor";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0xff8d2000 0x100>,
> + <0xff900000 0x100000>;
> + interrupts = <0 3 4>;
> + cdns,fifo-depth = <128>;
> + cdns,fifo-width = <4>;
> + cdns,trigger-address = <0x00000000>;
> + bus-num = <0>;
> + /*spi-max-frequency = <50000000>;*/
> + status = "disabled";
> + u-boot,dm-pre-reloc;
> + };
> };
> };
> diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts b/arch/arm/dts/socfpga_stratix10_socdk.dts
> index c59b77d829..4c47415b51 100644
> --- a/arch/arm/dts/socfpga_stratix10_socdk.dts
> +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts
> @@ -10,6 +10,7 @@
>
> aliases {
> serial0 = &uart0;
> + spi0 = &qspi;
> };
>
> chosen {
> @@ -87,6 +88,26 @@
> smplsel = <0>;
> };
>
> +&qspi {
> + status = "okay";
> +
> + flash at 0 {
> + u-boot,dm-pre-reloc;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "spi-flash";
"spi-flash" is u-boot specific and about to be deprecated. You should use
the linux-compatible "jedec,spi-nor" binding.
Regards,
Simon
> + reg = <0>; /* chip select */
> + spi-max-frequency = <50000000>;
> +
> + page-size = <256>;
> + block-size = <16>; /* 2^16, 64KB */
> + cdns,tshsl-ns = <50>;
> + cdns,tsd2d-ns = <50>;
> + cdns,tchsh-ns = <4>;
> + cdns,tslch-ns = <4>;
> + };
> +};
> +
> &uart0 {
> status = "okay";
> };
> --
> 2.19.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node
2019-03-22 11:38 ` Simon Goldschmidt
@ 2019-03-25 2:29 ` Ley Foon Tan
0 siblings, 0 replies; 5+ messages in thread
From: Ley Foon Tan @ 2019-03-25 2:29 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 7:39 PM Simon Goldschmidt
<simon.k.r.goldschmidt@gmail.com> wrote:
>
> On Fri, Mar 22, 2019 at 10:05 AM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
> >
> > Add QSPI device tree to Stratix 10.
> > Sync from Linux Stratix 10 dts.
> >
> > Tested on Stratix 10 SoC devkit.
> > SOCFPGA_STRATIX10 # sf probe 0:0
> > SF: Detected mt25qu02g with page size 256 Bytes, erase size 64 KiB, total 256 MiB
> >
> > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> > ---
> > arch/arm/dts/socfpga_stratix10.dtsi | 16 ++++++++++++++++
> > arch/arm/dts/socfpga_stratix10_socdk.dts | 21 +++++++++++++++++++++
> > 2 files changed, 37 insertions(+)
> >
> > diff --git a/arch/arm/dts/socfpga_stratix10.dtsi b/arch/arm/dts/socfpga_stratix10.dtsi
> > index ee93725d64..1690f0e0bb 100644
> > --- a/arch/arm/dts/socfpga_stratix10.dtsi
> > +++ b/arch/arm/dts/socfpga_stratix10.dtsi
> > @@ -391,5 +391,21 @@
> > resets = <&rst WATCHDOG3_RESET>;
> > status = "disabled";
> > };
> > +
> > + qspi: spi at ff8d2000 {
> > + compatible = "cdns,qspi-nor";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0xff8d2000 0x100>,
> > + <0xff900000 0x100000>;
> > + interrupts = <0 3 4>;
> > + cdns,fifo-depth = <128>;
> > + cdns,fifo-width = <4>;
> > + cdns,trigger-address = <0x00000000>;
> > + bus-num = <0>;
> > + /*spi-max-frequency = <50000000>;*/
> > + status = "disabled";
> > + u-boot,dm-pre-reloc;
> > + };
> > };
> > };
> > diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts b/arch/arm/dts/socfpga_stratix10_socdk.dts
> > index c59b77d829..4c47415b51 100644
> > --- a/arch/arm/dts/socfpga_stratix10_socdk.dts
> > +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts
> > @@ -10,6 +10,7 @@
> >
> > aliases {
> > serial0 = &uart0;
> > + spi0 = &qspi;
> > };
> >
> > chosen {
> > @@ -87,6 +88,26 @@
> > smplsel = <0>;
> > };
> >
> > +&qspi {
> > + status = "okay";
> > +
> > + flash at 0 {
> > + u-boot,dm-pre-reloc;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "spi-flash";
>
> "spi-flash" is u-boot specific and about to be deprecated. You should use
> the linux-compatible "jedec,spi-nor" binding.
Okay, will change in next revision.
Regards
Ley Foon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-25 2:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 9:05 [U-Boot] [PATCH] arm: dts: Stratix10: Add QSPI node Ley Foon Tan
2019-03-22 9:08 ` Ley Foon Tan
2019-03-22 10:51 ` Marek Vasut
2019-03-22 11:38 ` Simon Goldschmidt
2019-03-25 2:29 ` Ley Foon Tan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.