* [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c
@ 2016-05-12 16:16 Aurimas Liutikas
2016-05-18 16:12 ` Aurimas Liutikas
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Aurimas Liutikas @ 2016-05-12 16:16 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Signed-off-by: Aurimas Liutikas <aurimas@google.com>
diff --git a/iw.c b/iw.c
index 2aabddb..a6efe5b 100644
--- a/iw.c
+++ b/iw.c
@@ -516,7 +516,7 @@ int main(int argc, char **argv)
const struct cmd *cmd = NULL;
/* calculate command size including padding */
- cmd_size = abs((long)&__section_set - (long)&__section_get);
+ cmd_size = labs((long)&__section_set - (long)&__section_get);
/* strip off self */
argc--;
argv0 = *argv++;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c
2016-05-12 16:16 [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c Aurimas Liutikas
@ 2016-05-18 16:12 ` Aurimas Liutikas
2016-05-27 18:07 ` Aurimas Liutikas
2016-05-30 0:43 ` Julian Calaby
2016-05-31 9:46 ` Johannes Berg
2 siblings, 1 reply; 5+ messages in thread
From: Aurimas Liutikas @ 2016-05-18 16:12 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Hey there! Any thoughts on this patch?
Aurimas
On Thu, May 12, 2016 at 9:16 AM, Aurimas Liutikas <aurimas@google.com> wrote:
> Signed-off-by: Aurimas Liutikas <aurimas@google.com>
>
> diff --git a/iw.c b/iw.c
> index 2aabddb..a6efe5b 100644
> --- a/iw.c
> +++ b/iw.c
> @@ -516,7 +516,7 @@ int main(int argc, char **argv)
> const struct cmd *cmd = NULL;
>
> /* calculate command size including padding */
> - cmd_size = abs((long)&__section_set - (long)&__section_get);
> + cmd_size = labs((long)&__section_set - (long)&__section_get);
> /* strip off self */
> argc--;
> argv0 = *argv++;
--
Aurimas Liutikas | Software Engineer | Chrome / Google
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c
2016-05-18 16:12 ` Aurimas Liutikas
@ 2016-05-27 18:07 ` Aurimas Liutikas
0 siblings, 0 replies; 5+ messages in thread
From: Aurimas Liutikas @ 2016-05-27 18:07 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Hello again! I was curious if this looks like a reasonable change?
Aurimas
On Wed, May 18, 2016 at 9:12 AM, Aurimas Liutikas <aurimas@google.com> wrote:
> Hey there! Any thoughts on this patch?
>
> Aurimas
>
> On Thu, May 12, 2016 at 9:16 AM, Aurimas Liutikas <aurimas@google.com> wrote:
>> Signed-off-by: Aurimas Liutikas <aurimas@google.com>
>>
>> diff --git a/iw.c b/iw.c
>> index 2aabddb..a6efe5b 100644
>> --- a/iw.c
>> +++ b/iw.c
>> @@ -516,7 +516,7 @@ int main(int argc, char **argv)
>> const struct cmd *cmd = NULL;
>>
>> /* calculate command size including padding */
>> - cmd_size = abs((long)&__section_set - (long)&__section_get);
>> + cmd_size = labs((long)&__section_set - (long)&__section_get);
>> /* strip off self */
>> argc--;
>> argv0 = *argv++;
>
>
>
> --
>
> Aurimas Liutikas | Software Engineer | Chrome / Google
--
--
Aurimas Liutikas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c
2016-05-12 16:16 [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c Aurimas Liutikas
2016-05-18 16:12 ` Aurimas Liutikas
@ 2016-05-30 0:43 ` Julian Calaby
2016-05-31 9:46 ` Johannes Berg
2 siblings, 0 replies; 5+ messages in thread
From: Julian Calaby @ 2016-05-30 0:43 UTC (permalink / raw)
To: Aurimas Liutikas; +Cc: Johannes Berg, linux-wireless
Hi Aurimas,
On Fri, May 13, 2016 at 2:16 AM, Aurimas Liutikas <aurimas@google.com> wrote:
You really should add a little more explanation here and include the
exact compiler output you're fixing and mention that this option is
only available with Clang.
> Signed-off-by: Aurimas Liutikas <aurimas@google.com>
Other than that, it looks good to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
One final note, any patch you send to linux-wireless gets entered into
patchwork, so there's no need to keep asking for a review, people are
busy and will get to it eventually.
Thanks,
Julian Calaby
> diff --git a/iw.c b/iw.c
> index 2aabddb..a6efe5b 100644
> --- a/iw.c
> +++ b/iw.c
> @@ -516,7 +516,7 @@ int main(int argc, char **argv)
> const struct cmd *cmd = NULL;
>
> /* calculate command size including padding */
> - cmd_size = abs((long)&__section_set - (long)&__section_get);
> + cmd_size = labs((long)&__section_set - (long)&__section_get);
> /* strip off self */
> argc--;
> argv0 = *argv++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c
2016-05-12 16:16 [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c Aurimas Liutikas
2016-05-18 16:12 ` Aurimas Liutikas
2016-05-30 0:43 ` Julian Calaby
@ 2016-05-31 9:46 ` Johannes Berg
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2016-05-31 9:46 UTC (permalink / raw)
To: Aurimas Liutikas; +Cc: linux-wireless
Applied.
However, note that I had to do it manually, so if you're planning to
send any more patches please fix your mailer to not corrupt whitespace
(the tabs were replaced by spaces, so the patch couldn't apply
automatically)
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-31 9:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-12 16:16 [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c Aurimas Liutikas
2016-05-18 16:12 ` Aurimas Liutikas
2016-05-27 18:07 ` Aurimas Liutikas
2016-05-30 0:43 ` Julian Calaby
2016-05-31 9:46 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.