[PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

[PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

[Ulf Magnusson]

Looks like a change to a comment in zconf.y was never committed, because
the updated version only appears it zconf.tab.c_shipped. Update the
comment in zconf.y to match.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 scripts/kconfig/zconf.y | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y
index c8f396c..4b2cf41 100644
--- a/scripts/kconfig/zconf.y
+++ b/scripts/kconfig/zconf.y
@@ -101,7 +101,7 @@ static struct menu *current_menu, *current_entry;
 } if_entry menu_entry choice_entry
 
 %{
-/* Include zconf_id.c here so it can see the token constants. */
+/* Include kconf_id.c here so it can see the token constants. */
 #include "kconf_id.c"
 %}
 
-- 
2.7.4

Re: [PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

[Masahiro Yamada]

2017-10-05 12:06 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Looks like a change to a comment in zconf.y was never committed, because
> the updated version only appears it zconf.tab.c_shipped. Update the
> comment in zconf.y to match.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
>  scripts/kconfig/zconf.y | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y
> index c8f396c..4b2cf41 100644
> --- a/scripts/kconfig/zconf.y
> +++ b/scripts/kconfig/zconf.y
> @@ -101,7 +101,7 @@ static struct menu *current_menu, *current_entry;
>  } if_entry menu_entry choice_entry
>
>  %{
> -/* Include zconf_id.c here so it can see the token constants. */
> +/* Include kconf_id.c here so it can see the token constants. */
>  #include "kconf_id.c"
>  %}


Applied to linux-kbuild/kconfig.
Thanks!

BTW, I do not know the historical reason
why zconf instead of kconf in the first place...


-- 
Best Regards
Masahiro Yamada

Re: [PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

[Ulf Magnusson]

On Tue, Dec 12, 2017 at 3:58 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2017-10-05 12:06 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
>> Looks like a change to a comment in zconf.y was never committed, because
>> the updated version only appears it zconf.tab.c_shipped. Update the
>> comment in zconf.y to match.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>>  scripts/kconfig/zconf.y | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y
>> index c8f396c..4b2cf41 100644
>> --- a/scripts/kconfig/zconf.y
>> +++ b/scripts/kconfig/zconf.y
>> @@ -101,7 +101,7 @@ static struct menu *current_menu, *current_entry;
>>  } if_entry menu_entry choice_entry
>>
>>  %{
>> -/* Include zconf_id.c here so it can see the token constants. */
>> +/* Include kconf_id.c here so it can see the token constants. */
>>  #include "kconf_id.c"
>>  %}
>
>
> Applied to linux-kbuild/kconfig.
> Thanks!
>
> BTW, I do not know the historical reason
> why zconf instead of kconf in the first place...

I have no idea either. kconfig.{l,y} and kconfig_*() would be a lot
less confusing.

Cheers,
Ulf

Re: [PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

[Sam Ravnborg]

Hi Ulf, Masahiro

> >
> > BTW, I do not know the historical reason
> > why zconf instead of kconf in the first place...
> 
> I have no idea either. kconfig.{l,y} and kconfig_*() would be a lot
> less confusing.

zconf was the name originally invented by Roman Zippel.
kconfig had the name "lc" in the original submission,
but was later renamed to kconfig.
And if memory serves me correct the original codebase used zconf.

The use of Kconfig for the files was first introduced here:
https://sourceforge.net/p/kbuild/mailman/message/8519479/
This was before lc aka kconfig was included in the kernel.

This was all in a period after the huge CML2 flamewars
which some oldies may remember.

Surfing dwom memory lane was fun - lot of mails.

This was also back when Keith Ownes attempt for a new generation
kbuild was rejected and Kai Germaschewski migrated the
old build system to something that was good and reliable.

Fun times indeed :-)
For some of the involved this was not fun at all - investing a lot
of time and then see it rejected is never fun.

	Sam

Re: [PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

[Ulf Magnusson]

On Fri, Jan 12, 2018 at 8:38 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Ulf, Masahiro
>
>> >
>> > BTW, I do not know the historical reason
>> > why zconf instead of kconf in the first place...
>>
>> I have no idea either. kconfig.{l,y} and kconfig_*() would be a lot
>> less confusing.
>
> zconf was the name originally invented by Roman Zippel.
> kconfig had the name "lc" in the original submission,
> but was later renamed to kconfig.
> And if memory serves me correct the original codebase used zconf.
>
> The use of Kconfig for the files was first introduced here:
> https://sourceforge.net/p/kbuild/mailman/message/8519479/
> This was before lc aka kconfig was included in the kernel.
>
> This was all in a period after the huge CML2 flamewars
> which some oldies may remember.
>
> Surfing dwom memory lane was fun - lot of mails.
>
> This was also back when Keith Ownes attempt for a new generation
> kbuild was rejected and Kai Germaschewski migrated the
> old build system to something that was good and reliable.
>
> Fun times indeed :-)
> For some of the involved this was not fun at all - investing a lot
> of time and then see it rejected is never fun.
>
>         Sam

Thanks for the history lesson.

Had heard of the CML2 drama. Bit of a second-system effect going on
there I think.

Python all the way back in 2002 was unexpected. Can see why people
might have been opposed to that.

History aside, I'm all for renaming some things if anyone steps up.
Explicit naming goes a long way for me.

Cheers,
Ulf