* [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
@ 2022-03-16 9:53 marcandre.lureau
[not found] ` <CAMxuvawM-Od_ED4mVoBt+VMYLOn_XEE1DxCKH9n-a4KCdRXSsw@mail.gmail.com>
2022-03-16 20:02 ` John Snow
0 siblings, 2 replies; 3+ messages in thread
From: marcandre.lureau @ 2022-03-16 9:53 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, John Snow, Cleber Rosa
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
scripts/modinfo-collect.py | 5 -----
1 file changed, 5 deletions(-)
diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
index 61b90688c6dc..4e7584df6676 100755
--- a/scripts/modinfo-collect.py
+++ b/scripts/modinfo-collect.py
@@ -18,13 +18,8 @@ def find_command(src, target, compile_commands):
def process_command(src, command):
skip = False
- arg = False
out = []
for item in shlex.split(command):
- if arg:
- out.append(x)
- arg = False
- continue
if skip:
skip = False
continue
--
2.35.1.273.ge6ebfd0e8cbb
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Fwd: Fwd: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
[not found] ` <20220316145445.wh6qy4qiybsbqmk6@sirius.home.kraxel.org>
@ 2022-03-16 14:57 ` Marc-André Lureau
0 siblings, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2022-03-16 14:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Hoffmann, Gerd
---------- Forwarded message ---------
From: Hoffmann, Gerd <kraxel@redhat.com>
Date: Wed, Mar 16, 2022 at 6:54 PM
Subject: Re: Fwd: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
To: Marc-André Lureau <marcandre.lureau@redhat.com>
On Wed, Mar 16, 2022 at 06:33:03PM +0400, Marc-André Lureau wrote:
> Hi Gerd, can you ack?
>
> (get_maintainer.pl doesn't catch you here)
Looks ok, arg is never set to True.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
> thanks
>
> ---------- Forwarded message ---------
> From: <marcandre.lureau@redhat.com>
> Date: Wed, Mar 16, 2022 at 1:53 PM
> Subject: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
> To: <qemu-devel@nongnu.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>, John Snow
> <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>
>
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> scripts/modinfo-collect.py | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
> index 61b90688c6dc..4e7584df6676 100755
> --- a/scripts/modinfo-collect.py
> +++ b/scripts/modinfo-collect.py
> @@ -18,13 +18,8 @@ def find_command(src, target, compile_commands):
>
> def process_command(src, command):
> skip = False
> - arg = False
> out = []
> for item in shlex.split(command):
> - if arg:
> - out.append(x)
> - arg = False
> - continue
> if skip:
> skip = False
> continue
> --
> 2.35.1.273.ge6ebfd0e8cbb
>
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
2022-03-16 9:53 [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code marcandre.lureau
[not found] ` <CAMxuvawM-Od_ED4mVoBt+VMYLOn_XEE1DxCKH9n-a4KCdRXSsw@mail.gmail.com>
@ 2022-03-16 20:02 ` John Snow
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2022-03-16 20:02 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, Cleber Rosa
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Wed, Mar 16, 2022, 5:53 AM <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> scripts/modinfo-collect.py | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
> index 61b90688c6dc..4e7584df6676 100755
> --- a/scripts/modinfo-collect.py
> +++ b/scripts/modinfo-collect.py
> @@ -18,13 +18,8 @@ def find_command(src, target, compile_commands):
>
> def process_command(src, command):
> skip = False
> - arg = False
> out = []
> for item in shlex.split(command):
> - if arg:
> - out.append(x)
> - arg = False
> - continue
> if skip:
> skip = False
> continue
> --
> 2.35.1.273.ge6ebfd0e8cbb
>
Acked-By <jsnow@redhat.com>
[-- Attachment #2: Type: text/html, Size: 1781 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-16 20:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 9:53 [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code marcandre.lureau
[not found] ` <CAMxuvawM-Od_ED4mVoBt+VMYLOn_XEE1DxCKH9n-a4KCdRXSsw@mail.gmail.com>
[not found] ` <20220316145445.wh6qy4qiybsbqmk6@sirius.home.kraxel.org>
2022-03-16 14:57 ` Fwd: Fwd: " Marc-André Lureau
2022-03-16 20:02 ` John Snow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.