From: Vivek Gautam <vivek.gautam@codeaurora.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Andy Gross <andy.gross@linaro.org>, Manu Gautam <mgautam@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] arm64: dts: qcom: msm8996: Use UFS_GDSC for UFS Date: Fri, 25 May 2018 18:21:50 +0530 [thread overview] Message-ID: <CAFp+6iH5bS5rmqZ1oy09COb2Rzuz6zbN7pFwxz0WTJNOYTTbkg@mail.gmail.com> (raw) In-Reply-To: <20180524223122.12601-1-bjorn.andersson@linaro.org> Hi Bjorn, On Fri, May 25, 2018 at 4:01 AM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > The UFS host controller occationally (20%) fails to enable > gcc_ufs_axi_clk because the UFS GDSC is not enabled. In most cases it's > enabled through the UFS phy driver, but to make sure it's enabled let's > enable it directly from the UFS host controller directly as well. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 380e14591686..03c7904bda14 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -674,6 +674,8 @@ > vccq-max-microamp = <450000>; > vccq2-max-microamp = <450000>; > > + power-domains = <&gcc UFS_GDSC>; > + We shouldn't need power-domain with the phy. UFS_GDSC should be attached to the controller, as the phy is powered up only after the controller is power-up, and during collapse too, we turn off the phy first. Can you try testing keeping UFS_GDSC only with ufs controller and remove it from the ufs-phy node? We are doing same on the 4.14 release branch too for db820. I apologize to have missed this in your patch for ufs-related dt nodes. Can we please fix this now? Best regards Vivek > clock-names = > "core_clk_src", > "core_clk", > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: vivek.gautam@codeaurora.org (Vivek Gautam) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: dts: qcom: msm8996: Use UFS_GDSC for UFS Date: Fri, 25 May 2018 18:21:50 +0530 [thread overview] Message-ID: <CAFp+6iH5bS5rmqZ1oy09COb2Rzuz6zbN7pFwxz0WTJNOYTTbkg@mail.gmail.com> (raw) In-Reply-To: <20180524223122.12601-1-bjorn.andersson@linaro.org> Hi Bjorn, On Fri, May 25, 2018 at 4:01 AM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > The UFS host controller occationally (20%) fails to enable > gcc_ufs_axi_clk because the UFS GDSC is not enabled. In most cases it's > enabled through the UFS phy driver, but to make sure it's enabled let's > enable it directly from the UFS host controller directly as well. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 380e14591686..03c7904bda14 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -674,6 +674,8 @@ > vccq-max-microamp = <450000>; > vccq2-max-microamp = <450000>; > > + power-domains = <&gcc UFS_GDSC>; > + We shouldn't need power-domain with the phy. UFS_GDSC should be attached to the controller, as the phy is powered up only after the controller is power-up, and during collapse too, we turn off the phy first. Can you try testing keeping UFS_GDSC only with ufs controller and remove it from the ufs-phy node? We are doing same on the 4.14 release branch too for db820. I apologize to have missed this in your patch for ufs-related dt nodes. Can we please fix this now? Best regards Vivek > clock-names = > "core_clk_src", > "core_clk", > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-05-25 12:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-24 22:31 [PATCH] arm64: dts: qcom: msm8996: Use UFS_GDSC for UFS Bjorn Andersson 2018-05-24 22:31 ` Bjorn Andersson 2018-05-25 12:51 ` Vivek Gautam [this message] 2018-05-25 12:51 ` Vivek Gautam 2018-05-25 18:35 ` Bjorn Andersson 2018-05-25 18:35 ` Bjorn Andersson 2018-05-25 18:45 ` [PATCH v2] arm64: dts: qcom: msm8996: Move UFS_GDSC to UFS HCD Bjorn Andersson 2018-05-25 18:45 ` Bjorn Andersson 2018-05-29 11:01 ` Vivek Gautam 2018-05-29 11:01 ` Vivek Gautam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFp+6iH5bS5rmqZ1oy09COb2Rzuz6zbN7pFwxz0WTJNOYTTbkg@mail.gmail.com \ --to=vivek.gautam@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mgautam@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.