* arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:20 ` Chen-Yu Tsai 0 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2021-07-26 8:20 UTC (permalink / raw) To: Enric Balletbo i Serra, Hsin-Yi Wang, Fabien Parent Cc: linux-mediatek, linux-arm-kernel, linux-gpio, devicetree, Zhiyong Tao Hi, I was looking at MTK pinctrl stuff upstream, and it seems there are a few `mediatek,pull-*-adv` entries that have invalid values: arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; According to the bindings, the values should 0~3. <10> is probably a incorrect attempt at using binary representation, which is wrong. This probably leads to the pull-up/down getting disabled or ignored. Cound people still working on these two devices take a look? Regards ChenYu ^ permalink raw reply [flat|nested] 15+ messages in thread
* arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:20 ` Chen-Yu Tsai 0 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2021-07-26 8:20 UTC (permalink / raw) To: Enric Balletbo i Serra, Hsin-Yi Wang, Fabien Parent Cc: linux-mediatek, linux-arm-kernel, linux-gpio, devicetree, Zhiyong Tao Hi, I was looking at MTK pinctrl stuff upstream, and it seems there are a few `mediatek,pull-*-adv` entries that have invalid values: arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; According to the bindings, the values should 0~3. <10> is probably a incorrect attempt at using binary representation, which is wrong. This probably leads to the pull-up/down getting disabled or ignored. Cound people still working on these two devices take a look? Regards ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:20 ` Chen-Yu Tsai 0 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2021-07-26 8:20 UTC (permalink / raw) To: Enric Balletbo i Serra, Hsin-Yi Wang, Fabien Parent Cc: linux-mediatek, linux-arm-kernel, linux-gpio, devicetree, Zhiyong Tao Hi, I was looking at MTK pinctrl stuff upstream, and it seems there are a few `mediatek,pull-*-adv` entries that have invalid values: arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; According to the bindings, the values should 0~3. <10> is probably a incorrect attempt at using binary representation, which is wrong. This probably leads to the pull-up/down getting disabled or ignored. Cound people still working on these two devices take a look? Regards ChenYu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values 2021-07-26 8:20 ` Chen-Yu Tsai (?) @ 2021-07-26 8:50 ` Hsin-Yi Wang -1 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-07-26 8:50 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > Hi, > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > `mediatek,pull-*-adv` entries that have invalid values: > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-up-adv = <10>; > > According to the bindings, the values should 0~3. <10> is probably a > incorrect attempt at using binary representation, which is wrong. This > probably leads to the pull-up/down getting disabled or ignored. > > Cound people still working on these two devices take a look? > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so the result is same as 2, since the driver test the value by checking the last 2 bit. We should still fix this in dts. > > Regards > ChenYu ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:50 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-07-26 8:50 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > Hi, > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > `mediatek,pull-*-adv` entries that have invalid values: > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-up-adv = <10>; > > According to the bindings, the values should 0~3. <10> is probably a > incorrect attempt at using binary representation, which is wrong. This > probably leads to the pull-up/down getting disabled or ignored. > > Cound people still working on these two devices take a look? > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so the result is same as 2, since the driver test the value by checking the last 2 bit. We should still fix this in dts. > > Regards > ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:50 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-07-26 8:50 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > Hi, > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > `mediatek,pull-*-adv` entries that have invalid values: > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-up-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-down-adv = <10>; > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > mediatek,pull-up-adv = <10>; > > According to the bindings, the values should 0~3. <10> is probably a > incorrect attempt at using binary representation, which is wrong. This > probably leads to the pull-up/down getting disabled or ignored. > > Cound people still working on these two devices take a look? > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so the result is same as 2, since the driver test the value by checking the last 2 bit. We should still fix this in dts. > > Regards > ChenYu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values 2021-07-26 8:50 ` Hsin-Yi Wang (?) @ 2021-07-26 8:58 ` Chen-Yu Tsai -1 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2021-07-26 8:58 UTC (permalink / raw) To: Hsin-Yi Wang Cc: Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > Hi, > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > `mediatek,pull-*-adv` entries that have invalid values: > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > > > According to the bindings, the values should 0~3. <10> is probably a > > incorrect attempt at using binary representation, which is wrong. This > > probably leads to the pull-up/down getting disabled or ignored. > > > > Cound people still working on these two devices take a look? > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > the result is same as 2, since the driver test the value by checking > the last 2 bit. We should still fix this in dts. That probably explains why no one noticed. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:58 ` Chen-Yu Tsai 0 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2021-07-26 8:58 UTC (permalink / raw) To: Hsin-Yi Wang Cc: Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > Hi, > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > `mediatek,pull-*-adv` entries that have invalid values: > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > > > According to the bindings, the values should 0~3. <10> is probably a > > incorrect attempt at using binary representation, which is wrong. This > > probably leads to the pull-up/down getting disabled or ignored. > > > > Cound people still working on these two devices take a look? > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > the result is same as 2, since the driver test the value by checking > the last 2 bit. We should still fix this in dts. That probably explains why no one noticed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 8:58 ` Chen-Yu Tsai 0 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2021-07-26 8:58 UTC (permalink / raw) To: Hsin-Yi Wang Cc: Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > Hi, > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > `mediatek,pull-*-adv` entries that have invalid values: > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > > > According to the bindings, the values should 0~3. <10> is probably a > > incorrect attempt at using binary representation, which is wrong. This > > probably leads to the pull-up/down getting disabled or ignored. > > > > Cound people still working on these two devices take a look? > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > the result is same as 2, since the driver test the value by checking > the last 2 bit. We should still fix this in dts. That probably explains why no one noticed. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values 2021-07-26 8:58 ` Chen-Yu Tsai (?) @ 2021-07-26 9:48 ` Enric Balletbo Serra -1 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo Serra @ 2021-07-26 9:48 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao Hi Chen-Yu and Hsin-Yi, Missatge de Chen-Yu Tsai <wenst@chromium.org> del dia dl., 26 de jul. 2021 a les 10:58: > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > Hi, > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; The confusion comes probably because the binding says that this value is valid, see Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt it'd be nice to convert that binding and the others to yaml format and remove the possibility to specify it in binary format. Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt Should be pretty easy as there is already an example: Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml Thanks, Enric > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-up-adv = <10>; > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > incorrect attempt at using binary representation, which is wrong. This > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > Cound people still working on these two devices take a look? > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > the result is same as 2, since the driver test the value by checking > > the last 2 bit. We should still fix this in dts. > I see that the are > That probably explains why no one noticed. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 9:48 ` Enric Balletbo Serra 0 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo Serra @ 2021-07-26 9:48 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao Hi Chen-Yu and Hsin-Yi, Missatge de Chen-Yu Tsai <wenst@chromium.org> del dia dl., 26 de jul. 2021 a les 10:58: > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > Hi, > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; The confusion comes probably because the binding says that this value is valid, see Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt it'd be nice to convert that binding and the others to yaml format and remove the possibility to specify it in binary format. Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt Should be pretty easy as there is already an example: Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml Thanks, Enric > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-up-adv = <10>; > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > incorrect attempt at using binary representation, which is wrong. This > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > Cound people still working on these two devices take a look? > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > the result is same as 2, since the driver test the value by checking > > the last 2 bit. We should still fix this in dts. > I see that the are > That probably explains why no one noticed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-26 9:48 ` Enric Balletbo Serra 0 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo Serra @ 2021-07-26 9:48 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao Hi Chen-Yu and Hsin-Yi, Missatge de Chen-Yu Tsai <wenst@chromium.org> del dia dl., 26 de jul. 2021 a les 10:58: > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > Hi, > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; The confusion comes probably because the binding says that this value is valid, see Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt it'd be nice to convert that binding and the others to yaml format and remove the possibility to specify it in binary format. Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt Should be pretty easy as there is already an example: Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml Thanks, Enric > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-up-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-down-adv = <10>; > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > mediatek,pull-up-adv = <10>; > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > incorrect attempt at using binary representation, which is wrong. This > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > Cound people still working on these two devices take a look? > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > the result is same as 2, since the driver test the value by checking > > the last 2 bit. We should still fix this in dts. > I see that the are > That probably explains why no one noticed. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values 2021-07-26 9:48 ` Enric Balletbo Serra (?) @ 2021-07-27 11:06 ` Hsin-Yi Wang -1 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-07-27 11:06 UTC (permalink / raw) To: Enric Balletbo Serra Cc: Chen-Yu Tsai, Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 5:48 PM Enric Balletbo Serra <eballetbo@gmail.com> wrote: > > Hi Chen-Yu and Hsin-Yi, > > > Missatge de Chen-Yu Tsai <wenst@chromium.org> del dia dl., 26 de jul. > 2021 a les 10:58: > > > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > > > Hi, > > > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > The confusion comes probably because the binding says that this value > is valid, see > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > it'd be nice to convert that binding and the others to yaml format and > remove the possibility to specify it in binary format. > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt > > Should be pretty easy as there is already an example: > Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > Hi Enric, I've sent a patch for converting these into yaml here: https://lore.kernel.org/patchwork/patch/1468449/ Thanks > Thanks, > Enric > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > > incorrect attempt at using binary representation, which is wrong. This > > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > > > Cound people still working on these two devices take a look? > > > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > > the result is same as 2, since the driver test the value by checking > > > the last 2 bit. We should still fix this in dts. > > > > I see that the are > > > > > That probably explains why no one noticed. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-27 11:06 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-07-27 11:06 UTC (permalink / raw) To: Enric Balletbo Serra Cc: Chen-Yu Tsai, Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 5:48 PM Enric Balletbo Serra <eballetbo@gmail.com> wrote: > > Hi Chen-Yu and Hsin-Yi, > > > Missatge de Chen-Yu Tsai <wenst@chromium.org> del dia dl., 26 de jul. > 2021 a les 10:58: > > > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > > > Hi, > > > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > The confusion comes probably because the binding says that this value > is valid, see > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > it'd be nice to convert that binding and the others to yaml format and > remove the possibility to specify it in binary format. > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt > > Should be pretty easy as there is already an example: > Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > Hi Enric, I've sent a patch for converting these into yaml here: https://lore.kernel.org/patchwork/patch/1468449/ Thanks > Thanks, > Enric > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > > incorrect attempt at using binary representation, which is wrong. This > > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > > > Cound people still working on these two devices take a look? > > > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > > the result is same as 2, since the driver test the value by checking > > > the last 2 bit. We should still fix this in dts. > > > > I see that the are > > > > > That probably explains why no one noticed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values @ 2021-07-27 11:06 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-07-27 11:06 UTC (permalink / raw) To: Enric Balletbo Serra Cc: Chen-Yu Tsai, Enric Balletbo i Serra, Fabien Parent, moderated list:ARM/Mediatek SoC support, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, linux-gpio, Devicetree List, Zhiyong Tao On Mon, Jul 26, 2021 at 5:48 PM Enric Balletbo Serra <eballetbo@gmail.com> wrote: > > Hi Chen-Yu and Hsin-Yi, > > > Missatge de Chen-Yu Tsai <wenst@chromium.org> del dia dl., 26 de jul. > 2021 a les 10:58: > > > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > > > Hi, > > > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > The confusion comes probably because the binding says that this value > is valid, see > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > it'd be nice to convert that binding and the others to yaml format and > remove the possibility to specify it in binary format. > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt > > Should be pretty easy as there is already an example: > Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > Hi Enric, I've sent a patch for converting these into yaml here: https://lore.kernel.org/patchwork/patch/1468449/ Thanks > Thanks, > Enric > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > > incorrect attempt at using binary representation, which is wrong. This > > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > > > Cound people still working on these two devices take a look? > > > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > > the result is same as 2, since the driver test the value by checking > > > the last 2 bit. We should still fix this in dts. > > > > I see that the are > > > > > That probably explains why no one noticed. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-07-27 11:08 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-26 8:20 arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values Chen-Yu Tsai 2021-07-26 8:20 ` Chen-Yu Tsai 2021-07-26 8:20 ` Chen-Yu Tsai 2021-07-26 8:50 ` Hsin-Yi Wang 2021-07-26 8:50 ` Hsin-Yi Wang 2021-07-26 8:50 ` Hsin-Yi Wang 2021-07-26 8:58 ` Chen-Yu Tsai 2021-07-26 8:58 ` Chen-Yu Tsai 2021-07-26 8:58 ` Chen-Yu Tsai 2021-07-26 9:48 ` Enric Balletbo Serra 2021-07-26 9:48 ` Enric Balletbo Serra 2021-07-26 9:48 ` Enric Balletbo Serra 2021-07-27 11:06 ` Hsin-Yi Wang 2021-07-27 11:06 ` Hsin-Yi Wang 2021-07-27 11:06 ` Hsin-Yi Wang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.