* [PATCH -next] rtc: wilco_ec: Make some functions static
@ 2019-02-16 1:36 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2019-02-16 1:36 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Nick Crews
Cc: Wei Yongjun, linux-rtc, kernel-janitors
Fixes the following sparse warnings:
drivers/rtc/rtc-wilco-ec.c:72:5: warning:
symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
drivers/rtc/rtc-wilco-ec.c:106:5: warning:
symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/rtc/rtc-wilco-ec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
index 35cc56114c1c..e62bda0cb53e 100644
--- a/drivers/rtc/rtc-wilco-ec.c
+++ b/drivers/rtc/rtc-wilco-ec.c
@@ -69,7 +69,7 @@ struct ec_rtc_write {
u8 weekday;
} __packed;
-int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
+static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
{
struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
u8 param = EC_CMOS_TOD_READ;
@@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
return 0;
}
-int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
+static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
{
struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
struct ec_rtc_write rtc;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] rtc: wilco_ec: Make some functions static
@ 2019-02-16 1:36 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2019-02-16 1:36 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Nick Crews
Cc: Wei Yongjun, linux-rtc, kernel-janitors
Fixes the following sparse warnings:
drivers/rtc/rtc-wilco-ec.c:72:5: warning:
symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
drivers/rtc/rtc-wilco-ec.c:106:5: warning:
symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/rtc/rtc-wilco-ec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
index 35cc56114c1c..e62bda0cb53e 100644
--- a/drivers/rtc/rtc-wilco-ec.c
+++ b/drivers/rtc/rtc-wilco-ec.c
@@ -69,7 +69,7 @@ struct ec_rtc_write {
u8 weekday;
} __packed;
-int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
+static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
{
struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
u8 param = EC_CMOS_TOD_READ;
@@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
return 0;
}
-int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
+static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
{
struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
struct ec_rtc_write rtc;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] rtc: wilco_ec: Make some functions static
2019-02-16 1:36 ` Wei Yongjun
@ 2019-02-18 14:48 ` Alexandre Belloni
-1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2019-02-18 14:48 UTC (permalink / raw)
To: Wei Yongjun, Enric Balletbo Serra
Cc: Alessandro Zummo, Nick Crews, linux-rtc, kernel-janitors
Enric,
You should take that one or squash it with the original commit.
On 16/02/2019 01:36:03+0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/rtc/rtc-wilco-ec.c:72:5: warning:
> symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
> drivers/rtc/rtc-wilco-ec.c:106:5: warning:
> symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
>
> Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/rtc/rtc-wilco-ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> index 35cc56114c1c..e62bda0cb53e 100644
> --- a/drivers/rtc/rtc-wilco-ec.c
> +++ b/drivers/rtc/rtc-wilco-ec.c
> @@ -69,7 +69,7 @@ struct ec_rtc_write {
> u8 weekday;
> } __packed;
>
> -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> u8 param = EC_CMOS_TOD_READ;
> @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> return 0;
> }
>
> -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> struct ec_rtc_write rtc;
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] rtc: wilco_ec: Make some functions static
@ 2019-02-18 14:48 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2019-02-18 14:48 UTC (permalink / raw)
To: Wei Yongjun, Enric Balletbo Serra
Cc: Alessandro Zummo, Nick Crews, linux-rtc, kernel-janitors
Enric,
You should take that one or squash it with the original commit.
On 16/02/2019 01:36:03+0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/rtc/rtc-wilco-ec.c:72:5: warning:
> symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
> drivers/rtc/rtc-wilco-ec.c:106:5: warning:
> symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
>
> Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/rtc/rtc-wilco-ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> index 35cc56114c1c..e62bda0cb53e 100644
> --- a/drivers/rtc/rtc-wilco-ec.c
> +++ b/drivers/rtc/rtc-wilco-ec.c
> @@ -69,7 +69,7 @@ struct ec_rtc_write {
> u8 weekday;
> } __packed;
>
> -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> u8 param = EC_CMOS_TOD_READ;
> @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> return 0;
> }
>
> -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> struct ec_rtc_write rtc;
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] rtc: wilco_ec: Make some functions static
2019-02-18 14:48 ` Alexandre Belloni
@ 2019-02-18 15:57 ` Enric Balletbo Serra
-1 siblings, 0 replies; 6+ messages in thread
From: Enric Balletbo Serra @ 2019-02-18 15:57 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Wei Yongjun, Alessandro Zummo, Nick Crews, linux-rtc, kernel-janitors
Missatge de Alexandre Belloni <alexandre.belloni@bootlin.com> del dia
dl., 18 de febr. 2019 a les 15:48:
>
> Enric,
>
> You should take that one or squash it with the original commit.
>
Ok, thanks. If Wei doesn't mind I'd like to squash as this is still for-next.
> On 16/02/2019 01:36:03+0000, Wei Yongjun wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/rtc/rtc-wilco-ec.c:72:5: warning:
> > symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
> > drivers/rtc/rtc-wilco-ec.c:106:5: warning:
> > symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
> >
> > Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/rtc/rtc-wilco-ec.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> > index 35cc56114c1c..e62bda0cb53e 100644
> > --- a/drivers/rtc/rtc-wilco-ec.c
> > +++ b/drivers/rtc/rtc-wilco-ec.c
> > @@ -69,7 +69,7 @@ struct ec_rtc_write {
> > u8 weekday;
> > } __packed;
> >
> > -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> > +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> > {
> > struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> > u8 param = EC_CMOS_TOD_READ;
> > @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> > return 0;
> > }
> >
> > -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> > +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> > {
> > struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> > struct ec_rtc_write rtc;
> >
> >
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] rtc: wilco_ec: Make some functions static
@ 2019-02-18 15:57 ` Enric Balletbo Serra
0 siblings, 0 replies; 6+ messages in thread
From: Enric Balletbo Serra @ 2019-02-18 15:57 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Wei Yongjun, Alessandro Zummo, Nick Crews, linux-rtc, kernel-janitors
Missatge de Alexandre Belloni <alexandre.belloni@bootlin.com> del dia
dl., 18 de febr. 2019 a les 15:48:
>
> Enric,
>
> You should take that one or squash it with the original commit.
>
Ok, thanks. If Wei doesn't mind I'd like to squash as this is still for-next.
> On 16/02/2019 01:36:03+0000, Wei Yongjun wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/rtc/rtc-wilco-ec.c:72:5: warning:
> > symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
> > drivers/rtc/rtc-wilco-ec.c:106:5: warning:
> > symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
> >
> > Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/rtc/rtc-wilco-ec.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> > index 35cc56114c1c..e62bda0cb53e 100644
> > --- a/drivers/rtc/rtc-wilco-ec.c
> > +++ b/drivers/rtc/rtc-wilco-ec.c
> > @@ -69,7 +69,7 @@ struct ec_rtc_write {
> > u8 weekday;
> > } __packed;
> >
> > -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> > +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> > {
> > struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> > u8 param = EC_CMOS_TOD_READ;
> > @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> > return 0;
> > }
> >
> > -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> > +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> > {
> > struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> > struct ec_rtc_write rtc;
> >
> >
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-18 15:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-16 1:36 [PATCH -next] rtc: wilco_ec: Make some functions static Wei Yongjun
2019-02-16 1:36 ` Wei Yongjun
2019-02-18 14:48 ` Alexandre Belloni
2019-02-18 14:48 ` Alexandre Belloni
2019-02-18 15:57 ` Enric Balletbo Serra
2019-02-18 15:57 ` Enric Balletbo Serra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.