All of lore.kernel.org
 help / color / mirror / Atom feed
From: Souptick Joarder <jrdr.linux@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, sashal@kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	sstabellini@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	david@redhat.com, osalvador@suse.com,
	Michal Hocko <mhocko@suse.com>,
	pasha.tatashin@soleen.com,
	Dan Williams <dan.j.williams@intel.com>,
	richard.weiyang@gmail.com, Qian Cai <cai@lca.pw>,
	linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
	Linux-MM <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Remove __online_page_set_limits()
Date: Tue, 10 Sep 2019 18:26:28 +0530	[thread overview]
Message-ID: <CAFqt6zZNHGdgaiiRvz-1AFe5g1652oyZpNQidK1V0B6weQHz0w@mail.gmail.com> (raw)
In-Reply-To: <20190909154253.q55olcm4cqwh7izd@box>

On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
> > __online_page_set_limits() is a dummy function and an extra call
> > to this can be avoided.
> >
> > As both of the callers are now removed, __online_page_set_limits()
> > can be removed permanently.
> >
> > Souptick Joarder (3):
> >   hv_ballon: Avoid calling dummy function __online_page_set_limits()
> >   xen/ballon: Avoid calling dummy function __online_page_set_limits()
> >   mm/memory_hotplug.c: Remove __online_page_set_limits()
> >
> >  drivers/hv/hv_balloon.c        | 1 -
> >  drivers/xen/balloon.c          | 1 -
> >  include/linux/memory_hotplug.h | 1 -
> >  mm/memory_hotplug.c            | 5 -----
> >  4 files changed, 8 deletions(-)
>
> Do we really need 3 separate patches to remove 8 lines of code?

I prefer to split into series of 3 which looks more clean. But I am ok
with other option.
Would you like to merge into single one ?

WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: sashal@kernel.org, Juergen Gross <jgross@suse.com>,
	linux-hyperv@vger.kernel.org, sstabellini@kernel.org,
	sthemmin@microsoft.com, pasha.tatashin@soleen.com,
	david@redhat.com, haiyangz@microsoft.com,
	Dan Williams <dan.j.williams@intel.com>,
	linux-kernel@vger.kernel.org, richard.weiyang@gmail.com,
	Linux-MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>,
	Qian Cai <cai@lca.pw>,
	xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	kys@microsoft.com, Andrew Morton <akpm@linux-foundation.org>,
	osalvador@suse.com
Subject: Re: [Xen-devel] [PATCH 0/3] Remove __online_page_set_limits()
Date: Tue, 10 Sep 2019 18:26:28 +0530	[thread overview]
Message-ID: <CAFqt6zZNHGdgaiiRvz-1AFe5g1652oyZpNQidK1V0B6weQHz0w@mail.gmail.com> (raw)
In-Reply-To: <20190909154253.q55olcm4cqwh7izd@box>

On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
> > __online_page_set_limits() is a dummy function and an extra call
> > to this can be avoided.
> >
> > As both of the callers are now removed, __online_page_set_limits()
> > can be removed permanently.
> >
> > Souptick Joarder (3):
> >   hv_ballon: Avoid calling dummy function __online_page_set_limits()
> >   xen/ballon: Avoid calling dummy function __online_page_set_limits()
> >   mm/memory_hotplug.c: Remove __online_page_set_limits()
> >
> >  drivers/hv/hv_balloon.c        | 1 -
> >  drivers/xen/balloon.c          | 1 -
> >  include/linux/memory_hotplug.h | 1 -
> >  mm/memory_hotplug.c            | 5 -----
> >  4 files changed, 8 deletions(-)
>
> Do we really need 3 separate patches to remove 8 lines of code?

I prefer to split into series of 3 which looks more clean. But I am ok
with other option.
Would you like to merge into single one ?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-09-10 12:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
2019-09-07 21:47 ` [Xen-devel] " Souptick Joarder
2019-09-07 21:47 ` [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits() Souptick Joarder
2019-09-07 21:47   ` [Xen-devel] " Souptick Joarder
2019-09-09  7:54   ` David Hildenbrand
2019-09-09  7:54     ` [Xen-devel] " David Hildenbrand
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
2019-09-07 21:47   ` [Xen-devel] " Souptick Joarder
2019-09-08  5:09   ` Juergen Gross
2019-09-08  5:09     ` [Xen-devel] " Juergen Gross
2019-09-09  7:54   ` David Hildenbrand
2019-09-09  7:54     ` [Xen-devel] " David Hildenbrand
2019-09-07 21:47 ` [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits() Souptick Joarder
2019-09-07 21:47   ` [Xen-devel] " Souptick Joarder
2019-09-09  7:54   ` David Hildenbrand
2019-09-09  7:54     ` [Xen-devel] " David Hildenbrand
2019-09-09  8:12 ` [PATCH 0/3] " Michal Hocko
2019-09-09  8:12   ` [Xen-devel] " Michal Hocko
2019-09-09 15:42 ` Kirill A. Shutemov
2019-09-09 15:42   ` [Xen-devel] " Kirill A. Shutemov
2019-09-10 12:56   ` Souptick Joarder [this message]
2019-09-10 12:56     ` Souptick Joarder
2019-09-10 12:56     ` Souptick Joarder
2019-09-10 12:58     ` David Hildenbrand
2019-09-10 12:58       ` [Xen-devel] " David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqt6zZNHGdgaiiRvz-1AFe5g1652oyZpNQidK1V0B6weQHz0w@mail.gmail.com \
    --to=jrdr.linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=cai@lca.pw \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=haiyangz@microsoft.com \
    --cc=jgross@suse.com \
    --cc=kirill@shutemov.name \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=richard.weiyang@gmail.com \
    --cc=sashal@kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.