All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs: f2fs: Adding new return type vm_fault_t
@ 2018-04-14 20:10 Souptick Joarder
  2018-04-16  1:47 ` Chao Yu
  0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2018-04-14 20:10 UTC (permalink / raw)
  To: jaegeuk, yuchao0; +Cc: willy, linux-f2fs-devel

Use new return type vm_fault_t for page_mkwrite
and fault handler.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
---
 fs/f2fs/file.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 672a542..045337a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -33,19 +33,19 @@
 #include "trace.h"
 #include <trace/events/f2fs.h>
 
-static int f2fs_filemap_fault(struct vm_fault *vmf)
+static vm_fault_t f2fs_filemap_fault(struct vm_fault *vmf)
 {
 	struct inode *inode = file_inode(vmf->vma->vm_file);
-	int err;
+	vm_fault_t ret;
 
 	down_read(&F2FS_I(inode)->i_mmap_sem);
-	err = filemap_fault(vmf);
+	ret = filemap_fault(vmf);
 	up_read(&F2FS_I(inode)->i_mmap_sem);
 
-	return err;
+	return ret;
 }
 
-static int f2fs_vm_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct inode *inode = file_inode(vmf->vma->vm_file);
-- 
1.9.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] fs: f2fs: Adding new return type vm_fault_t
  2018-04-14 20:10 [PATCH] fs: f2fs: Adding new return type vm_fault_t Souptick Joarder
@ 2018-04-16  1:47 ` Chao Yu
  2018-05-10 15:32   ` Souptick Joarder
  0 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2018-04-16  1:47 UTC (permalink / raw)
  To: Souptick Joarder, jaegeuk; +Cc: willy, linux-f2fs-devel

On 2018/4/15 4:10, Souptick Joarder wrote:
> Use new return type vm_fault_t for page_mkwrite
> and fault handler.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

Acked-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
>  fs/f2fs/file.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 672a542..045337a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -33,19 +33,19 @@
>  #include "trace.h"
>  #include <trace/events/f2fs.h>
>  
> -static int f2fs_filemap_fault(struct vm_fault *vmf)
> +static vm_fault_t f2fs_filemap_fault(struct vm_fault *vmf)
>  {
>  	struct inode *inode = file_inode(vmf->vma->vm_file);
> -	int err;
> +	vm_fault_t ret;
>  
>  	down_read(&F2FS_I(inode)->i_mmap_sem);
> -	err = filemap_fault(vmf);
> +	ret = filemap_fault(vmf);
>  	up_read(&F2FS_I(inode)->i_mmap_sem);
>  
> -	return err;
> +	return ret;
>  }
>  
> -static int f2fs_vm_page_mkwrite(struct vm_fault *vmf)
> +static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
>  {
>  	struct page *page = vmf->page;
>  	struct inode *inode = file_inode(vmf->vma->vm_file);
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] fs: f2fs: Adding new return type vm_fault_t
  2018-04-16  1:47 ` Chao Yu
@ 2018-05-10 15:32   ` Souptick Joarder
  2018-05-10 16:23     ` Jaegeuk Kim
  0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2018-05-10 15:32 UTC (permalink / raw)
  To: Chao Yu; +Cc: jaegeuk, Matthew Wilcox, linux-f2fs-devel

On Mon, Apr 16, 2018 at 7:17 AM, Chao Yu <yuchao0@huawei.com> wrote:
> On 2018/4/15 4:10, Souptick Joarder wrote:
>> Use new return type vm_fault_t for page_mkwrite
>> and fault handler.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>
> Acked-by: Chao Yu <yuchao0@huawei.com>
>

Chao, If no further comment, we would like to get this patch
queued for 4.18.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] fs: f2fs: Adding new return type vm_fault_t
  2018-05-10 15:32   ` Souptick Joarder
@ 2018-05-10 16:23     ` Jaegeuk Kim
  2018-05-10 17:12       ` Souptick Joarder
  0 siblings, 1 reply; 6+ messages in thread
From: Jaegeuk Kim @ 2018-05-10 16:23 UTC (permalink / raw)
  To: Souptick Joarder; +Cc: Matthew Wilcox, linux-f2fs-devel

On 05/10, Souptick Joarder wrote:
> On Mon, Apr 16, 2018 at 7:17 AM, Chao Yu <yuchao0@huawei.com> wrote:
> > On 2018/4/15 4:10, Souptick Joarder wrote:
> >> Use new return type vm_fault_t for page_mkwrite
> >> and fault handler.
> >>
> >> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> >
> > Acked-by: Chao Yu <yuchao0@huawei.com>
> >
> 
> Chao, If no further comment, we would like to get this patch
> queued for 4.18.

Hi Souptick,

Is this one of your patch series?
I already queued it towards 4.18:

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=f8fcb679cfbeb2076c547364929182babdd69a50

Thanks,

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] fs: f2fs: Adding new return type vm_fault_t
  2018-05-10 16:23     ` Jaegeuk Kim
@ 2018-05-10 17:12       ` Souptick Joarder
  2018-05-14  3:47         ` Chao Yu
  0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2018-05-10 17:12 UTC (permalink / raw)
  To: Jaegeuk Kim; +Cc: Matthew Wilcox, linux-f2fs-devel

On Thu, May 10, 2018 at 9:53 PM, Jaegeuk Kim <jaegeuk@kernel.org> wrote:
> On 05/10, Souptick Joarder wrote:
>> On Mon, Apr 16, 2018 at 7:17 AM, Chao Yu <yuchao0@huawei.com> wrote:
>> > On 2018/4/15 4:10, Souptick Joarder wrote:
>> >> Use new return type vm_fault_t for page_mkwrite
>> >> and fault handler.
>> >>
>> >> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> >> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>> >
>> > Acked-by: Chao Yu <yuchao0@huawei.com>
>> >
>>
>> Chao, If no further comment, we would like to get this patch
>> queued for 4.18.
>
> Hi Souptick,
>
> Is this one of your patch series?
> I already queued it towards 4.18:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=f8fcb679cfbeb2076c547364929182babdd69a50
>
> Thanks,

Thanks.
Not exactly part of patch series. But we are trickling patches to
individual maintainers of each drivers/ filesystems to merge it in
linus tree.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] fs: f2fs: Adding new return type vm_fault_t
  2018-05-10 17:12       ` Souptick Joarder
@ 2018-05-14  3:47         ` Chao Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2018-05-14  3:47 UTC (permalink / raw)
  To: Souptick Joarder, Jaegeuk Kim; +Cc: Matthew Wilcox, linux-f2fs-devel

On 2018/5/11 1:12, Souptick Joarder wrote:
> On Thu, May 10, 2018 at 9:53 PM, Jaegeuk Kim <jaegeuk@kernel.org> wrote:
>> On 05/10, Souptick Joarder wrote:
>>> On Mon, Apr 16, 2018 at 7:17 AM, Chao Yu <yuchao0@huawei.com> wrote:
>>>> On 2018/4/15 4:10, Souptick Joarder wrote:
>>>>> Use new return type vm_fault_t for page_mkwrite
>>>>> and fault handler.
>>>>>
>>>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>>>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>>>>
>>>> Acked-by: Chao Yu <yuchao0@huawei.com>
>>>>
>>>
>>> Chao, If no further comment, we would like to get this patch

No further comment, no matter queuing in Jaegeuk's tree or other one's tree is
OK to me. ;)

Thanks,

>>> queued for 4.18.
>>
>> Hi Souptick,
>>
>> Is this one of your patch series?
>> I already queued it towards 4.18:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=f8fcb679cfbeb2076c547364929182babdd69a50
>>
>> Thanks,
> 
> Thanks.
> Not exactly part of patch series. But we are trickling patches to
> individual maintainers of each drivers/ filesystems to merge it in
> linus tree.
> 
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-14  3:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-14 20:10 [PATCH] fs: f2fs: Adding new return type vm_fault_t Souptick Joarder
2018-04-16  1:47 ` Chao Yu
2018-05-10 15:32   ` Souptick Joarder
2018-05-10 16:23     ` Jaegeuk Kim
2018-05-10 17:12       ` Souptick Joarder
2018-05-14  3:47         ` Chao Yu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.