All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Palmer <daniel@0x0f.com>
To: Rob Herring <robh@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-leds@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	pavel@ucw.cz,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger
Date: Tue, 28 Sep 2021 07:51:40 +0900	[thread overview]
Message-ID: <CAFr9PXnowBM-jAh4cnnngR00eJtB+dXArpircntEth0TU0UnjQ@mail.gmail.com> (raw)
In-Reply-To: <YVIhEJCJ9lr3ZKzM@robh.at.kernel.org>

Hi Rob,

On Tue, 28 Sept 2021 at 04:52, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote:
> > The "activity" trigger can be used as the default but it's currently
> > undocumented so validating a devicetree that uses it causes a warning.
>
> It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some
> reason that can't be used?

LED_FUNCTION_CPU seems to be tied to
drivers/leds/trigger/ledtrig-cpu.c which I think serves the same
purpose but does it a slightly different way.
Would adding LED_FUNCTION_ACTIVITY work?

Thanks,

Daniel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Palmer <daniel@0x0f.com>
To: Rob Herring <robh@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-leds@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	pavel@ucw.cz,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger
Date: Tue, 28 Sep 2021 07:51:40 +0900	[thread overview]
Message-ID: <CAFr9PXnowBM-jAh4cnnngR00eJtB+dXArpircntEth0TU0UnjQ@mail.gmail.com> (raw)
In-Reply-To: <YVIhEJCJ9lr3ZKzM@robh.at.kernel.org>

Hi Rob,

On Tue, 28 Sept 2021 at 04:52, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote:
> > The "activity" trigger can be used as the default but it's currently
> > undocumented so validating a devicetree that uses it causes a warning.
>
> It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some
> reason that can't be used?

LED_FUNCTION_CPU seems to be tied to
drivers/leds/trigger/ledtrig-cpu.c which I think serves the same
purpose but does it a slightly different way.
Would adding LED_FUNCTION_ACTIVITY work?

Thanks,

Daniel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-27 22:49 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  6:54 [PATCH v2 00/11] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-09-23  6:54 ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 01/11] dt-bindings: gpio: msc313: Add compatible " Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 02/11] dt-bindings: gpio: msc313: Add offsets " Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-27 19:52   ` Rob Herring
2021-09-27 19:52     ` Rob Herring
2021-09-27 22:51     ` Daniel Palmer [this message]
2021-09-27 22:51       ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 04/11] gpio: msc313: Code clean ups Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 05/11] gpio: msc313: Add support for SSD201 and SSD202D Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 06/11] ARM: dts: mstar: Set gpio compatible for ssd20xd Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 07/11] ARM: dts: mstar: unitv2: Wire up LEDs Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-11-30 18:55   ` Pavel Machek
2021-11-30 18:55     ` Pavel Machek
2021-12-02  9:44     ` Daniel Palmer
2021-12-02  9:44       ` Daniel Palmer
2022-10-02 10:26       ` Pavel Machek
2022-10-02 10:26         ` Pavel Machek
2021-09-23  6:54 ` [PATCH v2 08/11] ARM: dts: mstar: unitv2: Add core regulator Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 09/11] ARM: dts: mstar: unitv2: Add io regulator Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:54 ` [PATCH v2 10/11] ARM: dts: mstar: unitv2: Add DRAM regulator Daniel Palmer
2021-09-23  6:54   ` Daniel Palmer
2021-09-23  6:55 ` [PATCH v2 11/11] ARM: dts: mstar: unitv2: Add wifi switch Daniel Palmer
2021-09-23  6:55   ` Daniel Palmer
2021-11-19 13:11 ` [PATCH v2 00/11] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-11-19 13:11   ` Daniel Palmer
2021-11-22  0:04   ` Linus Walleij
2021-11-22  0:04     ` Linus Walleij
2021-11-22 10:01     ` Daniel Palmer
2021-11-22 10:01       ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFr9PXnowBM-jAh4cnnngR00eJtB+dXArpircntEth0TU0UnjQ@mail.gmail.com \
    --to=daniel@0x0f.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.