* [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines
@ 2016-09-14 22:16 Namrata A Shettar
2016-09-15 5:17 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Namrata A Shettar @ 2016-09-14 22:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Malcolm Priestley, Alison Schofield,
maomao xu, Othmar Pasteka, Parth Sane, Wolfram Sang,
outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
This patch resolves checkpatch issue of unnecessary blank lines.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
---
drivers/staging/vt6656/main_usb.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index 0594828..d79f07f 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -692,7 +692,6 @@ static void vnt_bss_info_changed(struct ieee80211_hw
*hw,
if (changed & BSS_CHANGED_BSSID && conf->bssid)
vnt_mac_set_bssid_addr(priv, (u8 *)conf->bssid);
-
if (changed & BSS_CHANGED_BASIC_RATES) {
priv->basic_rates = conf->basic_rates;
@@ -814,7 +813,6 @@ static void vnt_configure(struct ieee80211_hw *hw,
} else {
rx_mode &= ~(RCR_MULTICAST | RCR_BROADCAST);
}
-
}
if (changed_flags & (FIF_OTHER_BSS | FIF_BCN_PRBRESP_PROMISC)) {
@@ -925,8 +923,7 @@ static const struct ieee80211_ops vnt_mac_ops = {
int vnt_init(struct vnt_private *priv)
{
-
- if (!(vnt_init_registers(priv)))
+ if (!(vnt_init_registers(priv)))
return -EAGAIN;
SET_IEEE80211_PERM_ADDR(priv->hw, priv->permanent_net_addr);
--
2.7.4
[-- Attachment #2: Type: text/html, Size: 1909 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines
2016-09-14 22:16 [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines Namrata A Shettar
@ 2016-09-15 5:17 ` Julia Lawall
[not found] ` <20160915174614.GA6219@namrata-HP-Pavilion-g6-Notebook-PC>
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2016-09-15 5:17 UTC (permalink / raw)
To: Namrata A Shettar
Cc: Greg Kroah-Hartman, Malcolm Priestley, Alison Schofield,
maomao xu, Othmar Pasteka, Parth Sane, Wolfram Sang,
outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2254 bytes --]
On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> This patch resolves checkpatch issue of unnecessary blank lines.
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/vt6656/main_usb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c
> b/drivers/staging/vt6656/main_usb.c
> index 0594828..d79f07f 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -692,7 +692,6 @@ static void vnt_bss_info_changed(struct ieee80211_hw
> *hw,
> if (changed & BSS_CHANGED_BSSID && conf->bssid)
> vnt_mac_set_bssid_addr(priv, (u8 *)conf->bssid);
>
> -
> if (changed & BSS_CHANGED_BASIC_RATES) {
> priv->basic_rates = conf->basic_rates;
>
> @@ -814,7 +813,6 @@ static void vnt_configure(struct ieee80211_hw *hw,
> } else {
> rx_mode &= ~(RCR_MULTICAST | RCR_BROADCAST);
> }
> -
> }
>
> if (changed_flags & (FIF_OTHER_BSS | FIF_BCN_PRBRESP_PROMISC)) {
> @@ -925,8 +923,7 @@ static const struct ieee80211_ops vnt_mac_ops = {
>
> int vnt_init(struct vnt_private *priv)
> {
> -
> - if (!(vnt_init_registers(priv)))
> + if (!(vnt_init_registers(priv)))
Here you seem to have added an extra space. Actually all the spaces
should be removed, and there should be a tab. But in any case it is not a
blank line change.
julia
> return -EAGAIN;
>
> SET_IEEE80211_PERM_ADDR(priv->hw,
> priv->permanent_net_addr);[cleardot.gif]
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDHKq8Ktv05E5zpQfiD
> fQGgceZu5B19WXF1bdhJT%3Dw6tYg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines
[not found] ` <20160915174614.GA6219@namrata-HP-Pavilion-g6-Notebook-PC>
@ 2016-09-15 18:00 ` Namrata A Shettar
2016-09-15 19:25 ` Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Namrata A Shettar @ 2016-09-15 18:00 UTC (permalink / raw)
To: outreachy-kernel, Julia Lawall
[-- Attachment #1: Type: text/plain, Size: 3763 bytes --]
On Thu, Sep 15, 2016 at 07:17:53AM +0200, Julia Lawall wrote:
>
>
> On Thu, 15 Sep 2016, Namrata A Shettar wrote:
>
> > This patch resolves checkpatch issue of unnecessary blank lines.
> >
> > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > ---
> > int vnt_init(struct vnt_private *priv)
> > {
> > -
> > - if (!(vnt_init_registers(priv)))
> > + if (!(vnt_init_registers(priv)))
> >
>
> Here you seem to have added an extra space. Actually all the spaces
> should be removed, and there should be a tab. But in any case it is not a
> blank line change.
>
> julia
>
There is actually a blank line change but I added a space by mistake
while deleting the blank line.So will I have to abandon this patch.If
yes,then in the new version of the patchset I make ,do I have to change
the numbering? Will be more careful the next time!
Thanks,
Namrata
On Thu, Sep 15, 2016 at 11:16 PM, Namrata A Shettar <
namrataashettar@gmail.com> wrote:
> There is actually a blank line change but I added a space by mistake
> while deleting the blank line.So will I have to abandon this patch.If
> yes,then in the new version of the patchset I make do I have to change
> the numbering.Once again thanks for your inputs!
>
> -Namrata
>
> On Thu, Sep 15, 2016 at 07:17:53AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> >
> > > This patch resolves checkpatch issue of unnecessary blank lines.
> > >
> > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > ---
> > > drivers/staging/vt6656/main_usb.c | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6656/main_usb.c
> > > b/drivers/staging/vt6656/main_usb.c
> > > index 0594828..d79f07f 100644
> > > --- a/drivers/staging/vt6656/main_usb.c
> > > +++ b/drivers/staging/vt6656/main_usb.c
> > > @@ -692,7 +692,6 @@ static void vnt_bss_info_changed(struct
> ieee80211_hw
> > > *hw,
> > > if (changed & BSS_CHANGED_BSSID && conf->bssid)
> > > vnt_mac_set_bssid_addr(priv, (u8 *)conf->bssid);
> > >
> > > -
> > > if (changed & BSS_CHANGED_BASIC_RATES) {
> > > priv->basic_rates = conf->basic_rates;
> > >
> > > @@ -814,7 +813,6 @@ static void vnt_configure(struct ieee80211_hw *hw,
> > > } else {
> > > rx_mode &= ~(RCR_MULTICAST | RCR_BROADCAST);
> > > }
> > > -
> > > }
> > >
> > > if (changed_flags & (FIF_OTHER_BSS | FIF_BCN_PRBRESP_PROMISC))
> {
> > > @@ -925,8 +923,7 @@ static const struct ieee80211_ops vnt_mac_ops = {
> > >
> > > int vnt_init(struct vnt_private *priv)
> > > {
> > > -
> > > - if (!(vnt_init_registers(priv)))
> > > + if (!(vnt_init_registers(priv)))
> >
> > Here you seem to have added an extra space. Actually all the spaces
> > should be removed, and there should be a tab. But in any case it is not
> a
> > blank line change.
> >
> > julia
> >
> > > return -EAGAIN;
> > >
> > > SET_IEEE80211_PERM_ADDR(priv->hw,
> > > priv->permanent_net_addr);[cleardot.gif]
> > >
> > > --
> > > 2.7.4
> > >
> > > --
> > > You received this message because you are subscribed to the Google
> Groups
> > > "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send
> an
> > > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com
> .
> > > To view this discussion on the web visithttps://groups.google.
> com/d/msgid/outreachy-kernel/CAFrQyDHKq8Ktv05E5zpQfiD
> > > fQGgceZu5B19WXF1bdhJT%3Dw6tYg%40mail.gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> > >
>
>
[-- Attachment #2: Type: text/html, Size: 5755 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines
2016-09-15 18:00 ` Namrata A Shettar
@ 2016-09-15 19:25 ` Julia Lawall
[not found] ` <20160915193352.GA7939@namrata-HP-Pavilion-g6-Notebook-PC>
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2016-09-15 19:25 UTC (permalink / raw)
To: Namrata A Shettar; +Cc: outreachy-kernel, Julia Lawall
[-- Attachment #1: Type: TEXT/PLAIN, Size: 4664 bytes --]
On Thu, 15 Sep 2016, Namrata A Shettar wrote:
>
> On Thu, Sep 15, 2016 at 07:17:53AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> >
> > > This patch resolves checkpatch issue of unnecessary blank lines.
> > >
> > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > ---
> > > int vnt_init(struct vnt_private *priv)
> > > {
> > > -
> > > - if (!(vnt_init_registers(priv)))
> > > + if (!(vnt_init_registers(priv)))
> > >
> >
> > Here you seem to have added an extra space. Actually all the spaces
> > should be removed, and there should be a tab. But in any case it is not a
> > blank line change.
> >
> > julia
> >
>
> There is actually a blank line change but I added a space by mistake
> while deleting the blank line.So will I have to abandon this patch.If
> yes,then in the new version of the patchset I make ,do I have to change
> the numbering? Will be more careful the next time!
I'm not sure what you mean by abandon. Just send the whole series again,
with any needed corrections, and indicate what has changed.
julia
>
> Thanks,
> Namrata
>
>
> On Thu, Sep 15, 2016 at 11:16 PM, Namrata A Shettar
> <namrataashettar@gmail.com> wrote:
> There is actually a blank line change but I added a space by
> mistake
> while deleting the blank line.So will I have to abandon this
> patch.If
> yes,then in the new version of the patchset I make do I have to
> change
> the numbering.Once again thanks for your inputs!
>
> -Namrata
>
> On Thu, Sep 15, 2016 at 07:17:53AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> >
> > > This patch resolves checkpatch issue of unnecessary blank
> lines.
> > >
> > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > ---
> > > drivers/staging/vt6656/main_usb.c | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6656/main_usb.c
> > > b/drivers/staging/vt6656/main_usb.c
> > > index 0594828..d79f07f 100644
> > > --- a/drivers/staging/vt6656/main_usb.c
> > > +++ b/drivers/staging/vt6656/main_usb.c
> > > @@ -692,7 +692,6 @@ static void vnt_bss_info_changed(struct
> ieee80211_hw
> > > *hw,
> > > if (changed & BSS_CHANGED_BSSID && conf->bssid)
> > > vnt_mac_set_bssid_addr(priv, (u8
> *)conf->bssid);
> > >
> > > -
> > > if (changed & BSS_CHANGED_BASIC_RATES) {
> > > priv->basic_rates = conf->basic_rates;
> > >
> > > @@ -814,7 +813,6 @@ static void vnt_configure(struct
> ieee80211_hw *hw,
> > > } else {
> > > rx_mode &= ~(RCR_MULTICAST |
> RCR_BROADCAST);
> > > }
> > > -
> > > }
> > >
> > > if (changed_flags & (FIF_OTHER_BSS |
> FIF_BCN_PRBRESP_PROMISC)) {
> > > @@ -925,8 +923,7 @@ static const struct ieee80211_ops
> vnt_mac_ops = {
> > >
> > > int vnt_init(struct vnt_private *priv)
> > > {
> > > -
> > > - if (!(vnt_init_registers(priv)))
> > > + if (!(vnt_init_registers(priv)))
> >
> > Here you seem to have added an extra space. Actually all the
> spaces
> > should be removed, and there should be a tab. But in any case
> it is not a
> > blank line change.
> >
> > julia
> >
> > > return -EAGAIN;
> > >
> > > SET_IEEE80211_PERM_ADDR(priv->hw,
> > > priv->permanent_net_addr);[cleardot.gif]
> > >
> > > --
> > > 2.7.4
> > >
> > > --
> > > You received this message because you are subscribed to the
> Google Groups
> > > "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails
> from it, send an
> > > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDHKq8Ktv05E5z
> pQfiD
> > > fQGgceZu5B19WXF1bdhJT%3Dw6tYg%40mail.gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> > >
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines
[not found] ` <20160915193352.GA7939@namrata-HP-Pavilion-g6-Notebook-PC>
@ 2016-09-15 19:38 ` Namrata A Shettar
0 siblings, 0 replies; 5+ messages in thread
From: Namrata A Shettar @ 2016-09-15 19:38 UTC (permalink / raw)
To: outreachy-kernel, Julia Lawall
[-- Attachment #1: Type: text/plain, Size: 2949 bytes --]
On Thu, Sep 15, 2016 at 09:25:13PM +0200, Julia Lawall wrote:
>
>
>
> I'm not sure what you mean by abandon. Just send the whole series again,
> with any needed corrections, and indicate what has changed.
>
> julia
Will do the same.Thank you.
-Namrata
> >
> > Thanks,
> > Namrata
> >
> >
> > On Thu, Sep 15, 2016 at 11:16 PM, Namrata A Shettar
> > <namrataashettar@gmail.com> wrote:
> > There is actually a blank line change but I added a space by
> > mistake
> > while deleting the blank line.So will I have to abandon this
> > patch.If
> > yes,then in the new version of the patchset I make do I have to
> > change
> > the numbering.Once again thanks for your inputs!
> >
> > -Namrata
> >
> > On Thu, Sep 15, 2016 at 07:17:53AM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> > >
> > > > This patch resolves checkpatch issue of unnecessary blank
> > lines.
> > > >
> > > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > > ---
> > > > drivers/staging/vt6656/main_usb.c | 5 +----
> > > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/vt6656/main_usb.c
> > > > b/drivers/staging/vt6656/main_usb.c
> > > > index 0594828..d79f07f 100644
> > > > --- a/drivers/staging/vt6656/main_usb.c
> > > > +++ b/drivers/staging/vt6656/main_usb.c
> > > > @@ -692,7 +692,6 @@ static void vnt_bss_info_changed(struct
> > ieee80211_hw
> > > > *hw,
> > > > if (changed & BSS_CHANGED_BSSID && conf->bssid)
> > > > vnt_mac_set_bssid_addr(priv, (u8
> > *)conf->bssid);
> > > >
> > > > -
> > > > if (changed & BSS_CHANGED_BASIC_RATES) {
> > > > priv->basic_rates = conf->basic_rates;
> > > >
> > > > @@ -814,7 +813,6 @@ static void vnt_configure(struct
> > ieee80211_hw *hw,
> > > > } else {
> > > > rx_mode &= ~(RCR_MULTICAST |
> > RCR_BROADCAST);
> > > > }
> > > > -
> > > > }
> > > >
> > > > if (changed_flags & (FIF_OTHER_BSS |
> > FIF_BCN_PRBRESP_PROMISC)) {
> > > > @@ -925,8 +923,7 @@ static const struct ieee80211_ops
> > vnt_mac_ops = {
> > > >
> > > > int vnt_init(struct vnt_private *priv)
> > > > {
> > > > -
> > > > - if (!(vnt_init_registers(priv)))
> > > > + if (!(vnt_init_registers(priv)))
> > >
> > > Here you seem to have added an extra space. Actually all the
> > spaces
> > > should be removed, and there should be a tab. But in any case
> > it is not a
> > > blank line change.
> > >
> > > julia
> > >
>
[-- Attachment #2: Type: text/html, Size: 5180 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-15 19:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 22:16 [PATCH 2/6] staging: vt6656: main_usb: Remove unnecessary blank lines Namrata A Shettar
2016-09-15 5:17 ` [Outreachy kernel] " Julia Lawall
[not found] ` <20160915174614.GA6219@namrata-HP-Pavilion-g6-Notebook-PC>
2016-09-15 18:00 ` Namrata A Shettar
2016-09-15 19:25 ` Julia Lawall
[not found] ` <20160915193352.GA7939@namrata-HP-Pavilion-g6-Notebook-PC>
2016-09-15 19:38 ` Namrata A Shettar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.