[Buildroot] [Bug 12301] New: systemd-journal-gatewayd: config options broken

[Buildroot] [Bug 12301] New: systemd-journal-gatewayd: config options broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12301

            Bug ID: 12301
           Summary: systemd-journal-gatewayd: config options broken
           Product: buildroot
           Version: 2019.08
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: posted at heine.so
                CC: buildroot at uclibc.org
  Target Milestone: ---

Hi,

I updated my systemd system build to BR 2019.08 and noticed that
systemd-journal-gatewayd was missing in the resulting image.


Commit 2dbce34b3a2c8fc1a854395f6c33df658371eae4 added a config option
BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE to enable the systemd-journal-remote
service.

If it is selected the -Dremote=true flag gets explicitly set. If not it is
explicitly set to false.

But as defined in the systemd config (see [0]) -Dremote=true is used to enable
systemd-journal-remote as well as systemd-journal-gatewayd. There is no switch
to only build one of them.

Further the default value of the -Dremote flag is true (see [1]).

So previous to this commit both binaries are already built and installed when
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY is set. I verfied this in my built
2019.05.1 image. Both binaries are there.


As with this commit, when BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=Y and
BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE=N is set -Dremote=false is explicitly set
and systemd builds neither of the binaries.



So I would suggest to revert this commit as it breaks configs and adds no
functionality. 
Also I would suggest to extend the description of
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY to include a mention of
"systemd-journal-remote".


Regards,
Michael

[0] https://github.com/systemd/systemd/blob/master/meson.build#L2207
[1] https://github.com/systemd/systemd/blob/master/meson.build#L1253

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12301] New: systemd-journal-gatewayd: config options broken

[Arnout Vandecappelle]

On 30/10/2019 14:02, bugzilla at busybox.net wrote:
> https://bugs.busybox.net/show_bug.cgi?id=12301
[snip]
> Commit 2dbce34b3a2c8fc1a854395f6c33df658371eae4 added a config option
> BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE to enable the systemd-journal-remote
> service.
> 
> If it is selected the -Dremote=true flag gets explicitly set. If not it is
> explicitly set to false.
> 
> But as defined in the systemd config (see [0]) -Dremote=true is used to enable
> systemd-journal-remote as well as systemd-journal-gatewayd. There is no switch
> to only build one of them.

 This is probably fallout from the bump to 243. James, could you have a look?

 Regards,
 Arnout

> 
> Further the default value of the -Dremote flag is true (see [1]).
> 
> So previous to this commit both binaries are already built and installed when
> BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY is set. I verfied this in my built
> 2019.05.1 image. Both binaries are there.
> 
> 
> As with this commit, when BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=Y and
> BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE=N is set -Dremote=false is explicitly set
> and systemd builds neither of the binaries.
> 
> 
> 
> So I would suggest to revert this commit as it breaks configs and adds no
> functionality. 
> Also I would suggest to extend the description of
> BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY to include a mention of
> "systemd-journal-remote".
> 
> 
> Regards,
> Michael
> 
> [0] https://github.com/systemd/systemd/blob/master/meson.build#L2207
> [1] https://github.com/systemd/systemd/blob/master/meson.build#L1253
> 

[Buildroot] [Bug 12301] New: systemd-journal-gatewayd: config options broken

[Jérémy ROSEN]

I don't think it's a fallout of v243, i think it's a bug when adding that
option.

the -Dremote option enables all three binaries (-upload, -gatwayd, -remote)
and I don't see any way to enable them separately.
* -upload allows the target to push log files to an http server
* -gatewayd provides an http server on the target to provide the logs
* -remote is used on the host to pull logs from the target or accept pushes
from the target

the description of the option is pretty clear : 'support for "journal over
the network"'

It does make sense to enable those three separately, but upstream does not
support this. So we can
1) drop the commit and stay with upstream granularity
2) add our own patch to separate the three options

I would recommend 1) for the next stable release, but i'm not sure how to
deal with the long term

The best approach is probably to push upstream to provide more granularity
for the build system, but that is going to be quite a bit of work...


Le mer. 30 oct. 2019 ? 22:07, Arnout Vandecappelle <arnout@mind.be> a
?crit :

>
>
> On 30/10/2019 14:02, bugzilla at busybox.net wrote:
> > https://bugs.busybox.net/show_bug.cgi?id=12301
> [snip]
> > Commit 2dbce34b3a2c8fc1a854395f6c33df658371eae4 added a config option
> > BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE to enable the systemd-journal-remote
> > service.
> >
> > If it is selected the -Dremote=true flag gets explicitly set. If not it
> is
> > explicitly set to false.
> >
> > But as defined in the systemd config (see [0]) -Dremote=true is used to
> enable
> > systemd-journal-remote as well as systemd-journal-gatewayd. There is no
> switch
> > to only build one of them.
>
>  This is probably fallout from the bump to 243. James, could you have a
> look?
>
>  Regards,
>  Arnout
>
> >
> > Further the default value of the -Dremote flag is true (see [1]).
> >
> > So previous to this commit both binaries are already built and installed
> when
> > BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY is set. I verfied this in my built
> > 2019.05.1 image. Both binaries are there.
> >
> >
> > As with this commit, when BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=Y and
> > BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE=N is set -Dremote=false is explicitly
> set
> > and systemd builds neither of the binaries.
> >
> >
> >
> > So I would suggest to revert this commit as it breaks configs and adds no
> > functionality.
> > Also I would suggest to extend the description of
> > BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY to include a mention of
> > "systemd-journal-remote".
> >
> >
> > Regards,
> > Michael
> >
> > [0] https://github.com/systemd/systemd/blob/master/meson.build#L2207
> > [1] https://github.com/systemd/systemd/blob/master/meson.build#L1253
> >
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
[image: SMILE]  <http://www.smile.eu/>

20 rue des Jardins
92600 Asni?res-sur-Seine
*J?r?my ROSEN*
Architecte technique

[image: email] jeremy.rosen at smile.fr
[image: phone]  +33 6 88 25 87 42
[image: url] http://www.smile.eu

[image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
<https://www.facebook.com/smileopensource> [image: LinkedIn]
<https://www.linkedin.com/company/smile> [image: Github]
<https://github.com/Smile-SA>

[image: D?couvrez l?univers Smile, rendez-vous sur smile.eu]
<https://www.smile.eu/fr/publications/livres-blancs/yocto?utm_source=signature&utm_medium=email&utm_campaign=signature>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191118/367feb80/attachment.html>

[Buildroot] [Bug 12301] systemd-journal-gatewayd: config options broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12301

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Thanks for your bug report, I replied to the original author of the problematic
patch, and also added one of our systemd experts in the loop:
http://lists.busybox.net/pipermail/buildroot/2019-November/267243.html.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12301] systemd-journal-gatewayd: config options broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12301

Michael Nosthoff <buildroot@heine.tech> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2020.11
             Status|NEW                         |RESOLVED

--- Comment #2 from Michael Nosthoff <buildroot@heine.tech> ---
fixed by
https://git.busybox.net/buildroot/commit/?id=e46fe9a6f2b7cef9789f5172332067cac5ff03bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.