* linux-3.16.2 queue (3.16.1+)
@ 2014-08-28 15:16 Matt
2014-08-28 15:22 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Matt @ 2014-08-28 15:16 UTC (permalink / raw)
To: gregkh; +Cc: Linux Kernel, ReiserFS Mailing List
Hi Greg,
please consider adding the following 2 patches to 3.16.2:
Jan Kara (1):
reiserfs: Fix use after free in journal teardown
Jeff Mahoney (1):
reiserfs: fix corruption introduced by balance_leaf refactor
Reason/Related:
https://bugzilla.kernel.org/show_bug.cgi?id=83121
https://bugzilla.kernel.org/show_bug.cgi?id=83321
http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html
Many thanks in advance
Kind Regards
Matt
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: linux-3.16.2 queue (3.16.1+) 2014-08-28 15:16 linux-3.16.2 queue (3.16.1+) Matt @ 2014-08-28 15:22 ` Greg KH 2014-08-28 15:27 ` Matt 0 siblings, 1 reply; 9+ messages in thread From: Greg KH @ 2014-08-28 15:22 UTC (permalink / raw) To: Matt; +Cc: Linux Kernel, ReiserFS Mailing List On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: > Hi Greg, > > > please consider adding the following 2 patches to 3.16.2: > > Jan Kara (1): > reiserfs: Fix use after free in journal teardown > > Jeff Mahoney (1): > reiserfs: fix corruption introduced by balance_leaf refactor > > > > Reason/Related: > > https://bugzilla.kernel.org/show_bug.cgi?id=83121 > > https://bugzilla.kernel.org/show_bug.cgi?id=83321 > > http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html > > > Many thanks in advance I need git commit ids of these patches in Linus's tree, can you provide those please? thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-08-28 15:22 ` Greg KH @ 2014-08-28 15:27 ` Matt 2014-08-28 15:32 ` Greg KH 0 siblings, 1 reply; 9+ messages in thread From: Matt @ 2014-08-28 15:27 UTC (permalink / raw) To: Greg KH; +Cc: ReiserFS Mailing List, Linux Kernel On Thu, Aug 28, 2014 at 5:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: >> Hi Greg, >> >> >> please consider adding the following 2 patches to 3.16.2: >> >> Jan Kara (1): >> reiserfs: Fix use after free in journal teardown >> >> Jeff Mahoney (1): >> reiserfs: fix corruption introduced by balance_leaf refactor >> >> >> >> Reason/Related: >> >> https://bugzilla.kernel.org/show_bug.cgi?id=83121 >> >> https://bugzilla.kernel.org/show_bug.cgi?id=83321 >> >> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html >> >> >> Many thanks in advance > > I need git commit ids of these patches in Linus's tree, can you provide > those please? > > thanks, > > greg k-h Sure: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d reiserfs: fix corruption introduced by balance_leaf refactor https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e reiserfs: Fix use after free in journal teardown are checkpatch warnings usually also fixed within stable releases ? if yes: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f3fb9e27325c4e1730440820ea8a1e9d9a5af709 fs/reiserfs/xattr.c: fix blank line missing after declarations https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=17093991af4995c4b93f6d8ac63aab68fcd9e1be fs/reiserfs: use linux/uaccess.h https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=53872ed07786714bff3642ee9ee61afd3f4eb749 fs/reiserfs: replace not-standard %Lu/%Ld Greetings Matt ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-08-28 15:27 ` Matt @ 2014-08-28 15:32 ` Greg KH 2014-08-28 19:18 ` Matt 0 siblings, 1 reply; 9+ messages in thread From: Greg KH @ 2014-08-28 15:32 UTC (permalink / raw) To: Matt; +Cc: ReiserFS Mailing List, Linux Kernel On Thu, Aug 28, 2014 at 05:27:27PM +0200, Matt wrote: > On Thu, Aug 28, 2014 at 5:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: > >> Hi Greg, > >> > >> > >> please consider adding the following 2 patches to 3.16.2: > >> > >> Jan Kara (1): > >> reiserfs: Fix use after free in journal teardown > >> > >> Jeff Mahoney (1): > >> reiserfs: fix corruption introduced by balance_leaf refactor > >> > >> > >> > >> Reason/Related: > >> > >> https://bugzilla.kernel.org/show_bug.cgi?id=83121 > >> > >> https://bugzilla.kernel.org/show_bug.cgi?id=83321 > >> > >> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html > >> > >> > >> Many thanks in advance > > > > I need git commit ids of these patches in Linus's tree, can you provide > > those please? > > > > thanks, > > > > greg k-h > > > Sure: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d > reiserfs: fix corruption introduced by balance_leaf refactor > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e > reiserfs: Fix use after free in journal teardown > > > > are checkpatch warnings usually also fixed within stable releases ? No, not at all, please read Documentation/stable_kernel_patches.txt for what is acceptable for stable kernel patches. thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-08-28 15:32 ` Greg KH @ 2014-08-28 19:18 ` Matt 2014-09-07 0:47 ` Matt 0 siblings, 1 reply; 9+ messages in thread From: Matt @ 2014-08-28 19:18 UTC (permalink / raw) To: Greg KH; +Cc: ReiserFS Mailing List, Linux Kernel On Thu, Aug 28, 2014 at 5:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, Aug 28, 2014 at 05:27:27PM +0200, Matt wrote: >> On Thu, Aug 28, 2014 at 5:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> > On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: >> >> Hi Greg, >> >> >> >> >> >> please consider adding the following 2 patches to 3.16.2: >> >> >> >> Jan Kara (1): >> >> reiserfs: Fix use after free in journal teardown >> >> >> >> Jeff Mahoney (1): >> >> reiserfs: fix corruption introduced by balance_leaf refactor >> >> >> >> >> >> >> >> Reason/Related: >> >> >> >> https://bugzilla.kernel.org/show_bug.cgi?id=83121 >> >> >> >> https://bugzilla.kernel.org/show_bug.cgi?id=83321 >> >> >> >> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html >> >> >> >> >> >> Many thanks in advance >> > >> > I need git commit ids of these patches in Linus's tree, can you provide >> > those please? >> > >> > thanks, >> > >> > greg k-h >> >> >> Sure: >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d >> reiserfs: fix corruption introduced by balance_leaf refactor >> >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e >> reiserfs: Fix use after free in journal teardown >> >> >> >> are checkpatch warnings usually also fixed within stable releases ? > > No, not at all, please read Documentation/stable_kernel_patches.txt for > what is acceptable for stable kernel patches. > > thanks, > > greg k-h okay, will do thanks for pointing that out Regards Matt ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-08-28 19:18 ` Matt @ 2014-09-07 0:47 ` Matt 2014-09-07 3:18 ` Greg KH 0 siblings, 1 reply; 9+ messages in thread From: Matt @ 2014-09-07 0:47 UTC (permalink / raw) To: Greg KH; +Cc: Linux Kernel, ReiserFS Mailing List On Thu, Aug 28, 2014 at 9:18 PM, Matt <jackdachef@gmail.com> wrote: > On Thu, Aug 28, 2014 at 5:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> On Thu, Aug 28, 2014 at 05:27:27PM +0200, Matt wrote: >>> On Thu, Aug 28, 2014 at 5:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >>> > On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: >>> >> Hi Greg, >>> >> >>> >> >>> >> please consider adding the following 2 patches to 3.16.2: >>> >> >>> >> Jan Kara (1): >>> >> reiserfs: Fix use after free in journal teardown >>> >> >>> >> Jeff Mahoney (1): >>> >> reiserfs: fix corruption introduced by balance_leaf refactor >>> >> >>> >> >>> >> >>> >> Reason/Related: >>> >> >>> >> https://bugzilla.kernel.org/show_bug.cgi?id=83121 >>> >> >>> >> https://bugzilla.kernel.org/show_bug.cgi?id=83321 >>> >> >>> >> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html >>> >> >>> >> >>> >> Many thanks in advance >>> > >>> > I need git commit ids of these patches in Linus's tree, can you provide >>> > those please? >>> > >>> > thanks, >>> > >>> > greg k-h >>> >>> >>> Sure: >>> >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d >>> reiserfs: fix corruption introduced by balance_leaf refactor >>> >>> >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e >>> reiserfs: Fix use after free in journal teardown >>> >>> >>> >>> are checkpatch warnings usually also fixed within stable releases ? >> >> No, not at all, please read Documentation/stable_kernel_patches.txt for >> what is acceptable for stable kernel patches. >> >> thanks, >> >> greg k-h > > > okay, will do > > thanks for pointing that out > > > Regards > > Matt Hi Greg, could you please add the above mentioned two patches https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d reiserfs: fix corruption introduced by balance_leaf refactor https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e reiserfs: Fix use after free in journal teardown in next stable (3.16.3) kernel ? more and more people seem to be affected by the data corruption introduced by the recent changes. Reading through Documentation/stable_kernel_rules.txt, http://cwe.mitre.org/data/definitions/416.html and http://www.hpenterprisesecurity.com/vulncat/en/vulncat/cpp/use_after_free.html both patches seem relevant enough (concerning data integrity filesystem-wise and security) to be included for the stable branch Thanks & Regards Matt ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-09-07 0:47 ` Matt @ 2014-09-07 3:18 ` Greg KH 2014-09-11 4:29 ` Jeff Mahoney 0 siblings, 1 reply; 9+ messages in thread From: Greg KH @ 2014-09-07 3:18 UTC (permalink / raw) To: Matt; +Cc: Linux Kernel, ReiserFS Mailing List On Sun, Sep 07, 2014 at 02:47:55AM +0200, Matt wrote: > On Thu, Aug 28, 2014 at 9:18 PM, Matt <jackdachef@gmail.com> wrote: > > On Thu, Aug 28, 2014 at 5:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > >> On Thu, Aug 28, 2014 at 05:27:27PM +0200, Matt wrote: > >>> On Thu, Aug 28, 2014 at 5:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > >>> > On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: > >>> >> Hi Greg, > >>> >> > >>> >> > >>> >> please consider adding the following 2 patches to 3.16.2: > >>> >> > >>> >> Jan Kara (1): > >>> >> reiserfs: Fix use after free in journal teardown > >>> >> > >>> >> Jeff Mahoney (1): > >>> >> reiserfs: fix corruption introduced by balance_leaf refactor > >>> >> > >>> >> > >>> >> > >>> >> Reason/Related: > >>> >> > >>> >> https://bugzilla.kernel.org/show_bug.cgi?id=83121 > >>> >> > >>> >> https://bugzilla.kernel.org/show_bug.cgi?id=83321 > >>> >> > >>> >> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html > >>> >> > >>> >> > >>> >> Many thanks in advance > >>> > > >>> > I need git commit ids of these patches in Linus's tree, can you provide > >>> > those please? > >>> > > >>> > thanks, > >>> > > >>> > greg k-h > >>> > >>> > >>> Sure: > >>> > >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d > >>> reiserfs: fix corruption introduced by balance_leaf refactor > >>> > >>> > >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e > >>> reiserfs: Fix use after free in journal teardown > >>> > >>> > >>> > >>> are checkpatch warnings usually also fixed within stable releases ? > >> > >> No, not at all, please read Documentation/stable_kernel_patches.txt for > >> what is acceptable for stable kernel patches. > >> > >> thanks, > >> > >> greg k-h > > > > > > okay, will do > > > > thanks for pointing that out > > > > > > Regards > > > > Matt > > Hi Greg, > > could you please add the above mentioned two patches > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d > reiserfs: fix corruption introduced by balance_leaf refactor > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e > reiserfs: Fix use after free in journal teardown > > in next stable (3.16.3) kernel ? > > more and more people seem to be affected by the data corruption > introduced by the recent changes. > > > Reading through Documentation/stable_kernel_rules.txt, > http://cwe.mitre.org/data/definitions/416.html and > http://www.hpenterprisesecurity.com/vulncat/en/vulncat/cpp/use_after_free.html > > both patches seem relevant enough (concerning data integrity > filesystem-wise and security) to be included for the stable branch I'll queue this up when I get a chance, there are over 300 patches pending for the stable kernels right now :( Also, in the future, always cc stable@vger.kernel.org for any stable requests so that they don't get lost. thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-09-07 3:18 ` Greg KH @ 2014-09-11 4:29 ` Jeff Mahoney 2014-09-12 21:29 ` Greg KH 0 siblings, 1 reply; 9+ messages in thread From: Jeff Mahoney @ 2014-09-11 4:29 UTC (permalink / raw) To: Greg KH, Matt; +Cc: Linux Kernel, ReiserFS Mailing List -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 9/6/14, 11:18 PM, Greg KH wrote: > On Sun, Sep 07, 2014 at 02:47:55AM +0200, Matt wrote: >> On Thu, Aug 28, 2014 at 9:18 PM, Matt <jackdachef@gmail.com> >> wrote: >>> On Thu, Aug 28, 2014 at 5:32 PM, Greg KH >>> <gregkh@linuxfoundation.org> wrote: >>>> On Thu, Aug 28, 2014 at 05:27:27PM +0200, Matt wrote: >>>>> On Thu, Aug 28, 2014 at 5:22 PM, Greg KH >>>>> <gregkh@linuxfoundation.org> wrote: >>>>>> On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: >>>>>>> Hi Greg, >>>>>>> >>>>>>> >>>>>>> please consider adding the following 2 patches to >>>>>>> 3.16.2: >>>>>>> >>>>>>> Jan Kara (1): reiserfs: Fix use after free in journal >>>>>>> teardown >>>>>>> >>>>>>> Jeff Mahoney (1): reiserfs: fix corruption introduced >>>>>>> by balance_leaf refactor >>>>>>> >>>>>>> >>>>>>> >>>>>>> Reason/Related: >>>>>>> >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=83121 >>>>>>> >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=83321 >>>>>>> >>>>>>> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html >>>>>>> >>>>>>> >>>>>>> >>>>>>> Many thanks in advance >>>>>> >>>>>> I need git commit ids of these patches in Linus's tree, >>>>>> can you provide those please? >>>>>> >>>>>> thanks, >>>>>> >>>>>> greg k-h >>>>> >>>>> >>>>> Sure: >>>>> >>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d >>>>> >>>>> reiserfs: fix corruption introduced by balance_leaf refactor >>>>> >>>>> >>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e >>>>> >>>>> reiserfs: Fix use after free in journal teardown >>>>> >>>>> >>>>> >>>>> are checkpatch warnings usually also fixed within stable >>>>> releases ? >>>> >>>> No, not at all, please read >>>> Documentation/stable_kernel_patches.txt for what is >>>> acceptable for stable kernel patches. >>>> >>>> thanks, >>>> >>>> greg k-h >>> >>> >>> okay, will do >>> >>> thanks for pointing that out >>> >>> >>> Regards >>> >>> Matt >> >> Hi Greg, >> >> could you please add the above mentioned two patches >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d >> >> reiserfs: fix corruption introduced by balance_leaf refactor >> >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e >> >> reiserfs: Fix use after free in journal teardown >> >> in next stable (3.16.3) kernel ? >> >> more and more people seem to be affected by the data corruption >> introduced by the recent changes. >> >> >> Reading through Documentation/stable_kernel_rules.txt, >> http://cwe.mitre.org/data/definitions/416.html and >> http://www.hpenterprisesecurity.com/vulncat/en/vulncat/cpp/use_after_free.html >> >> >> both patches seem relevant enough (concerning data integrity >> filesystem-wise and security) to be included for the stable >> branch > > I'll queue this up when I get a chance, there are over 300 patches > pending for the stable kernels right now :( > > Also, in the future, always cc stable@vger.kernel.org for any > stable requests so that they don't get lost. Hi Greg - 27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d Author: Jeff Mahoney <jeffm@suse.com> Date: Mon Aug 4 19:51:47 2014 -0400 reiserfs: fix corruption introduced by balance_leaf refactor Commits f1f007c308e (reiserfs: balance_leaf refactor, pull out balance_leaf_insert_left) and cf22df182bf (reiserfs: balance_leaf refactor, pull out balance_leaf_paste_left) missed that the `body' pointer was getting repositioned. Subsequent users of the pointer would expect it to be repositioned, and as a result, parts of the tree would get overwritten. The most common observed corruption is indirect block pointers being overwritten. Since the body value isn't actually used anymore in the called routines, we can pass back the offset it should be shifted. We constify the body and ih pointers in the balance_leaf as a mostly-free preventative measure. Cc: <stable@vger.kernel.org> # 3.16 Reported-and-tested-by: Jeff Chua <jeff.chua.linux@gmail.com> Signed-off-by: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Jan Kara <jack@suse.cz> Should there have been more? I thought it was enough to add the Cc tag. This one has been in the tree, with the tags and with "corruption" in the Subject since 13 Aug. I know you're busy but this seems like a pretty obvious candidate for stable inclusion. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJUESUpAAoJEB57S2MheeWyt9oQAIEnvZPojErvzzv4IcvVheSI Ju1XChkU4YDRW3W2e8PEjAhiPd1dMP7aEJvfq6AxlKYAYENaS/S2LdSbBbeVctFa 1VwBVakDkmHduVcb2hl3ldIQlHRW0w/q/fSk+NKZavANS/maIK/mj2HE8S3Op17C iGsGZiluqaYp56yPHJK7XDorpWFoCVXIPlHUbec8lIxnyPqeytHo2W5UtfZZVeN3 BfGICzR57i7YjOtQ/lsmusiUjp7Ym4REKX1GGnIcZ1Po5F8oX4phMVaUR0gR1NSA eYBcTyH245iWTQBFqE9D5AR0pHLnmi6EySEbNIWU3w0OYffDCBpqU7A7Dm5O2kng caIlNuf4TMEp7QzVC8hxCL61nxBWJ6L2RQ9NkOg9zLHXdaWhJSjHl7TdRUPV/C3V RzNCZEWvqEpMoju145Wez7JlcE/GlsBclNFGBqypEWN364B/MprKe5vhpeXJ+1H2 yUq/qKlgQLZe5uPCwMdcyAB3xTX8mIzG4nz8RWez6WPjhAlb82xtBSl0btWjSnVM 4YlWy/5jCWgyjXzrM3hd8P3SJi+l69rVUE+UcMvOqHq3oCFBddhlUh9tHM7pn9tH sXTo8f8s9Pe7+HvbA0bwtwbwTQ8tNxn87ovuVnAO86RLmeeM7HCfqBU/4lKEZ0WE TG7eSSLjQVBxo+kQCZOo =OOOa -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-3.16.2 queue (3.16.1+) 2014-09-11 4:29 ` Jeff Mahoney @ 2014-09-12 21:29 ` Greg KH 0 siblings, 0 replies; 9+ messages in thread From: Greg KH @ 2014-09-12 21:29 UTC (permalink / raw) To: Jeff Mahoney; +Cc: Matt, Linux Kernel, ReiserFS Mailing List On Thu, Sep 11, 2014 at 12:29:30AM -0400, Jeff Mahoney wrote: > On 9/6/14, 11:18 PM, Greg KH wrote: > > On Sun, Sep 07, 2014 at 02:47:55AM +0200, Matt wrote: > >> On Thu, Aug 28, 2014 at 9:18 PM, Matt <jackdachef@gmail.com> > >> wrote: > >>> On Thu, Aug 28, 2014 at 5:32 PM, Greg KH > >>> <gregkh@linuxfoundation.org> wrote: > >>>> On Thu, Aug 28, 2014 at 05:27:27PM +0200, Matt wrote: > >>>>> On Thu, Aug 28, 2014 at 5:22 PM, Greg KH > >>>>> <gregkh@linuxfoundation.org> wrote: > >>>>>> On Thu, Aug 28, 2014 at 05:16:58PM +0200, Matt wrote: > >>>>>>> Hi Greg, > >>>>>>> > >>>>>>> > >>>>>>> please consider adding the following 2 patches to > >>>>>>> 3.16.2: > >>>>>>> > >>>>>>> Jan Kara (1): reiserfs: Fix use after free in journal > >>>>>>> teardown > >>>>>>> > >>>>>>> Jeff Mahoney (1): reiserfs: fix corruption introduced > >>>>>>> by balance_leaf refactor > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Reason/Related: > >>>>>>> > >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=83121 > >>>>>>> > >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=83321 > >>>>>>> > >>>>>>> http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc-start-0.html > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > Many thanks in advance > >>>>>> > >>>>>> I need git commit ids of these patches in Linus's tree, > >>>>>> can you provide those please? > >>>>>> > >>>>>> thanks, > >>>>>> > >>>>>> greg k-h > >>>>> > >>>>> > >>>>> Sure: > >>>>> > >>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d > >>>>> > >>>>> > reiserfs: fix corruption introduced by balance_leaf refactor > >>>>> > >>>>> > >>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e > >>>>> > >>>>> > reiserfs: Fix use after free in journal teardown > >>>>> > >>>>> > >>>>> > >>>>> are checkpatch warnings usually also fixed within stable > >>>>> releases ? > >>>> > >>>> No, not at all, please read > >>>> Documentation/stable_kernel_patches.txt for what is > >>>> acceptable for stable kernel patches. > >>>> > >>>> thanks, > >>>> > >>>> greg k-h > >>> > >>> > >>> okay, will do > >>> > >>> thanks for pointing that out > >>> > >>> > >>> Regards > >>> > >>> Matt > >> > >> Hi Greg, > >> > >> could you please add the above mentioned two patches > >> > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d > >> > >> > reiserfs: fix corruption introduced by balance_leaf refactor > >> > >> > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=01777836c87081e4f68c4a43c9abe6114805f91e > >> > >> > reiserfs: Fix use after free in journal teardown > >> > >> in next stable (3.16.3) kernel ? > >> > >> more and more people seem to be affected by the data corruption > >> introduced by the recent changes. > >> > >> > >> Reading through Documentation/stable_kernel_rules.txt, > >> http://cwe.mitre.org/data/definitions/416.html and > >> http://www.hpenterprisesecurity.com/vulncat/en/vulncat/cpp/use_after_free.html > >> > >> > >> > both patches seem relevant enough (concerning data integrity > >> filesystem-wise and security) to be included for the stable > >> branch > > > > I'll queue this up when I get a chance, there are over 300 patches > > pending for the stable kernels right now :( > > > > Also, in the future, always cc stable@vger.kernel.org for any > > stable requests so that they don't get lost. > > Hi Greg - > > 27d0e5bc85f3341b9ba66f0c23627cf9d7538c9d > Author: Jeff Mahoney <jeffm@suse.com> > Date: Mon Aug 4 19:51:47 2014 -0400 > > reiserfs: fix corruption introduced by balance_leaf refactor > > Commits f1f007c308e (reiserfs: balance_leaf refactor, pull out > balance_leaf_insert_left) and cf22df182bf (reiserfs: balance_leaf > refactor, pull out balance_leaf_paste_left) missed that the `body' > pointer was getting repositioned. Subsequent users of the pointer > would expect it to be repositioned, and as a result, parts of the > tree would get overwritten. The most common observed corruption > is indirect block pointers being overwritten. > > Since the body value isn't actually used anymore in the called > routines, > we can pass back the offset it should be shifted. We constify the body > and ih pointers in the balance_leaf as a mostly-free preventative > measure. > > Cc: <stable@vger.kernel.org> # 3.16 > Reported-and-tested-by: Jeff Chua <jeff.chua.linux@gmail.com> > Signed-off-by: Jeff Mahoney <jeffm@suse.com> > Signed-off-by: Jan Kara <jack@suse.cz> > > Should there have been more? I thought it was enough to add the Cc > tag. This one has been in the tree, with the tags and with > "corruption" in the Subject since 13 Aug. I know you're busy but this > seems like a pretty obvious candidate for stable inclusion. You marked this one just fine, it's just that, again, I have over 300+ patches in the "marked for stable" queue right now, this patch is in good company... greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-12 21:29 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-08-28 15:16 linux-3.16.2 queue (3.16.1+) Matt 2014-08-28 15:22 ` Greg KH 2014-08-28 15:27 ` Matt 2014-08-28 15:32 ` Greg KH 2014-08-28 19:18 ` Matt 2014-09-07 0:47 ` Matt 2014-09-07 3:18 ` Greg KH 2014-09-11 4:29 ` Jeff Mahoney 2014-09-12 21:29 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.