* [PATCH 1/2] clk: qcom: camcc-sdm845: Fix topology around titan_top power domain
2022-05-19 21:41 [PATCH 0/2] clk: qcom: Fix topology around titan_top power domain Vladimir Zapolskiy
@ 2022-05-19 21:41 ` Vladimir Zapolskiy
2022-05-23 8:57 ` Robert Foss
2022-05-19 21:41 ` [PATCH 2/2] clk: qcom: camcc-sm8250: " Vladimir Zapolskiy
2022-07-03 3:56 ` [PATCH 0/2] clk: qcom: " Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Vladimir Zapolskiy @ 2022-05-19 21:41 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Michael Turquette, Stephen Boyd, Robert Foss,
linux-arm-msm, linux-clk
On SDM845 two found VFE GDSC power domains shall not be operated, if
titan top is turned off, thus the former power domains will be set as
subdomains by a GDSC registration routine.
Fixes: 78412c262004 ("clk: qcom: Add camera clock controller driver for SDM845")
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
drivers/clk/qcom/camcc-sdm845.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/qcom/camcc-sdm845.c b/drivers/clk/qcom/camcc-sdm845.c
index be3f95326965..27d44188a7ab 100644
--- a/drivers/clk/qcom/camcc-sdm845.c
+++ b/drivers/clk/qcom/camcc-sdm845.c
@@ -1534,6 +1534,8 @@ static struct clk_branch cam_cc_sys_tmr_clk = {
},
};
+static struct gdsc titan_top_gdsc;
+
static struct gdsc bps_gdsc = {
.gdscr = 0x6004,
.pd = {
@@ -1567,6 +1569,7 @@ static struct gdsc ife_0_gdsc = {
.name = "ife_0_gdsc",
},
.flags = POLL_CFG_GDSCR,
+ .parent = &titan_top_gdsc.pd,
.pwrsts = PWRSTS_OFF_ON,
};
@@ -1576,6 +1579,7 @@ static struct gdsc ife_1_gdsc = {
.name = "ife_1_gdsc",
},
.flags = POLL_CFG_GDSCR,
+ .parent = &titan_top_gdsc.pd,
.pwrsts = PWRSTS_OFF_ON,
};
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] clk: qcom: camcc-sdm845: Fix topology around titan_top power domain
2022-05-19 21:41 ` [PATCH 1/2] clk: qcom: camcc-sdm845: " Vladimir Zapolskiy
@ 2022-05-23 8:57 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-05-23 8:57 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: Bjorn Andersson, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk
On Thu, 19 May 2022 at 23:41, Vladimir Zapolskiy
<vladimir.zapolskiy@linaro.org> wrote:
>
> On SDM845 two found VFE GDSC power domains shall not be operated, if
> titan top is turned off, thus the former power domains will be set as
> subdomains by a GDSC registration routine.
>
> Fixes: 78412c262004 ("clk: qcom: Add camera clock controller driver for SDM845")
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> drivers/clk/qcom/camcc-sdm845.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/qcom/camcc-sdm845.c b/drivers/clk/qcom/camcc-sdm845.c
> index be3f95326965..27d44188a7ab 100644
> --- a/drivers/clk/qcom/camcc-sdm845.c
> +++ b/drivers/clk/qcom/camcc-sdm845.c
> @@ -1534,6 +1534,8 @@ static struct clk_branch cam_cc_sys_tmr_clk = {
> },
> };
>
> +static struct gdsc titan_top_gdsc;
> +
> static struct gdsc bps_gdsc = {
> .gdscr = 0x6004,
> .pd = {
> @@ -1567,6 +1569,7 @@ static struct gdsc ife_0_gdsc = {
> .name = "ife_0_gdsc",
> },
> .flags = POLL_CFG_GDSCR,
> + .parent = &titan_top_gdsc.pd,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> @@ -1576,6 +1579,7 @@ static struct gdsc ife_1_gdsc = {
> .name = "ife_1_gdsc",
> },
> .flags = POLL_CFG_GDSCR,
> + .parent = &titan_top_gdsc.pd,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> --
> 2.33.0
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] clk: qcom: camcc-sm8250: Fix topology around titan_top power domain
2022-05-19 21:41 [PATCH 0/2] clk: qcom: Fix topology around titan_top power domain Vladimir Zapolskiy
2022-05-19 21:41 ` [PATCH 1/2] clk: qcom: camcc-sdm845: " Vladimir Zapolskiy
@ 2022-05-19 21:41 ` Vladimir Zapolskiy
2022-05-23 8:57 ` Robert Foss
2022-07-03 3:56 ` [PATCH 0/2] clk: qcom: " Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Vladimir Zapolskiy @ 2022-05-19 21:41 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Michael Turquette, Stephen Boyd, Robert Foss,
linux-arm-msm, linux-clk
On SM8250 two found VFE GDSC power domains shall not be operated, if
titan top is turned off, thus the former power domains will be set as
subdomains by a GDSC registration routine.
Fixes: 5d66ca79b58c ("clk: qcom: Add camera clock controller driver for SM8250")
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
drivers/clk/qcom/camcc-sm8250.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/qcom/camcc-sm8250.c b/drivers/clk/qcom/camcc-sm8250.c
index 439eaafdcc86..d68376077d51 100644
--- a/drivers/clk/qcom/camcc-sm8250.c
+++ b/drivers/clk/qcom/camcc-sm8250.c
@@ -2205,6 +2205,8 @@ static struct clk_branch cam_cc_sleep_clk = {
},
};
+static struct gdsc titan_top_gdsc;
+
static struct gdsc bps_gdsc = {
.gdscr = 0x7004,
.pd = {
@@ -2238,6 +2240,7 @@ static struct gdsc ife_0_gdsc = {
.name = "ife_0_gdsc",
},
.flags = POLL_CFG_GDSCR,
+ .parent = &titan_top_gdsc.pd,
.pwrsts = PWRSTS_OFF_ON,
};
@@ -2247,6 +2250,7 @@ static struct gdsc ife_1_gdsc = {
.name = "ife_1_gdsc",
},
.flags = POLL_CFG_GDSCR,
+ .parent = &titan_top_gdsc.pd,
.pwrsts = PWRSTS_OFF_ON,
};
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] clk: qcom: camcc-sm8250: Fix topology around titan_top power domain
2022-05-19 21:41 ` [PATCH 2/2] clk: qcom: camcc-sm8250: " Vladimir Zapolskiy
@ 2022-05-23 8:57 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-05-23 8:57 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: Bjorn Andersson, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk
On Thu, 19 May 2022 at 23:41, Vladimir Zapolskiy
<vladimir.zapolskiy@linaro.org> wrote:
>
> On SM8250 two found VFE GDSC power domains shall not be operated, if
> titan top is turned off, thus the former power domains will be set as
> subdomains by a GDSC registration routine.
>
> Fixes: 5d66ca79b58c ("clk: qcom: Add camera clock controller driver for SM8250")
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> drivers/clk/qcom/camcc-sm8250.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/qcom/camcc-sm8250.c b/drivers/clk/qcom/camcc-sm8250.c
> index 439eaafdcc86..d68376077d51 100644
> --- a/drivers/clk/qcom/camcc-sm8250.c
> +++ b/drivers/clk/qcom/camcc-sm8250.c
> @@ -2205,6 +2205,8 @@ static struct clk_branch cam_cc_sleep_clk = {
> },
> };
>
> +static struct gdsc titan_top_gdsc;
> +
> static struct gdsc bps_gdsc = {
> .gdscr = 0x7004,
> .pd = {
> @@ -2238,6 +2240,7 @@ static struct gdsc ife_0_gdsc = {
> .name = "ife_0_gdsc",
> },
> .flags = POLL_CFG_GDSCR,
> + .parent = &titan_top_gdsc.pd,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> @@ -2247,6 +2250,7 @@ static struct gdsc ife_1_gdsc = {
> .name = "ife_1_gdsc",
> },
> .flags = POLL_CFG_GDSCR,
> + .parent = &titan_top_gdsc.pd,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> --
> 2.33.0
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] clk: qcom: Fix topology around titan_top power domain
2022-05-19 21:41 [PATCH 0/2] clk: qcom: Fix topology around titan_top power domain Vladimir Zapolskiy
2022-05-19 21:41 ` [PATCH 1/2] clk: qcom: camcc-sdm845: " Vladimir Zapolskiy
2022-05-19 21:41 ` [PATCH 2/2] clk: qcom: camcc-sm8250: " Vladimir Zapolskiy
@ 2022-07-03 3:56 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-07-03 3:56 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: linux-clk, Michael Turquette, Andy Gross, linux-arm-msm,
Robert Foss, Stephen Boyd
On Fri, 20 May 2022 00:41:31 +0300, Vladimir Zapolskiy wrote:
> On SDM845 abd SM8250 platforms two found VFE GDSC power domains shall
> not be operated, if titan top is turned off, thus the former power
> domains will be set as subdomains by a GDSC registration routine.
>
> The fixes allow to drastically simplify power domain management in CAMSS
> driver.
>
> [...]
Applied, thanks!
[1/2] clk: qcom: camcc-sdm845: Fix topology around titan_top power domain
commit: 103dd2338bbff567bce7acd00fc5a09c806b38ec
[2/2] clk: qcom: camcc-sm8250: Fix topology around titan_top power domain
commit: f8acf01a6a4f84baf05181e24bd48def4ba23f5b
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread