From: Robert Foss <robert.foss@linaro.org> To: Jagan Teki <jagan@amarulasolutions.com> Cc: Rob Herring <robh+dt@kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@siol.net>, Sam Ravnborg <sam@ravnborg.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 Date: Mon, 15 Feb 2021 12:58:07 +0100 [thread overview] Message-ID: <CAG3jFysAq0rSVRgjDSu6gF4kHcqOGAZt+b0Rz_reHgQr3Scy6A@mail.gmail.com> (raw) In-Reply-To: <20210214175211.105107-1-jagan@amarulasolutions.com> Hey Jagan, Thanks for submitting this. checkpatch.pl threw some typ-o warnings, and I listed them below. I think either spelling is correct, but 'spelling.txt' does list this as a typ-o explicitly, so I would suggest conforming to that just to silence the checkpatch warning. This patch also passes 'dt_binding_check' and 'dtbs_check', but I think I'd like to defer to Rob Herring for an actual r-b. On Sun, 14 Feb 2021 at 18:55, Jagan Teki <jagan@amarulasolutions.com> wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > It has a flexible configuration of MIPI DSI signal input and > produce RGB565, RGB666, RGB888 output format. > > Add dt-bingings for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v3: > - updated to new dt-bindings style > > .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > new file mode 100644 > index 000000000000..13764f13fe46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge $ scripts/checkpatch.pl --git HEAD~0 WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? #7: ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. ^^^^^^^^^ > + > +maintainers: > + - Jagan Teki <jagan@amarulasolutions.com> > + > +description: | > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? #38: FILE: Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml:13: + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. ^^^^^^^^^ > + > + It has a flexible configuration of MIPI DSI signal input and > + produce RGB565, RGB666, RGB888 output format. > + > +properties: > + compatible: > + enum: > + - chipone,icn6211 > + > + reg: > + maxItems: 1 > + description: virtual channel number of a DSI peripheral > + > + reset-gpios: > + description: GPIO connected for the reset pin > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for MIPI DSI input > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for MIPI DPI output (panel or connector). > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - reset-gpios > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge@0 { > + compatible = "chipone,icn6211"; > + reg = <0>; > + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */ > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge_in: port@0 { > + reg = <0>; > + > + bridge_out_dsi: endpoint { > + remote-endpoint = <&dsi_out_bridge>; > + }; > + }; > + > + bridge_out: port@1 { > + reg = <1>; > + > + bridge_out_panel: endpoint { > + remote-endpoint = <&panel_out_bridge>; > + }; > + }; > + }; > + }; > + }; > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Robert Foss <robert.foss@linaro.org> To: Jagan Teki <jagan@amarulasolutions.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, Jonas Karlman <jonas@kwiboo.se>, linux-amarula@amarulasolutions.com, Neil Armstrong <narmstrong@baylibre.com>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Rob Herring <robh+dt@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 Date: Mon, 15 Feb 2021 12:58:07 +0100 [thread overview] Message-ID: <CAG3jFysAq0rSVRgjDSu6gF4kHcqOGAZt+b0Rz_reHgQr3Scy6A@mail.gmail.com> (raw) In-Reply-To: <20210214175211.105107-1-jagan@amarulasolutions.com> Hey Jagan, Thanks for submitting this. checkpatch.pl threw some typ-o warnings, and I listed them below. I think either spelling is correct, but 'spelling.txt' does list this as a typ-o explicitly, so I would suggest conforming to that just to silence the checkpatch warning. This patch also passes 'dt_binding_check' and 'dtbs_check', but I think I'd like to defer to Rob Herring for an actual r-b. On Sun, 14 Feb 2021 at 18:55, Jagan Teki <jagan@amarulasolutions.com> wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > It has a flexible configuration of MIPI DSI signal input and > produce RGB565, RGB666, RGB888 output format. > > Add dt-bingings for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v3: > - updated to new dt-bindings style > > .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > new file mode 100644 > index 000000000000..13764f13fe46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge $ scripts/checkpatch.pl --git HEAD~0 WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? #7: ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. ^^^^^^^^^ > + > +maintainers: > + - Jagan Teki <jagan@amarulasolutions.com> > + > +description: | > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? #38: FILE: Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml:13: + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. ^^^^^^^^^ > + > + It has a flexible configuration of MIPI DSI signal input and > + produce RGB565, RGB666, RGB888 output format. > + > +properties: > + compatible: > + enum: > + - chipone,icn6211 > + > + reg: > + maxItems: 1 > + description: virtual channel number of a DSI peripheral > + > + reset-gpios: > + description: GPIO connected for the reset pin > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for MIPI DSI input > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for MIPI DPI output (panel or connector). > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - reset-gpios > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge@0 { > + compatible = "chipone,icn6211"; > + reg = <0>; > + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */ > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge_in: port@0 { > + reg = <0>; > + > + bridge_out_dsi: endpoint { > + remote-endpoint = <&dsi_out_bridge>; > + }; > + }; > + > + bridge_out: port@1 { > + reg = <1>; > + > + bridge_out_panel: endpoint { > + remote-endpoint = <&panel_out_bridge>; > + }; > + }; > + }; > + }; > + }; > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-15 11:59 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-14 17:52 [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 Jagan Teki 2021-02-14 17:52 ` Jagan Teki 2021-02-14 17:52 ` [PATCH v3 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge Jagan Teki 2021-02-14 17:52 ` Jagan Teki 2021-02-15 12:16 ` Robert Foss 2021-02-15 12:16 ` Robert Foss 2021-02-15 11:58 ` Robert Foss [this message] 2021-02-15 11:58 ` [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 Robert Foss 2021-02-15 12:08 ` Jagan Teki 2021-02-15 12:08 ` Jagan Teki 2021-03-05 21:40 ` Rob Herring 2021-03-05 21:40 ` Rob Herring 2021-02-15 12:17 ` Laurent Pinchart 2021-02-15 12:17 ` Laurent Pinchart 2021-02-24 12:37 ` Jagan Teki 2021-02-24 12:37 ` Jagan Teki 2021-02-24 13:13 ` Laurent Pinchart 2021-02-24 13:13 ` Laurent Pinchart 2021-02-24 13:46 ` Jagan Teki 2021-02-24 13:46 ` Jagan Teki 2021-03-03 14:38 ` Jagan Teki 2021-03-03 14:38 ` Jagan Teki 2021-03-03 22:59 ` Laurent Pinchart 2021-03-03 22:59 ` Laurent Pinchart 2021-03-04 9:10 ` Jagan Teki 2021-03-04 9:10 ` Jagan Teki 2021-03-05 21:40 ` Rob Herring 2021-03-05 21:40 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAG3jFysAq0rSVRgjDSu6gF4kHcqOGAZt+b0Rz_reHgQr3Scy6A@mail.gmail.com \ --to=robert.foss@linaro.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jagan@amarulasolutions.com \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=linux-amarula@amarulasolutions.com \ --cc=linux-kernel@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.