* [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge
@ 2022-02-21 7:42 ` José Expósito
0 siblings, 0 replies; 6+ messages in thread
From: José Expósito @ 2022-02-21 7:42 UTC (permalink / raw)
To: jagan
Cc: andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, lgirdwood, broonie, maxime,
dri-devel, linux-kernel, José Expósito
The function "drm_of_find_panel_or_bridge" has been deprecated in
favor of "devm_drm_of_get_bridge".
Switch to the new function and reduce boilerplate.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index a6151db95586..23c34039ac48 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -178,7 +178,6 @@ static const struct drm_bridge_funcs chipone_bridge_funcs = {
static int chipone_parse_dt(struct chipone *icn)
{
struct device *dev = icn->dev;
- struct drm_panel *panel;
int ret;
icn->vdd1 = devm_regulator_get_optional(dev, "vdd1");
@@ -214,11 +213,7 @@ static int chipone_parse_dt(struct chipone *icn)
return PTR_ERR(icn->enable_gpio);
}
- ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &panel, NULL);
- if (ret)
- return ret;
-
- icn->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
+ icn->panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
if (IS_ERR(icn->panel_bridge))
return PTR_ERR(icn->panel_bridge);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge
@ 2022-02-21 7:42 ` José Expósito
0 siblings, 0 replies; 6+ messages in thread
From: José Expósito @ 2022-02-21 7:42 UTC (permalink / raw)
To: jagan
Cc: jonas, airlied, robert.foss, dri-devel, narmstrong, lgirdwood,
jernej.skrabec, linux-kernel, broonie, Laurent.pinchart,
andrzej.hajda, José Expósito, maxime
The function "drm_of_find_panel_or_bridge" has been deprecated in
favor of "devm_drm_of_get_bridge".
Switch to the new function and reduce boilerplate.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index a6151db95586..23c34039ac48 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -178,7 +178,6 @@ static const struct drm_bridge_funcs chipone_bridge_funcs = {
static int chipone_parse_dt(struct chipone *icn)
{
struct device *dev = icn->dev;
- struct drm_panel *panel;
int ret;
icn->vdd1 = devm_regulator_get_optional(dev, "vdd1");
@@ -214,11 +213,7 @@ static int chipone_parse_dt(struct chipone *icn)
return PTR_ERR(icn->enable_gpio);
}
- ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &panel, NULL);
- if (ret)
- return ret;
-
- icn->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
+ icn->panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
if (IS_ERR(icn->panel_bridge))
return PTR_ERR(icn->panel_bridge);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge
2022-02-21 7:42 ` José Expósito
@ 2022-02-21 8:56 ` Maxime Ripard
-1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2022-02-21 8:56 UTC (permalink / raw)
To: José Expósito
Cc: jernej.skrabec, jonas, airlied, dri-devel, narmstrong, lgirdwood,
robert.foss, linux-kernel, broonie, Laurent.pinchart,
andrzej.hajda, jagan
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
On Mon, Feb 21, 2022 at 08:42:24AM +0100, José Expósito wrote:
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>
> Switch to the new function and reduce boilerplate.
>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge
@ 2022-02-21 8:56 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2022-02-21 8:56 UTC (permalink / raw)
To: José Expósito
Cc: jagan, andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart,
jonas, jernej.skrabec, airlied, daniel, lgirdwood, broonie,
dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
On Mon, Feb 21, 2022 at 08:42:24AM +0100, José Expósito wrote:
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>
> Switch to the new function and reduce boilerplate.
>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge
2022-02-21 8:56 ` Maxime Ripard
@ 2022-03-01 13:04 ` Robert Foss
-1 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-03-01 13:04 UTC (permalink / raw)
To: Maxime Ripard
Cc: José Expósito, jagan, andrzej.hajda, narmstrong,
laurent.pinchart, jonas, jernej.skrabec, airlied, daniel,
lgirdwood, broonie, dri-devel, linux-kernel
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge
@ 2022-03-01 13:04 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-03-01 13:04 UTC (permalink / raw)
To: Maxime Ripard
Cc: jonas, airlied, dri-devel, narmstrong, lgirdwood, jernej.skrabec,
linux-kernel, broonie, laurent.pinchart, andrzej.hajda,
José Expósito, jagan
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-01 13:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 7:42 [PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge José Expósito
2022-02-21 7:42 ` José Expósito
2022-02-21 8:56 ` Maxime Ripard
2022-02-21 8:56 ` Maxime Ripard
2022-03-01 13:04 ` Robert Foss
2022-03-01 13:04 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.