[PATCH v2] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi

[PATCH v2] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi

[Jagan Teki]

panel_bridge pointer never used anywhere except the one it
looked up at nwl_dsi_bridge_attach.

Drop it from the nwl_dsi structure.

Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- collect Guido r-b

Note: This is patch is part of switching of devm_drm_of_get_bridge 
serious however the child node support of devm_drm_of_get_bridge is
still under-review. So send it separatly as it not related to that
API switch.
https://patchwork.kernel.org/project/dri-devel/patch/20211210174819.2250178-1-jagan@amarulasolutions.com/

 drivers/gpu/drm/bridge/nwl-dsi.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index fc3ad9fab867..9282e61dfbf0 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -65,7 +65,6 @@ struct nwl_dsi_transfer {
 struct nwl_dsi {
 	struct drm_bridge bridge;
 	struct mipi_dsi_host dsi_host;
-	struct drm_bridge *panel_bridge;
 	struct device *dev;
 	struct phy *phy;
 	union phy_configure_opts phy_cfg;
@@ -924,13 +923,11 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
 		if (IS_ERR(panel_bridge))
 			return PTR_ERR(panel_bridge);
 	}
-	dsi->panel_bridge = panel_bridge;
 
-	if (!dsi->panel_bridge)
+	if (!panel_bridge)
 		return -EPROBE_DEFER;
 
-	return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge,
-				 flags);
+	return drm_bridge_attach(bridge->encoder, panel_bridge, bridge, flags);
 }
 
 static void nwl_dsi_bridge_detach(struct drm_bridge *bridge)
-- 
2.25.1

Re: [PATCH v2] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi

[Robert Foss]

On Mon, 10 Jan 2022 at 18:25, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> panel_bridge pointer never used anywhere except the one it
> looked up at nwl_dsi_bridge_attach.
>
> Drop it from the nwl_dsi structure.
>
> Reviewed-by: Guido Günther <agx@sigxcpu.org>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - collect Guido r-b
>
> Note: This is patch is part of switching of devm_drm_of_get_bridge
> serious however the child node support of devm_drm_of_get_bridge is
> still under-review. So send it separatly as it not related to that
> API switch.
> https://patchwork.kernel.org/project/dri-devel/patch/20211210174819.2250178-1-jagan@amarulasolutions.com/
>
>  drivers/gpu/drm/bridge/nwl-dsi.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
> index fc3ad9fab867..9282e61dfbf0 100644
> --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> @@ -65,7 +65,6 @@ struct nwl_dsi_transfer {
>  struct nwl_dsi {
>         struct drm_bridge bridge;
>         struct mipi_dsi_host dsi_host;
> -       struct drm_bridge *panel_bridge;
>         struct device *dev;
>         struct phy *phy;
>         union phy_configure_opts phy_cfg;
> @@ -924,13 +923,11 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
>                 if (IS_ERR(panel_bridge))
>                         return PTR_ERR(panel_bridge);
>         }
> -       dsi->panel_bridge = panel_bridge;
>
> -       if (!dsi->panel_bridge)
> +       if (!panel_bridge)
>                 return -EPROBE_DEFER;
>
> -       return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge,
> -                                flags);
> +       return drm_bridge_attach(bridge->encoder, panel_bridge, bridge, flags);
>  }
>
>  static void nwl_dsi_bridge_detach(struct drm_bridge *bridge)

Applied to drm-misc-next.