All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
@ 2021-11-24 14:52 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-11-24 14:52 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, David Airlie, Daniel Vetter, Xin Ji,
	Sam Ravnborg, Pi-Hsun Shih, Tzung-Bi Shih, Maxime Ripard,
	Hsin-Yi Wang, dri-devel, kernel-janitors

This code accidentally returns IS_ERR(), which is 1, instead of
propagating the negative error code.  The caller doesn't check for
errors so it doesn't affect run time at all.

Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 001fb39d9919..f56e106b445d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx)
 							sizeof(codec_data));
 
 	if (IS_ERR(ctx->audio_pdev))
-		return IS_ERR(ctx->audio_pdev);
+		return PTR_ERR(ctx->audio_pdev);
 
 	DRM_DEV_DEBUG_DRIVER(dev, "bound to %s", HDMI_CODEC_DRV_NAME);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
@ 2021-11-24 14:52 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-11-24 14:52 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Pi-Hsun Shih, Jonas Karlman, David Airlie, Robert Foss,
	dri-devel, Neil Armstrong, kernel-janitors, Jernej Skrabec,
	Tzung-Bi Shih, Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg,
	Xin Ji, Maxime Ripard

This code accidentally returns IS_ERR(), which is 1, instead of
propagating the negative error code.  The caller doesn't check for
errors so it doesn't affect run time at all.

Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 001fb39d9919..f56e106b445d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx)
 							sizeof(codec_data));
 
 	if (IS_ERR(ctx->audio_pdev))
-		return IS_ERR(ctx->audio_pdev);
+		return PTR_ERR(ctx->audio_pdev);
 
 	DRM_DEV_DEBUG_DRIVER(dev, "bound to %s", HDMI_CODEC_DRV_NAME);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
  2021-11-24 14:52 ` Dan Carpenter
@ 2021-11-25  8:16   ` Tzung-Bi Shih
  -1 siblings, 0 replies; 6+ messages in thread
From: Tzung-Bi Shih @ 2021-11-25  8:16 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Pi-Hsun Shih, Jonas Karlman, David Airlie, Robert Foss,
	dri-devel, Neil Armstrong, kernel-janitors, Jernej Skrabec,
	Andrzej Hajda, Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg,
	Xin Ji, Maxime Ripard

On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote:
> This code accidentally returns IS_ERR(), which is 1, instead of
> propagating the negative error code.  The caller doesn't check for
> errors so it doesn't affect run time at all.
> 
> Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
@ 2021-11-25  8:16   ` Tzung-Bi Shih
  0 siblings, 0 replies; 6+ messages in thread
From: Tzung-Bi Shih @ 2021-11-25  8:16 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
	Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
	Xin Ji, Sam Ravnborg, Pi-Hsun Shih, Maxime Ripard, Hsin-Yi Wang,
	dri-devel, kernel-janitors

On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote:
> This code accidentally returns IS_ERR(), which is 1, instead of
> propagating the negative error code.  The caller doesn't check for
> errors so it doesn't affect run time at all.
> 
> Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
  2021-11-25  8:16   ` Tzung-Bi Shih
@ 2021-11-25 10:08     ` Robert Foss
  -1 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2021-11-25 10:08 UTC (permalink / raw)
  To: Tzung-Bi Shih
  Cc: Pi-Hsun Shih, Jonas Karlman, David Airlie, dri-devel,
	Neil Armstrong, kernel-janitors, Jernej Skrabec, Andrzej Hajda,
	Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Xin Ji,
	Dan Carpenter, Maxime Ripard

On Thu, 25 Nov 2021 at 09:16, Tzung-Bi Shih <tzungbi@google.com> wrote:
>
> On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote:
> > This code accidentally returns IS_ERR(), which is 1, instead of
> > propagating the negative error code.  The caller doesn't check for
> > errors so it doesn't affect run time at all.
> >
> > Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>

Applied to drm-misc-next.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()
@ 2021-11-25 10:08     ` Robert Foss
  0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2021-11-25 10:08 UTC (permalink / raw)
  To: Tzung-Bi Shih
  Cc: Dan Carpenter, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
	Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
	Xin Ji, Sam Ravnborg, Pi-Hsun Shih, Maxime Ripard, Hsin-Yi Wang,
	dri-devel, kernel-janitors

On Thu, 25 Nov 2021 at 09:16, Tzung-Bi Shih <tzungbi@google.com> wrote:
>
> On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote:
> > This code accidentally returns IS_ERR(), which is 1, instead of
> > propagating the negative error code.  The caller doesn't check for
> > errors so it doesn't affect run time at all.
> >
> > Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>

Applied to drm-misc-next.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-25 10:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 14:52 [PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio() Dan Carpenter
2021-11-24 14:52 ` Dan Carpenter
2021-11-25  8:16 ` Tzung-Bi Shih
2021-11-25  8:16   ` Tzung-Bi Shih
2021-11-25 10:08   ` Robert Foss
2021-11-25 10:08     ` Robert Foss

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.