* [PATCH] drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper
@ 2021-05-04 14:38 ` Douglas Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2021-05-04 14:38 UTC (permalink / raw)
To: Andrzej Hajda, Laurent Pinchart
Cc: Steev Klimaszewski, Linus Walleij, Bjorn Andersson,
Douglas Anderson, kernel test robot, Daniel Vetter, David Airlie,
Jernej Skrabec, Jonas Karlman, Neil Armstrong, Robert Foss,
dri-devel, linux-kernel
The ti_sn_gpio_unregister() is not just called from the remove path
but also from the error handling of the init path. That means it can't
have the __exit annotation.
Fixes: bf73537f411b ("drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index db027528febd..bb0a0e1c6341 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1251,7 +1251,7 @@ static int __init ti_sn_gpio_register(void)
return auxiliary_driver_register(&ti_sn_gpio_driver);
}
-static void __exit ti_sn_gpio_unregister(void)
+static void ti_sn_gpio_unregister(void)
{
auxiliary_driver_unregister(&ti_sn_gpio_driver);
}
--
2.31.1.527.g47e6f16901-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper
@ 2021-05-04 14:38 ` Douglas Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2021-05-04 14:38 UTC (permalink / raw)
To: Andrzej Hajda, Laurent Pinchart
Cc: dri-devel, Jernej Skrabec, kernel test robot, Jonas Karlman,
David Airlie, linux-kernel, Neil Armstrong, Douglas Anderson,
Steev Klimaszewski, Bjorn Andersson, Robert Foss
The ti_sn_gpio_unregister() is not just called from the remove path
but also from the error handling of the init path. That means it can't
have the __exit annotation.
Fixes: bf73537f411b ("drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index db027528febd..bb0a0e1c6341 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1251,7 +1251,7 @@ static int __init ti_sn_gpio_register(void)
return auxiliary_driver_register(&ti_sn_gpio_driver);
}
-static void __exit ti_sn_gpio_unregister(void)
+static void ti_sn_gpio_unregister(void)
{
auxiliary_driver_unregister(&ti_sn_gpio_driver);
}
--
2.31.1.527.g47e6f16901-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper
2021-05-04 14:38 ` Douglas Anderson
(?)
@ 2021-05-04 15:22 ` Robert Foss
2021-05-04 15:54 ` Robert Foss
-1 siblings, 1 reply; 4+ messages in thread
From: Robert Foss @ 2021-05-04 15:22 UTC (permalink / raw)
To: Douglas Anderson
Cc: dri-devel, Jernej Skrabec, kernel test robot, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, Steev Klimaszewski,
Bjorn Andersson, Andrzej Hajda, Laurent Pinchart
[-- Attachment #1.1: Type: text/plain, Size: 1205 bytes --]
Hey Douglas,
On Tue, 4 May 2021 at 16:39, Douglas Anderson <dianders@chromium.org> wrote:
> The ti_sn_gpio_unregister() is not just called from the remove path
> but also from the error handling of the init path. That means it can't
> have the __exit annotation.
>
> Fixes: bf73537f411b ("drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP
> bridge into sub-drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index db027528febd..bb0a0e1c6341 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1251,7 +1251,7 @@ static int __init ti_sn_gpio_register(void)
> return auxiliary_driver_register(&ti_sn_gpio_driver);
> }
>
> -static void __exit ti_sn_gpio_unregister(void)
> +static void ti_sn_gpio_unregister(void)
> {
> auxiliary_driver_unregister(&ti_sn_gpio_driver);
> }
> --
> 2.31.1.527.g47e6f16901-goog
>
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
[-- Attachment #1.2: Type: text/html, Size: 1829 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper
2021-05-04 15:22 ` Robert Foss
@ 2021-05-04 15:54 ` Robert Foss
0 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2021-05-04 15:54 UTC (permalink / raw)
To: Douglas Anderson
Cc: dri-devel, Jernej Skrabec, kernel test robot, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, Steev Klimaszewski,
Bjorn Andersson, Andrzej Hajda, Laurent Pinchart
[-- Attachment #1.1: Type: text/plain, Size: 1348 bytes --]
Merged to drm-misc-next.
On Tue, 4 May 2021 at 17:22, Robert Foss <robert.foss@linaro.org> wrote:
> Hey Douglas,
>
> On Tue, 4 May 2021 at 16:39, Douglas Anderson <dianders@chromium.org>
> wrote:
>
>> The ti_sn_gpio_unregister() is not just called from the remove path
>> but also from the error handling of the init path. That means it can't
>> have the __exit annotation.
>>
>> Fixes: bf73537f411b ("drm/bridge: ti-sn65dsi86: Break GPIO and
>> MIPI-to-eDP bridge into sub-drivers")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> ---
>>
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> index db027528febd..bb0a0e1c6341 100644
>> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> @@ -1251,7 +1251,7 @@ static int __init ti_sn_gpio_register(void)
>> return auxiliary_driver_register(&ti_sn_gpio_driver);
>> }
>>
>> -static void __exit ti_sn_gpio_unregister(void)
>> +static void ti_sn_gpio_unregister(void)
>> {
>> auxiliary_driver_unregister(&ti_sn_gpio_driver);
>> }
>> --
>> 2.31.1.527.g47e6f16901-goog
>>
>>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
>
[-- Attachment #1.2: Type: text/html, Size: 2247 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-04 15:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 14:38 [PATCH] drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper Douglas Anderson
2021-05-04 14:38 ` Douglas Anderson
2021-05-04 15:22 ` Robert Foss
2021-05-04 15:54 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.