* [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const
@ 2022-01-09 20:41 Colin Ian King
2022-01-09 22:58 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2022-01-09 20:41 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Sam Ravnborg, dri-devel
Cc: kernel-janitors, linux-kernel
Don't populate the read-only array clock_div_by_lanes on the stack but
instead it static const. Also makes the object code a little smaller.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c
index eb7579dec40a..ef6270806d1d 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
@@ -29,7 +29,7 @@ static void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
struct mipi_dsi_device *dsi = adv->dsi;
struct drm_display_mode *mode = &adv->curr_mode;
unsigned int hsw, hfp, hbp, vsw, vfp, vbp;
- u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
+ static const u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
hsw = mode->hsync_end - mode->hsync_start;
hfp = mode->hsync_start - mode->hdisplay;
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const
2022-01-09 20:41 [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const Colin Ian King
@ 2022-01-09 22:58 ` Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2022-01-09 22:58 UTC (permalink / raw)
To: Colin Ian King
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Sam Ravnborg,
dri-devel, kernel-janitors, linux-kernel
Hi Colin,
Thank you for the patch.
On Sun, Jan 09, 2022 at 08:41:05PM +0000, Colin Ian King wrote:
> Don't populate the read-only array clock_div_by_lanes on the stack but
> instead it static const. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> index eb7579dec40a..ef6270806d1d 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> @@ -29,7 +29,7 @@ static void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
> struct mipi_dsi_device *dsi = adv->dsi;
> struct drm_display_mode *mode = &adv->curr_mode;
> unsigned int hsw, hfp, hbp, vsw, vfp, vbp;
> - u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
> + static const u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
It's not mandatory, but I have a tendency to declare static const
variable first before all mutable variables.
>
> hsw = mode->hsync_end - mode->hsync_start;
> hfp = mode->hsync_start - mode->hdisplay;
I wonder if
/* set pixel clock divider mode */
regmap_write(adv->regmap_cec, 0x16, (12 / dsi->lanes) << 3);
would be even better, or if it would be too much black magic. Either
way,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const
@ 2022-01-09 22:58 ` Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2022-01-09 22:58 UTC (permalink / raw)
To: Colin Ian King
Cc: Jonas Karlman, David Airlie, dri-devel, Neil Armstrong,
kernel-janitors, linux-kernel, Jernej Skrabec, Robert Foss,
Andrzej Hajda, Sam Ravnborg
Hi Colin,
Thank you for the patch.
On Sun, Jan 09, 2022 at 08:41:05PM +0000, Colin Ian King wrote:
> Don't populate the read-only array clock_div_by_lanes on the stack but
> instead it static const. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> index eb7579dec40a..ef6270806d1d 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> @@ -29,7 +29,7 @@ static void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
> struct mipi_dsi_device *dsi = adv->dsi;
> struct drm_display_mode *mode = &adv->curr_mode;
> unsigned int hsw, hfp, hbp, vsw, vfp, vbp;
> - u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
> + static const u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
It's not mandatory, but I have a tendency to declare static const
variable first before all mutable variables.
>
> hsw = mode->hsync_end - mode->hsync_start;
> hfp = mode->hsync_start - mode->hdisplay;
I wonder if
/* set pixel clock divider mode */
regmap_write(adv->regmap_cec, 0x16, (12 / dsi->lanes) << 3);
would be even better, or if it would be too much black magic. Either
way,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const
2022-01-09 22:58 ` Laurent Pinchart
@ 2022-01-12 10:09 ` Robert Foss
-1 siblings, 0 replies; 5+ messages in thread
From: Robert Foss @ 2022-01-12 10:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Colin Ian King, Andrzej Hajda, Neil Armstrong, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Sam Ravnborg,
dri-devel, kernel-janitors, linux-kernel
On Sun, 9 Jan 2022 at 23:58, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Colin,
>
> Thank you for the patch.
>
> On Sun, Jan 09, 2022 at 08:41:05PM +0000, Colin Ian King wrote:
> > Don't populate the read-only array clock_div_by_lanes on the stack but
> > instead it static const. Also makes the object code a little smaller.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> > drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > index eb7579dec40a..ef6270806d1d 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > @@ -29,7 +29,7 @@ static void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
> > struct mipi_dsi_device *dsi = adv->dsi;
> > struct drm_display_mode *mode = &adv->curr_mode;
> > unsigned int hsw, hfp, hbp, vsw, vfp, vbp;
> > - u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
> > + static const u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
>
> It's not mandatory, but I have a tendency to declare static const
> variable first before all mutable variables.
>
> >
> > hsw = mode->hsync_end - mode->hsync_start;
> > hfp = mode->hsync_start - mode->hdisplay;
>
> I wonder if
>
> /* set pixel clock divider mode */
> regmap_write(adv->regmap_cec, 0x16, (12 / dsi->lanes) << 3);
>
> would be even better, or if it would be too much black magic. Either
> way,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const
@ 2022-01-12 10:09 ` Robert Foss
0 siblings, 0 replies; 5+ messages in thread
From: Robert Foss @ 2022-01-12 10:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Jonas Karlman, David Airlie, Neil Armstrong, kernel-janitors,
linux-kernel, Jernej Skrabec, dri-devel, Andrzej Hajda,
Sam Ravnborg, Colin Ian King
On Sun, 9 Jan 2022 at 23:58, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Colin,
>
> Thank you for the patch.
>
> On Sun, Jan 09, 2022 at 08:41:05PM +0000, Colin Ian King wrote:
> > Don't populate the read-only array clock_div_by_lanes on the stack but
> > instead it static const. Also makes the object code a little smaller.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> > drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > index eb7579dec40a..ef6270806d1d 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > @@ -29,7 +29,7 @@ static void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
> > struct mipi_dsi_device *dsi = adv->dsi;
> > struct drm_display_mode *mode = &adv->curr_mode;
> > unsigned int hsw, hfp, hbp, vsw, vfp, vbp;
> > - u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
> > + static const u8 clock_div_by_lanes[] = { 6, 4, 3 }; /* 2, 3, 4 lanes */
>
> It's not mandatory, but I have a tendency to declare static const
> variable first before all mutable variables.
>
> >
> > hsw = mode->hsync_end - mode->hsync_start;
> > hfp = mode->hsync_start - mode->hdisplay;
>
> I wonder if
>
> /* set pixel clock divider mode */
> regmap_write(adv->regmap_cec, 0x16, (12 / dsi->lanes) << 3);
>
> would be even better, or if it would be too much black magic. Either
> way,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-12 10:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-09 20:41 [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const Colin Ian King
2022-01-09 22:58 ` Laurent Pinchart
2022-01-09 22:58 ` Laurent Pinchart
2022-01-12 10:09 ` Robert Foss
2022-01-12 10:09 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.