From: Robert Foss <robert.foss@linaro.org> To: Zhiming Liu <lzmlzmhh@gmail.com> Cc: narmstrong@baylibre.com, laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver Date: Mon, 17 Jan 2022 16:49:40 +0100 [thread overview] Message-ID: <CAG3jFyuEpiSdzNQ9=U30Bvr4bC+diG3XJHX6Kz38Mw62a5YVGA@mail.gmail.com> (raw) In-Reply-To: <20220117154150.5145-1-lzmlzmhh@gmail.com> Hey Zhiming, On Mon, 17 Jan 2022 at 16:42, Zhiming Liu <lzmlzmhh@gmail.com> wrote: > > drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver. The commit title is already in the email title, it doesn't need to be sent twice, sorry if I was unclear about this. > > We have got the device of i2c client in probe function.So we should remove extra This line is too long, and `checkpatch.pl --strict` complains about its length. > device acquisition method of i2c client. > > Signed-off-by: Zhiming Liu <lzmlzmhh@gmail.com> > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++-- > drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index dafb1b47c15f..feb128a4557d 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, > if (!lt9611) > return -ENOMEM; > > - lt9611->dev = &client->dev; > + lt9611->dev = dev; > lt9611->client = client; > lt9611->sleep = false; > > @@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client, > return PTR_ERR(lt9611->regmap); > } > > - ret = lt9611_parse_dt(&client->dev, lt9611); > + ret = lt9611_parse_dt(dev, lt9611); > if (ret) { > dev_err(dev, "failed to parse device tree\n"); > return ret; > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > index 33f9716da0ee..3d62e6bf6892 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, > if (!lt9611uxc) > return -ENOMEM; > > - lt9611uxc->dev = &client->dev; > + lt9611uxc->dev = dev; > lt9611uxc->client = client; > mutex_init(<9611uxc->ocm_lock); > > @@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client, > return PTR_ERR(lt9611uxc->regmap); > } > > - ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc); > + ret = lt9611uxc_parse_dt(dev, lt9611uxc); > if (ret) { > dev_err(dev, "failed to parse device tree\n"); > return ret; > -- I fixed the two remaining issues in your patch, but in the future I would suggest running `checkpatch.pl --strict` on every patch before emailing them out. It's very easy to miss something. Reviewed-by: Robert Foss <robert.foss@linaro.org> Applied to drm-misc-next.
WARNING: multiple messages have this Message-ID (diff)
From: Robert Foss <robert.foss@linaro.org> To: Zhiming Liu <lzmlzmhh@gmail.com> Cc: jernej.skrabec@gmail.com, jonas@kwiboo.se, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH v3] drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver Date: Mon, 17 Jan 2022 16:49:40 +0100 [thread overview] Message-ID: <CAG3jFyuEpiSdzNQ9=U30Bvr4bC+diG3XJHX6Kz38Mw62a5YVGA@mail.gmail.com> (raw) In-Reply-To: <20220117154150.5145-1-lzmlzmhh@gmail.com> Hey Zhiming, On Mon, 17 Jan 2022 at 16:42, Zhiming Liu <lzmlzmhh@gmail.com> wrote: > > drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver. The commit title is already in the email title, it doesn't need to be sent twice, sorry if I was unclear about this. > > We have got the device of i2c client in probe function.So we should remove extra This line is too long, and `checkpatch.pl --strict` complains about its length. > device acquisition method of i2c client. > > Signed-off-by: Zhiming Liu <lzmlzmhh@gmail.com> > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++-- > drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index dafb1b47c15f..feb128a4557d 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, > if (!lt9611) > return -ENOMEM; > > - lt9611->dev = &client->dev; > + lt9611->dev = dev; > lt9611->client = client; > lt9611->sleep = false; > > @@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client, > return PTR_ERR(lt9611->regmap); > } > > - ret = lt9611_parse_dt(&client->dev, lt9611); > + ret = lt9611_parse_dt(dev, lt9611); > if (ret) { > dev_err(dev, "failed to parse device tree\n"); > return ret; > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > index 33f9716da0ee..3d62e6bf6892 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, > if (!lt9611uxc) > return -ENOMEM; > > - lt9611uxc->dev = &client->dev; > + lt9611uxc->dev = dev; > lt9611uxc->client = client; > mutex_init(<9611uxc->ocm_lock); > > @@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client, > return PTR_ERR(lt9611uxc->regmap); > } > > - ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc); > + ret = lt9611uxc_parse_dt(dev, lt9611uxc); > if (ret) { > dev_err(dev, "failed to parse device tree\n"); > return ret; > -- I fixed the two remaining issues in your patch, but in the future I would suggest running `checkpatch.pl --strict` on every patch before emailing them out. It's very easy to miss something. Reviewed-by: Robert Foss <robert.foss@linaro.org> Applied to drm-misc-next.
next prev parent reply other threads:[~2022-01-17 15:49 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-17 15:41 [PATCH v3] drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver Zhiming Liu 2022-01-17 15:41 ` Zhiming Liu 2022-01-17 15:49 ` Robert Foss [this message] 2022-01-17 15:49 ` Robert Foss
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAG3jFyuEpiSdzNQ9=U30Bvr4bC+diG3XJHX6Kz38Mw62a5YVGA@mail.gmail.com' \ --to=robert.foss@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lzmlzmhh@gmail.com \ --cc=narmstrong@baylibre.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.