* [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
@ 2022-02-17 2:44 ` Xin Ji
0 siblings, 0 replies; 8+ messages in thread
From: Xin Ji @ 2022-02-17 2:44 UTC (permalink / raw)
To: andrzej.hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Xin Ji
Cc: bliang, qwen, hsinyi, Xin Ji, dri-devel, linux-kernel
From: Xin Ji <xji@analogix.corp-partner.google.com>
If "hdcp_workqueue" exist, must release "hdcp_workqueue",
not "workqueue".
Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 633618bafd75..9aab879a8851 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
if (platform->hdcp_workqueue) {
cancel_delayed_work(&platform->hdcp_work);
- flush_workqueue(platform->workqueue);
- destroy_workqueue(platform->workqueue);
+ flush_workqueue(platform->hdcp_workqueue);
+ destroy_workqueue(platform->hdcp_workqueue);
}
if (!platform->pdata.low_power_mode)
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
@ 2022-02-17 2:44 ` Xin Ji
0 siblings, 0 replies; 8+ messages in thread
From: Xin Ji @ 2022-02-17 2:44 UTC (permalink / raw)
To: andrzej.hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Xin Ji
Cc: qwen, linux-kernel, dri-devel, Xin Ji, hsinyi, bliang
From: Xin Ji <xji@analogix.corp-partner.google.com>
If "hdcp_workqueue" exist, must release "hdcp_workqueue",
not "workqueue".
Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 633618bafd75..9aab879a8851 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
if (platform->hdcp_workqueue) {
cancel_delayed_work(&platform->hdcp_work);
- flush_workqueue(platform->workqueue);
- destroy_workqueue(platform->workqueue);
+ flush_workqueue(platform->hdcp_workqueue);
+ destroy_workqueue(platform->hdcp_workqueue);
}
if (!platform->pdata.low_power_mode)
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
2022-02-17 2:44 ` Xin Ji
@ 2022-02-17 3:02 ` Hsin-Yi Wang
-1 siblings, 0 replies; 8+ messages in thread
From: Hsin-Yi Wang @ 2022-02-17 3:02 UTC (permalink / raw)
To: Xin Ji
Cc: andrzej.hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
bliang, qwen, Xin Ji, dri-devel, linux-kernel
On Thu, Feb 17, 2022 at 10:45 AM Xin Ji <xji@analogixsemi.com> wrote:
>
> From: Xin Ji <xji@analogix.corp-partner.google.com>
>
> If "hdcp_workqueue" exist, must release "hdcp_workqueue",
> not "workqueue".
>
> Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
This fixes an issue that the driver will crash during unbind.
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 633618bafd75..9aab879a8851 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
>
> if (platform->hdcp_workqueue) {
> cancel_delayed_work(&platform->hdcp_work);
> - flush_workqueue(platform->workqueue);
> - destroy_workqueue(platform->workqueue);
> + flush_workqueue(platform->hdcp_workqueue);
> + destroy_workqueue(platform->hdcp_workqueue);
> }
>
> if (!platform->pdata.low_power_mode)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
@ 2022-02-17 3:02 ` Hsin-Yi Wang
0 siblings, 0 replies; 8+ messages in thread
From: Hsin-Yi Wang @ 2022-02-17 3:02 UTC (permalink / raw)
To: Xin Ji
Cc: dri-devel, Jonas Karlman, David Airlie, Robert Foss, qwen,
Neil Armstrong, linux-kernel, Jernej Skrabec, Laurent Pinchart,
andrzej.hajda, bliang, Xin Ji
On Thu, Feb 17, 2022 at 10:45 AM Xin Ji <xji@analogixsemi.com> wrote:
>
> From: Xin Ji <xji@analogix.corp-partner.google.com>
>
> If "hdcp_workqueue" exist, must release "hdcp_workqueue",
> not "workqueue".
>
> Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
This fixes an issue that the driver will crash during unbind.
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 633618bafd75..9aab879a8851 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
>
> if (platform->hdcp_workqueue) {
> cancel_delayed_work(&platform->hdcp_work);
> - flush_workqueue(platform->workqueue);
> - destroy_workqueue(platform->workqueue);
> + flush_workqueue(platform->hdcp_workqueue);
> + destroy_workqueue(platform->hdcp_workqueue);
> }
>
> if (!platform->pdata.low_power_mode)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
2022-02-17 3:02 ` Hsin-Yi Wang
@ 2022-03-01 8:58 ` Hsin-Yi Wang
-1 siblings, 0 replies; 8+ messages in thread
From: Hsin-Yi Wang @ 2022-03-01 8:58 UTC (permalink / raw)
To: Xin Ji
Cc: andrzej.hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
bliang, qwen, Xin Ji, dri-devel, linux-kernel
On Thu, Feb 17, 2022 at 11:02 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> On Thu, Feb 17, 2022 at 10:45 AM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > From: Xin Ji <xji@analogix.corp-partner.google.com>
> >
> > If "hdcp_workqueue" exist, must release "hdcp_workqueue",
> > not "workqueue".
> >
> > Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> This fixes an issue that the driver will crash during unbind.
>
Hi Robert,
Kindly ping on this fix. Thanks.
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 633618bafd75..9aab879a8851 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
> >
> > if (platform->hdcp_workqueue) {
> > cancel_delayed_work(&platform->hdcp_work);
> > - flush_workqueue(platform->workqueue);
> > - destroy_workqueue(platform->workqueue);
> > + flush_workqueue(platform->hdcp_workqueue);
> > + destroy_workqueue(platform->hdcp_workqueue);
> > }
> >
> > if (!platform->pdata.low_power_mode)
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
@ 2022-03-01 8:58 ` Hsin-Yi Wang
0 siblings, 0 replies; 8+ messages in thread
From: Hsin-Yi Wang @ 2022-03-01 8:58 UTC (permalink / raw)
To: Xin Ji
Cc: dri-devel, Jonas Karlman, David Airlie, Robert Foss, qwen,
Neil Armstrong, linux-kernel, Jernej Skrabec, Laurent Pinchart,
andrzej.hajda, bliang, Xin Ji
On Thu, Feb 17, 2022 at 11:02 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> On Thu, Feb 17, 2022 at 10:45 AM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > From: Xin Ji <xji@analogix.corp-partner.google.com>
> >
> > If "hdcp_workqueue" exist, must release "hdcp_workqueue",
> > not "workqueue".
> >
> > Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> This fixes an issue that the driver will crash during unbind.
>
Hi Robert,
Kindly ping on this fix. Thanks.
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 633618bafd75..9aab879a8851 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
> >
> > if (platform->hdcp_workqueue) {
> > cancel_delayed_work(&platform->hdcp_work);
> > - flush_workqueue(platform->workqueue);
> > - destroy_workqueue(platform->workqueue);
> > + flush_workqueue(platform->hdcp_workqueue);
> > + destroy_workqueue(platform->hdcp_workqueue);
> > }
> >
> > if (!platform->pdata.low_power_mode)
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
2022-03-01 8:58 ` Hsin-Yi Wang
@ 2022-03-01 13:01 ` Robert Foss
-1 siblings, 0 replies; 8+ messages in thread
From: Robert Foss @ 2022-03-01 13:01 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Xin Ji, andrzej.hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
bliang, qwen, Xin Ji, dri-devel, linux-kernel
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue
@ 2022-03-01 13:01 ` Robert Foss
0 siblings, 0 replies; 8+ messages in thread
From: Robert Foss @ 2022-03-01 13:01 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, Jernej Skrabec, Laurent Pinchart, andrzej.hajda,
bliang, Xin Ji, Xin Ji
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-01 13:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17 2:44 [PATCH] drm/bridge: anx7625: Fix release wrong workqueue Xin Ji
2022-02-17 2:44 ` Xin Ji
2022-02-17 3:02 ` Hsin-Yi Wang
2022-02-17 3:02 ` Hsin-Yi Wang
2022-03-01 8:58 ` Hsin-Yi Wang
2022-03-01 8:58 ` Hsin-Yi Wang
2022-03-01 13:01 ` Robert Foss
2022-03-01 13:01 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.