* [PATCH] drm: bridge: icn6211: Mark module exit callback with __exit
@ 2022-04-06 1:42 Marek Vasut
2022-04-06 7:34 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2022-04-06 1:42 UTC (permalink / raw)
To: dri-devel
Cc: Marek Vasut, Stephen Rothwell, robert.foss, Jagan Teki,
Thomas Zimmermann, Sam Ravnborg, Maxime Ripard
Fix copy-paste error, module exit function should be marked with __exit
instead of __init.
Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index c4d2f6d811bf1..b9cc0fac26686 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -787,7 +787,7 @@ static int __init chipone_init(void)
}
module_init(chipone_init);
-static void __init chipone_exit(void)
+static void __exit chipone_exit(void)
{
i2c_del_driver(&chipone_i2c_driver);
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: icn6211: Mark module exit callback with __exit
2022-04-06 1:42 [PATCH] drm: bridge: icn6211: Mark module exit callback with __exit Marek Vasut
@ 2022-04-06 7:34 ` Robert Foss
2022-04-06 7:36 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2022-04-06 7:34 UTC (permalink / raw)
To: Marek Vasut
Cc: Stephen Rothwell, dri-devel, Jagan Teki, Thomas Zimmermann,
Sam Ravnborg, Maxime Ripard
On Wed, 6 Apr 2022 at 03:43, Marek Vasut <marex@denx.de> wrote:
>
> Fix copy-paste error, module exit function should be marked with __exit
> instead of __init.
>
> Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> To: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index c4d2f6d811bf1..b9cc0fac26686 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -787,7 +787,7 @@ static int __init chipone_init(void)
> }
> module_init(chipone_init);
>
> -static void __init chipone_exit(void)
> +static void __exit chipone_exit(void)
> {
> i2c_del_driver(&chipone_i2c_driver);
>
> --
> 2.35.1
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: icn6211: Mark module exit callback with __exit
2022-04-06 7:34 ` Robert Foss
@ 2022-04-06 7:36 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-04-06 7:36 UTC (permalink / raw)
To: Marek Vasut
Cc: Stephen Rothwell, dri-devel, Jagan Teki, Thomas Zimmermann,
Sam Ravnborg, Maxime Ripard
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 1:42 [PATCH] drm: bridge: icn6211: Mark module exit callback with __exit Marek Vasut
2022-04-06 7:34 ` Robert Foss
2022-04-06 7:36 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.