* [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"
@ 2022-05-23 16:15 Robert Foss
2022-05-23 16:15 ` [PATCH v2 2/2] Revert "dt-bindings:drm/bridge:anx7625: add port@0 property" Robert Foss
2022-05-23 16:17 ` [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type" Robert Foss
0 siblings, 2 replies; 3+ messages in thread
From: Robert Foss @ 2022-05-23 16:15 UTC (permalink / raw)
To: andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, robh+dt, krzysztof.kozlowski+dt,
xji, hsinyi, sam, maxime, tzimmermann, jose.exposito89,
dri-devel, devicetree, linux-kernel
Cc: Daniel Vetter
This reverts commit a77c2af0994e24ee36c7ffb6dc852770bdf06fb1.
This patch depends on the patches just aplied to the media tree, and will
not build without them, which leaves drm-misc-next in a broken state.
Let's revert the two latter patches until rc1 has been branched,
and rc1 has been backmerged into drm-misc-next.
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 0fab2aa47c67..e92eb4a40745 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
anx7625_get_swing_setting(dev, pdata);
- pdata->is_dpi = 0; /* default dsi mode */
+ pdata->is_dpi = 1; /* default dpi mode */
pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
if (!pdata->mipi_host_node) {
DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
return -ENODEV;
}
- bus_type = 0;
+ bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
mipi_lanes = MAX_LANES_SUPPORT;
ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
if (ep0) {
@@ -1641,8 +1641,8 @@ static int anx7625_parse_dt(struct device *dev,
of_node_put(ep0);
}
- if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
- pdata->is_dpi = 1;
+ if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
+ pdata->is_dpi = 0;
pdata->mipi_lanes = mipi_lanes;
if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] Revert "dt-bindings:drm/bridge:anx7625: add port@0 property"
2022-05-23 16:15 [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type" Robert Foss
@ 2022-05-23 16:15 ` Robert Foss
2022-05-23 16:17 ` [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type" Robert Foss
1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-05-23 16:15 UTC (permalink / raw)
To: andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, robh+dt, krzysztof.kozlowski+dt,
xji, hsinyi, sam, maxime, tzimmermann, jose.exposito89,
dri-devel, devicetree, linux-kernel
Cc: Daniel Vetter
This reverts commit 7328736d270aa4fa6fcd033ade02acc2874a2db5.
This patch depends on the patches just aplied to the media tree, and will
not build without them, which leaves drm-misc-next in a broken state.
Let's revert the two latter patches until rc1 has been branched,
and rc1 has been backmerged into drm-misc-next.
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
.../display/bridge/analogix,anx7625.yaml | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 4590186c4a0b..35a48515836e 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -94,22 +94,7 @@ properties:
$ref: /schemas/graph.yaml#/$defs/port-base
unevaluatedProperties: false
description:
- MIPI DSI/DPI input.
-
- properties:
- endpoint:
- $ref: /schemas/media/video-interfaces.yaml#
- type: object
- additionalProperties: false
-
- properties:
- remote-endpoint: true
-
- bus-type:
- enum: [7]
- default: 1
-
- data-lanes: true
+ Video port for MIPI DSI input.
port@1:
$ref: /schemas/graph.yaml#/properties/port
@@ -158,8 +143,6 @@ examples:
reg = <0>;
anx7625_in: endpoint {
remote-endpoint = <&mipi_dsi>;
- bus-type = <7>;
- data-lanes = <0 1 2 3>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"
2022-05-23 16:15 [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type" Robert Foss
2022-05-23 16:15 ` [PATCH v2 2/2] Revert "dt-bindings:drm/bridge:anx7625: add port@0 property" Robert Foss
@ 2022-05-23 16:17 ` Robert Foss
1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-05-23 16:17 UTC (permalink / raw)
To: andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, robh+dt, krzysztof.kozlowski+dt,
xji, hsinyi, sam, maxime, tzimmermann, jose.exposito89,
dri-devel, devicetree, linux-kernel
Cc: Daniel Vetter
On Mon, 23 May 2022 at 18:15, Robert Foss <robert.foss@linaro.org> wrote:
>
> This reverts commit a77c2af0994e24ee36c7ffb6dc852770bdf06fb1.
>
> This patch depends on the patches just aplied to the media tree, and will
> not build without them, which leaves drm-misc-next in a broken state.
> Let's revert the two latter patches until rc1 has been branched,
> and rc1 has been backmerged into drm-misc-next.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 0fab2aa47c67..e92eb4a40745 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
>
> anx7625_get_swing_setting(dev, pdata);
>
> - pdata->is_dpi = 0; /* default dsi mode */
> + pdata->is_dpi = 1; /* default dpi mode */
> pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> if (!pdata->mipi_host_node) {
> DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> return -ENODEV;
> }
>
> - bus_type = 0;
> + bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> mipi_lanes = MAX_LANES_SUPPORT;
> ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> if (ep0) {
> @@ -1641,8 +1641,8 @@ static int anx7625_parse_dt(struct device *dev,
> of_node_put(ep0);
> }
>
> - if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> - pdata->is_dpi = 1;
> + if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> + pdata->is_dpi = 0;
>
> pdata->mipi_lanes = mipi_lanes;
> if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> --
> 2.34.1
>
Series applied to drm-misc-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-23 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 16:15 [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type" Robert Foss
2022-05-23 16:15 ` [PATCH v2 2/2] Revert "dt-bindings:drm/bridge:anx7625: add port@0 property" Robert Foss
2022-05-23 16:17 ` [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type" Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.