* [PATCH] drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c
@ 2022-05-25 21:53 Fabio Estevam
2022-05-25 23:50 ` Alvin Šipraga
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2022-05-25 21:53 UTC (permalink / raw)
To: robert.foss; +Cc: kernel test robot, dri-devel, alsi
ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[]
are only used inside adv7511_cec.c.
Move their definitions to this file to avoid the following build
warnings when CONFIG_DRM_I2C_ADV7511_CEC is not selected:
drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=]
drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]
Reported-by: kernel test robot <lkp@intel.com>
Fixes: ab0af093bf90 ("drm: bridge: adv7511: use non-legacy mode for CEC RX")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------
drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index 9e3bb8a8ee40..a031a0cd1f18 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -226,18 +226,6 @@
#define ADV7511_REG_CEC_CLK_DIV 0x4e
#define ADV7511_REG_CEC_SOFT_RESET 0x50
-static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
- ADV7511_REG_CEC_RX1_FRAME_HDR,
- ADV7511_REG_CEC_RX2_FRAME_HDR,
- ADV7511_REG_CEC_RX3_FRAME_HDR,
-};
-
-static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
- ADV7511_REG_CEC_RX1_FRAME_LEN,
- ADV7511_REG_CEC_RX2_FRAME_LEN,
- ADV7511_REG_CEC_RX3_FRAME_LEN,
-};
-
#define ADV7533_REG_CEC_OFFSET 0x70
enum adv7511_input_clock {
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
index 399f625a50c8..0b266f28f150 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
@@ -15,6 +15,18 @@
#include "adv7511.h"
+static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
+ ADV7511_REG_CEC_RX1_FRAME_HDR,
+ ADV7511_REG_CEC_RX2_FRAME_HDR,
+ ADV7511_REG_CEC_RX3_FRAME_HDR,
+};
+
+static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
+ ADV7511_REG_CEC_RX1_FRAME_LEN,
+ ADV7511_REG_CEC_RX2_FRAME_LEN,
+ ADV7511_REG_CEC_RX3_FRAME_LEN,
+};
+
#define ADV7511_INT1_CEC_MASK \
(ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \
ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c
2022-05-25 21:53 [PATCH] drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c Fabio Estevam
@ 2022-05-25 23:50 ` Alvin Šipraga
2022-05-26 11:53 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Alvin Šipraga @ 2022-05-25 23:50 UTC (permalink / raw)
To: Fabio Estevam; +Cc: dri-devel, robert.foss, kernel test robot
On Wed, May 25, 2022 at 06:53:16PM -0300, Fabio Estevam wrote:
> ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[]
> are only used inside adv7511_cec.c.
>
> Move their definitions to this file to avoid the following build
> warnings when CONFIG_DRM_I2C_ADV7511_CEC is not selected:
>
> drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=]
> drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: ab0af093bf90 ("drm: bridge: adv7511: use non-legacy mode for CEC RX")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
Thank you for fixing this.
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------
> drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> index 9e3bb8a8ee40..a031a0cd1f18 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> @@ -226,18 +226,6 @@
> #define ADV7511_REG_CEC_CLK_DIV 0x4e
> #define ADV7511_REG_CEC_SOFT_RESET 0x50
>
> -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
> - ADV7511_REG_CEC_RX1_FRAME_HDR,
> - ADV7511_REG_CEC_RX2_FRAME_HDR,
> - ADV7511_REG_CEC_RX3_FRAME_HDR,
> -};
> -
> -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
> - ADV7511_REG_CEC_RX1_FRAME_LEN,
> - ADV7511_REG_CEC_RX2_FRAME_LEN,
> - ADV7511_REG_CEC_RX3_FRAME_LEN,
> -};
> -
> #define ADV7533_REG_CEC_OFFSET 0x70
>
> enum adv7511_input_clock {
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> index 399f625a50c8..0b266f28f150 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> @@ -15,6 +15,18 @@
>
> #include "adv7511.h"
>
> +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
> + ADV7511_REG_CEC_RX1_FRAME_HDR,
> + ADV7511_REG_CEC_RX2_FRAME_HDR,
> + ADV7511_REG_CEC_RX3_FRAME_HDR,
> +};
> +
> +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
> + ADV7511_REG_CEC_RX1_FRAME_LEN,
> + ADV7511_REG_CEC_RX2_FRAME_LEN,
> + ADV7511_REG_CEC_RX3_FRAME_LEN,
> +};
> +
> #define ADV7511_INT1_CEC_MASK \
> (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \
> ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c
2022-05-25 23:50 ` Alvin Šipraga
@ 2022-05-26 11:53 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-05-26 11:53 UTC (permalink / raw)
To: Alvin Šipraga; +Cc: kernel test robot, dri-devel
On Thu, 26 May 2022 at 01:50, Alvin Šipraga <ALSI@bang-olufsen.dk> wrote:
>
> On Wed, May 25, 2022 at 06:53:16PM -0300, Fabio Estevam wrote:
> > ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[]
> > are only used inside adv7511_cec.c.
> >
> > Move their definitions to this file to avoid the following build
> > warnings when CONFIG_DRM_I2C_ADV7511_CEC is not selected:
> >
> > drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=]
> > drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: ab0af093bf90 ("drm: bridge: adv7511: use non-legacy mode for CEC RX")
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
>
> Thank you for fixing this.
>
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
>
>
> > drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------
> > drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> > index 9e3bb8a8ee40..a031a0cd1f18 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> > @@ -226,18 +226,6 @@
> > #define ADV7511_REG_CEC_CLK_DIV 0x4e
> > #define ADV7511_REG_CEC_SOFT_RESET 0x50
> >
> > -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
> > - ADV7511_REG_CEC_RX1_FRAME_HDR,
> > - ADV7511_REG_CEC_RX2_FRAME_HDR,
> > - ADV7511_REG_CEC_RX3_FRAME_HDR,
> > -};
> > -
> > -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
> > - ADV7511_REG_CEC_RX1_FRAME_LEN,
> > - ADV7511_REG_CEC_RX2_FRAME_LEN,
> > - ADV7511_REG_CEC_RX3_FRAME_LEN,
> > -};
> > -
> > #define ADV7533_REG_CEC_OFFSET 0x70
> >
> > enum adv7511_input_clock {
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> > index 399f625a50c8..0b266f28f150 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> > @@ -15,6 +15,18 @@
> >
> > #include "adv7511.h"
> >
> > +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
> > + ADV7511_REG_CEC_RX1_FRAME_HDR,
> > + ADV7511_REG_CEC_RX2_FRAME_HDR,
> > + ADV7511_REG_CEC_RX3_FRAME_HDR,
> > +};
> > +
> > +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
> > + ADV7511_REG_CEC_RX1_FRAME_LEN,
> > + ADV7511_REG_CEC_RX2_FRAME_LEN,
> > + ADV7511_REG_CEC_RX3_FRAME_LEN,
> > +};
> > +
> > #define ADV7511_INT1_CEC_MASK \
> > (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \
> > ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \
> > --
> > 2.25.1
> >
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-26 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25 21:53 [PATCH] drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c Fabio Estevam
2022-05-25 23:50 ` Alvin Šipraga
2022-05-26 11:53 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.