From: Robert Foss <robert.foss@linaro.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Sam Ravnborg <sam@ravnborg.org>, Xin Ji <xji@analogixsemi.com>
Subject: Re: [PATCH v2] drm/bridge: anx7625: Fix power on delay
Date: Wed, 28 Apr 2021 17:46:43 +0200 [thread overview]
Message-ID: <CAG3jFyvg-7qxDMkoWVgaqqt7wsDSafqrp8QXvYNWRJH98XMK2g@mail.gmail.com> (raw)
In-Reply-To: <20210428115116.931328-1-hsinyi@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 1312 bytes --]
Merged.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1fcf24fb07e254ca69001ab14adc8cf567127c44
On Wed, 28 Apr 2021 at 13:51, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> From anx7625 spec, the delay between powering on power supplies and gpio
> should be larger than 10ms.
>
> Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power
> off")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> v1->v2: Extend sleep range a bit as the regulator on some device takes
> more time to be powered on after regulator_enable() is called.
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 23283ba0c4f9..b4e349ca38fe 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)
> usleep_range(2000, 2100);
> }
>
> - usleep_range(4000, 4100);
> + usleep_range(11000, 12000);
>
> /* Power on pin enable */
> gpiod_set_value(ctx->pdata.gpio_p_on, 1);
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>
>
[-- Attachment #1.2: Type: text/html, Size: 1968 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2021-04-28 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 11:51 [PATCH v2] drm/bridge: anx7625: Fix power on delay Hsin-Yi Wang
2021-04-28 11:51 ` Hsin-Yi Wang
2021-04-28 15:46 ` Robert Foss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG3jFyvg-7qxDMkoWVgaqqt7wsDSafqrp8QXvYNWRJH98XMK2g@mail.gmail.com \
--to=robert.foss@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.