[PATCH v2 1/2] drm/bridge: ti-sn65dsi83: add more dev_err_probe

[PATCH v2 1/2] drm/bridge: ti-sn65dsi83: add more dev_err_probe

[Alexander Stein]

Add more warning/debug messages during probe. E.g. a single -EPROBE_DEFER
might have several causes, these messages help finding the origin.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
* New in v2

 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index b27c0d7c451a..a306150a8027 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -677,7 +677,7 @@ static int sn65dsi83_probe(struct i2c_client *client,
 	ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable",
 						   GPIOD_OUT_LOW);
 	if (IS_ERR(ctx->enable_gpio))
-		return PTR_ERR(ctx->enable_gpio);
+		return dev_err_probe(dev, PTR_ERR(ctx->enable_gpio), "failed to get enable GPIO\n");
 
 	usleep_range(10000, 11000);
 
@@ -687,7 +687,7 @@ static int sn65dsi83_probe(struct i2c_client *client,
 
 	ctx->regmap = devm_regmap_init_i2c(client, &sn65dsi83_regmap_config);
 	if (IS_ERR(ctx->regmap))
-		return PTR_ERR(ctx->regmap);
+		return dev_err_probe(dev, PTR_ERR(ctx->regmap), "failed to get regmap\n");
 
 	dev_set_drvdata(dev, ctx);
 	i2c_set_clientdata(client, ctx);
-- 
2.25.1

[PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Allow GPIO operations to sleep

[Alexander Stein]

There is no need to require non-sleeping GPIO access. Silence the
WARN_ON() if GPIO is using e.g. I2C expanders.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Change in v2:
* None

 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index a306150a8027..dc26640e7d9b 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -344,7 +344,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge,
 	}
 
 	/* Deassert reset */
-	gpiod_set_value(ctx->enable_gpio, 1);
+	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
 	usleep_range(1000, 1100);
 
 	/* Get the LVDS format from the bridge state. */
@@ -500,7 +500,7 @@ static void sn65dsi83_atomic_disable(struct drm_bridge *bridge,
 	int ret;
 
 	/* Put the chip in reset, pull EN line low, and assure 10ms reset low timing. */
-	gpiod_set_value(ctx->enable_gpio, 0);
+	gpiod_set_value_cansleep(ctx->enable_gpio, 0);
 	usleep_range(10000, 11000);
 
 	ret = regulator_disable(ctx->vcc);
-- 
2.25.1

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi83: add more dev_err_probe

[Robert Foss]

On Tue, 14 Jun 2022 at 11:58, Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Add more warning/debug messages during probe. E.g. a single -EPROBE_DEFER
> might have several causes, these messages help finding the origin.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> * New in v2
>
>  drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index b27c0d7c451a..a306150a8027 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -677,7 +677,7 @@ static int sn65dsi83_probe(struct i2c_client *client,
>         ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable",
>                                                    GPIOD_OUT_LOW);
>         if (IS_ERR(ctx->enable_gpio))
> -               return PTR_ERR(ctx->enable_gpio);
> +               return dev_err_probe(dev, PTR_ERR(ctx->enable_gpio), "failed to get enable GPIO\n");
>
>         usleep_range(10000, 11000);
>
> @@ -687,7 +687,7 @@ static int sn65dsi83_probe(struct i2c_client *client,
>
>         ctx->regmap = devm_regmap_init_i2c(client, &sn65dsi83_regmap_config);
>         if (IS_ERR(ctx->regmap))
> -               return PTR_ERR(ctx->regmap);
> +               return dev_err_probe(dev, PTR_ERR(ctx->regmap), "failed to get regmap\n");
>
>         dev_set_drvdata(dev, ctx);
>         i2c_set_clientdata(client, ctx);
> --
> 2.25.1
>

Reviewed & applied series to drm-misc-next.

Reviewed-by: Robert Foss <robert.foss@linaro.org>