From: Parav Pandit <pandit.parav@gmail.com> To: Tejun Heo <tj@kernel.org> Cc: "Krzysztof Opasiak" <k.opasiak@samsung.com>, "Li Zefan" <lizefan@huawei.com>, "Johannes Weiner" <hannes@cmpxchg.org>, "Łukasz Stelmach" <l.stelmach@samsung.com>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Karol Lewandowski" <k.lewandowsk@samsung.com>, cgroups@vger.kernel.org Subject: Re: counting file descriptors with a cgroup controller Date: Tue, 7 Mar 2017 20:59:39 -0600 [thread overview] Message-ID: <CAG53R5VQrm-c-F8GdqJ9fx4n+=QU5n3gT-9adx4HqRO_R8BOaw@mail.gmail.com> (raw) In-Reply-To: <20170307204825.GH31179@htj.duckdns.org> Hi, On Tue, Mar 7, 2017 at 2:48 PM, Tejun Heo <tj@kernel.org> wrote: > > Hello, > > On Tue, Mar 07, 2017 at 09:06:49PM +0100, Krzysztof Opasiak wrote: > > Personally, I don't want to use rlimit for this as it ends up returning > > error code from for example open() when we hit the limit. This may lead to > > some unpredictable crashes in services (esp. those poor proprietary binary > > blobs). Instead of injecting errors to service we would like to just get > > notification that this service has more opened fds than it should and ask it > > to restart in a polite way. > > How does those poor proprietary binary blobs remain polite after restart? Do you mean you want to keep restarting them when it reaches the limit? > > For memory seems to be quite easy to achieve as we can just get eventfd > > notification when application passes given memory usage using memory cgroup > > controller. Maybe you know some efficient method to do the same for fds? > > So, if all you wanna do is reliably detecting open(2) failures, can't > you do that with bpf tracing? > > Thanks. > > -- > tejun > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "Krzysztof Opasiak" <k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, "Li Zefan" <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>, "Johannes Weiner" <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, "Łukasz Stelmach" <l.stelmach-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, "Linux Kernel Mailing List" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Karol Lewandowski" <k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: counting file descriptors with a cgroup controller Date: Tue, 7 Mar 2017 20:59:39 -0600 [thread overview] Message-ID: <CAG53R5VQrm-c-F8GdqJ9fx4n+=QU5n3gT-9adx4HqRO_R8BOaw@mail.gmail.com> (raw) In-Reply-To: <20170307204825.GH31179-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org> Hi, On Tue, Mar 7, 2017 at 2:48 PM, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > Hello, > > On Tue, Mar 07, 2017 at 09:06:49PM +0100, Krzysztof Opasiak wrote: > > Personally, I don't want to use rlimit for this as it ends up returning > > error code from for example open() when we hit the limit. This may lead to > > some unpredictable crashes in services (esp. those poor proprietary binary > > blobs). Instead of injecting errors to service we would like to just get > > notification that this service has more opened fds than it should and ask it > > to restart in a polite way. > > How does those poor proprietary binary blobs remain polite after restart? Do you mean you want to keep restarting them when it reaches the limit? > > For memory seems to be quite easy to achieve as we can just get eventfd > > notification when application passes given memory usage using memory cgroup > > controller. Maybe you know some efficient method to do the same for fds? > > So, if all you wanna do is reliably detecting open(2) failures, can't > you do that with bpf tracing? > > Thanks. > > -- > tejun > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-08 3:00 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20170217093725eucas1p12478baf297d25303f3020f4973fbf3b0@eucas1p1.samsung.com> 2017-02-17 9:37 ` counting file descriptors with a cgroup controller Łukasz Stelmach 2017-02-17 11:37 ` Krzysztof Opasiak 2017-03-06 18:58 ` Tejun Heo 2017-03-06 18:58 ` Tejun Heo 2017-03-07 11:19 ` Krzysztof Opasiak 2017-03-07 11:19 ` Krzysztof Opasiak 2017-03-07 19:41 ` Tejun Heo 2017-03-07 20:06 ` Krzysztof Opasiak 2017-03-07 20:06 ` Krzysztof Opasiak 2017-03-07 20:48 ` Tejun Heo 2017-03-07 20:48 ` Tejun Heo 2017-03-08 2:59 ` Parav Pandit [this message] 2017-03-08 2:59 ` Parav Pandit 2017-03-08 10:19 ` Krzysztof Opasiak 2017-03-08 10:19 ` Krzysztof Opasiak 2017-03-08 9:52 ` Krzysztof Opasiak 2017-03-08 18:59 ` Tejun Heo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAG53R5VQrm-c-F8GdqJ9fx4n+=QU5n3gT-9adx4HqRO_R8BOaw@mail.gmail.com' \ --to=pandit.parav@gmail.com \ --cc=cgroups@vger.kernel.org \ --cc=hannes@cmpxchg.org \ --cc=k.lewandowsk@samsung.com \ --cc=k.opasiak@samsung.com \ --cc=l.stelmach@samsung.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.