From: Caleb Crome <caleb@crome.org>
To: Mark Brown <broonie@kernel.org>
Cc: Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list
Date: Mon, 25 Apr 2016 11:31:22 -0700 [thread overview]
Message-ID: <CAG5mAdwtMBJB-5UwF+dYddvb=06JfJEexCRauAvHLYB2Ze0_AQ@mail.gmail.com> (raw)
In-Reply-To: <20160425180613.GR3217@sirena.org.uk>
On Mon, Apr 25, 2016 at 11:06 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 25, 2016 at 10:50:24AM -0700, Caleb Crome wrote:
>
>> Due to caching, SOR wasn't written when it should have been. This
>> patch simply adds SOR to the volatile list.
>
> Could you expand on when it wasn't written and why it needed to be
> please?
Yes, sorry.
The CCSR_SSI_SOR is a register that clears the TX and/or the RX fifo
on the i.MX6 SSI port. The fsl_ssi_trigger writes this register in
order to clear the fifo at trigger time.
However, since the CCSR_SSI_SOR register is not in the volatile list,
the caching mechanism prevented the register write in the trigger
function. This caused the fifo to not be cleared (because the value
was unchanged from the last time the register was written), and thus
causes the channels in both TDM or simple I2S mode to slip and be in
the wrong time slots on SSI restart.
By adding CCSR_SSI_SOR to the volatile list, along with arnaud's
patches that I just tested (and sent tested-by slugs), fix most of the
problems with the SSI port drivers for multi-channel operation (there
is one more to come that I think really fixes the last bit).
Most people never noticed the problem because with simple stereo mode,
the consequence is that left and right are swapped, which isn't that
noticeable.
I can re-submit the patch if you like with this more descriptive comment.
Thanks,
-Caleb
WARNING: multiple messages have this Message-ID (diff)
From: Caleb Crome <caleb@crome.org>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/1] ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list
Date: Mon, 25 Apr 2016 11:31:22 -0700 [thread overview]
Message-ID: <CAG5mAdwtMBJB-5UwF+dYddvb=06JfJEexCRauAvHLYB2Ze0_AQ@mail.gmail.com> (raw)
In-Reply-To: <20160425180613.GR3217@sirena.org.uk>
On Mon, Apr 25, 2016 at 11:06 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 25, 2016 at 10:50:24AM -0700, Caleb Crome wrote:
>
>> Due to caching, SOR wasn't written when it should have been. This
>> patch simply adds SOR to the volatile list.
>
> Could you expand on when it wasn't written and why it needed to be
> please?
Yes, sorry.
The CCSR_SSI_SOR is a register that clears the TX and/or the RX fifo
on the i.MX6 SSI port. The fsl_ssi_trigger writes this register in
order to clear the fifo at trigger time.
However, since the CCSR_SSI_SOR register is not in the volatile list,
the caching mechanism prevented the register write in the trigger
function. This caused the fifo to not be cleared (because the value
was unchanged from the last time the register was written), and thus
causes the channels in both TDM or simple I2S mode to slip and be in
the wrong time slots on SSI restart.
By adding CCSR_SSI_SOR to the volatile list, along with arnaud's
patches that I just tested (and sent tested-by slugs), fix most of the
problems with the SSI port drivers for multi-channel operation (there
is one more to come that I think really fixes the last bit).
Most people never noticed the problem because with simple stereo mode,
the consequence is that left and right are swapped, which isn't that
noticeable.
I can re-submit the patch if you like with this more descriptive comment.
Thanks,
-Caleb
next prev parent reply other threads:[~2016-04-25 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 17:50 [PATCH 1/1] ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list Caleb Crome
2016-04-25 18:06 ` Mark Brown
2016-04-25 18:06 ` Mark Brown
2016-04-25 18:31 ` Caleb Crome [this message]
2016-04-25 18:31 ` Caleb Crome
2016-04-29 10:46 ` Applied "ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list" to the asoc tree Mark Brown
2016-04-29 10:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG5mAdwtMBJB-5UwF+dYddvb=06JfJEexCRauAvHLYB2Ze0_AQ@mail.gmail.com' \
--to=caleb@crome.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.