All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moni Shoua <monis@mellanox.com>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: yuval.shaia@oracle.com, Sean Hefty <sean.hefty@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Leon Romanovsky <leon@kernel.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3] rxe: Fix a sleep-in-atomic bug in post_one_send
Date: Mon, 5 Jun 2017 11:30:14 +0300	[thread overview]
Message-ID: <CAG9sBKNKTT8ceHrXRhLRns53ejH0kwaLMy-qAzdmo=Hy5h02Yw@mail.gmail.com> (raw)
In-Reply-To: <1496648342-906-1-git-send-email-baijiaju1990@163.com>

> -                       if (qp->is_user && copy_from_user(p, (__user void *)
> -                                           (uintptr_t)sge->addr, sge->length))
> +                       spin_unlock_irqrestore(&qp->sq.sq_lock, *flags);
> +                       err = copy_from_user(p, (__user void *)
> +                                       (uintptr_t)sge->addr, sge->length);
> +                       spin_lock_irqsave(&qp->sq.sq_lock, *flags);
> +                       if (qp->is_user && err)
>                                 return -EFAULT;
qp-_is_user is always false in this function (flow starts from
rxe_post_send_kernel) so this line is a dead code
In fact, this patch seems to add a serious bug when it uses
copy_from_user() from a non user pointer.
Do you agree?

  parent reply	other threads:[~2017-06-05  8:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05  7:39 [PATCH V3] rxe: Fix a sleep-in-atomic bug in post_one_send Jia-Ju Bai
2017-06-05  7:39 ` Jia-Ju Bai
     [not found] ` <1496648342-906-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
2017-06-05  7:44   ` Yuval Shaia
2017-06-05  7:44     ` Yuval Shaia
2017-06-05  8:30 ` Moni Shoua [this message]
     [not found]   ` <CAG9sBKNKTT8ceHrXRhLRns53ejH0kwaLMy-qAzdmo=Hy5h02Yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-05  8:40     ` Jia-Ju Bai
2017-06-05  8:40       ` Jia-Ju Bai
2017-06-05  9:21       ` Moni Shoua
  -- strict thread matches above, loose matches on Subject: below --
2017-06-05  7:55 Jia-Ju Bai
2017-06-01  8:28 Jia-Ju Bai
2017-06-01  8:28 ` Jia-Ju Bai
     [not found] ` <1496305735-21741-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
2017-06-01  9:32   ` Moni Shoua
2017-06-01  9:32     ` Moni Shoua
2017-06-05  6:57   ` Yuval Shaia
2017-06-05  6:57     ` Yuval Shaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG9sBKNKTT8ceHrXRhLRns53ejH0kwaLMy-qAzdmo=Hy5h02Yw@mail.gmail.com' \
    --to=monis@mellanox.com \
    --cc=baijiaju1990@163.com \
    --cc=dledford@redhat.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.