From: Jia-Ju Bai <baijiaju1990-9Onoh4P/yGk@public.gmane.org> To: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Cc: yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Kernel Mailinglist <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH V3] rxe: Fix a sleep-in-atomic bug in post_one_send Date: Mon, 05 Jun 2017 16:40:47 +0800 [thread overview] Message-ID: <5935190F.7090708@163.com> (raw) In-Reply-To: <CAG9sBKNKTT8ceHrXRhLRns53ejH0kwaLMy-qAzdmo=Hy5h02Yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On 06/05/2017 04:30 PM, Moni Shoua wrote: >> - if (qp->is_user&& copy_from_user(p, (__user void *) >> - (uintptr_t)sge->addr, sge->length)) >> + spin_unlock_irqrestore(&qp->sq.sq_lock, *flags); >> + err = copy_from_user(p, (__user void *) >> + (uintptr_t)sge->addr, sge->length); >> + spin_lock_irqsave(&qp->sq.sq_lock, *flags); >> + if (qp->is_user&& err) >> return -EFAULT; > qp-_is_user is always false in this function (flow starts from > rxe_post_send_kernel) so this line is a dead code > In fact, this patch seems to add a serious bug when it uses > copy_from_user() from a non user pointer. > Do you agree? I agree. So, it is fine to me to remove this line, as you said in the former email: > Second, I think that there is no flow that leads to this function > when qp->is user is true so maybe the correct action is to remove this > line completely > if (qp->is_user&& copy_from_user(p, (__user void *) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jia-Ju Bai <baijiaju1990@163.com> To: Moni Shoua <monis@mellanox.com> Cc: yuval.shaia@oracle.com, Sean Hefty <sean.hefty@intel.com>, Doug Ledford <dledford@redhat.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Leon Romanovsky <leon@kernel.org>, linux-rdma <linux-rdma@vger.kernel.org>, Linux Kernel Mailinglist <linux-kernel@vger.kernel.org> Subject: Re: [PATCH V3] rxe: Fix a sleep-in-atomic bug in post_one_send Date: Mon, 05 Jun 2017 16:40:47 +0800 [thread overview] Message-ID: <5935190F.7090708@163.com> (raw) In-Reply-To: <CAG9sBKNKTT8ceHrXRhLRns53ejH0kwaLMy-qAzdmo=Hy5h02Yw@mail.gmail.com> On 06/05/2017 04:30 PM, Moni Shoua wrote: >> - if (qp->is_user&& copy_from_user(p, (__user void *) >> - (uintptr_t)sge->addr, sge->length)) >> + spin_unlock_irqrestore(&qp->sq.sq_lock, *flags); >> + err = copy_from_user(p, (__user void *) >> + (uintptr_t)sge->addr, sge->length); >> + spin_lock_irqsave(&qp->sq.sq_lock, *flags); >> + if (qp->is_user&& err) >> return -EFAULT; > qp-_is_user is always false in this function (flow starts from > rxe_post_send_kernel) so this line is a dead code > In fact, this patch seems to add a serious bug when it uses > copy_from_user() from a non user pointer. > Do you agree? I agree. So, it is fine to me to remove this line, as you said in the former email: > Second, I think that there is no flow that leads to this function > when qp->is user is true so maybe the correct action is to remove this > line completely > if (qp->is_user&& copy_from_user(p, (__user void *)
next prev parent reply other threads:[~2017-06-05 8:40 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-05 7:39 [PATCH V3] rxe: Fix a sleep-in-atomic bug in post_one_send Jia-Ju Bai 2017-06-05 7:39 ` Jia-Ju Bai [not found] ` <1496648342-906-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org> 2017-06-05 7:44 ` Yuval Shaia 2017-06-05 7:44 ` Yuval Shaia 2017-06-05 8:30 ` Moni Shoua [not found] ` <CAG9sBKNKTT8ceHrXRhLRns53ejH0kwaLMy-qAzdmo=Hy5h02Yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-06-05 8:40 ` Jia-Ju Bai [this message] 2017-06-05 8:40 ` Jia-Ju Bai 2017-06-05 9:21 ` Moni Shoua -- strict thread matches above, loose matches on Subject: below -- 2017-06-05 7:55 Jia-Ju Bai 2017-06-01 8:28 Jia-Ju Bai 2017-06-01 8:28 ` Jia-Ju Bai [not found] ` <1496305735-21741-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org> 2017-06-01 9:32 ` Moni Shoua 2017-06-01 9:32 ` Moni Shoua 2017-06-05 6:57 ` Yuval Shaia 2017-06-05 6:57 ` Yuval Shaia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5935190F.7090708@163.com \ --to=baijiaju1990-9onoh4p/ygk@public.gmane.org \ --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.