From: Moni Shoua <monis@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma <linux-rdma@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] IB/rxe: Remove unneeded cast in rxe_srq_from_attr()
Date: Thu, 17 Nov 2016 15:51:17 +0200 [thread overview]
Message-ID: <CAG9sBKO3HzYV1w1=0oOEOGd8O3M6AUTTJpRY63YoeVjAOHUifw@mail.gmail.com> (raw)
In-Reply-To: <20161117110005.GB32143@mwanda>
On Thu, Nov 17, 2016 at 1:00 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> It makes me nervous when we cast pointer parameters. I would estimate
> that around 50% of the time, it indicates a bug. Here the cast is not
> needed becaue u32 and and unsigned int are the same thing. Removing the
> cast makes the code more robust and future proof in case any of the
> types change.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moni Shoua <monis@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Moni Shoua <monis@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma <linux-rdma@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] IB/rxe: Remove unneeded cast in rxe_srq_from_attr()
Date: Thu, 17 Nov 2016 13:51:17 +0000 [thread overview]
Message-ID: <CAG9sBKO3HzYV1w1=0oOEOGd8O3M6AUTTJpRY63YoeVjAOHUifw@mail.gmail.com> (raw)
In-Reply-To: <20161117110005.GB32143@mwanda>
On Thu, Nov 17, 2016 at 1:00 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> It makes me nervous when we cast pointer parameters. I would estimate
> that around 50% of the time, it indicates a bug. Here the cast is not
> needed becaue u32 and and unsigned int are the same thing. Removing the
> cast makes the code more robust and future proof in case any of the
> types change.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moni Shoua <monis@mellanox.com>
next prev parent reply other threads:[~2016-11-17 13:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 11:00 [patch] IB/rxe: Remove unneeded cast in rxe_srq_from_attr() Dan Carpenter
2016-11-17 11:00 ` Dan Carpenter
2016-11-17 11:49 ` Leon Romanovsky
2016-11-17 11:49 ` Leon Romanovsky
2016-11-17 12:16 ` Yuval Shaia
2016-11-17 12:16 ` Yuval Shaia
[not found] ` <20161117121554.GA4292-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-11-17 16:38 ` Yuval Shaia
2016-11-17 16:38 ` Yuval Shaia
2016-11-17 13:51 ` Moni Shoua [this message]
2016-11-17 13:51 ` Moni Shoua
2016-12-12 21:37 ` Doug Ledford
2016-12-12 21:37 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG9sBKO3HzYV1w1=0oOEOGd8O3M6AUTTJpRY63YoeVjAOHUifw@mail.gmail.com' \
--to=monis@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.