[PATCH] tpm: Fix tpm init with no ACPI entry

[PATCH] tpm: Fix tpm init with no ACPI entry

[Derek Basehore]

tpm_add_ppi fails without ACPI support now, but loading the tpm without an ACPI
entry is a valid use case. This changes the init of the tpm to not fail when
tpm_add_ppi fails.

Signed-off-by: Derek Basehore <dbasehore@chromium.org>
---
 drivers/char/tpm/tpm-interface.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index 62e10fd..8bfa339 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -1094,8 +1094,7 @@ struct tpm_chip *tpm_register_hardware(struct device *dev,
 	if (tpm_sysfs_add_device(chip))
 		goto del_misc;
 
-	if (tpm_add_ppi(&dev->kobj))
-		goto del_misc;
+	tpm_add_ppi(&dev->kobj);
 
 	chip->bios_dir = tpm_bios_log_setup(chip->devname);
 
-- 
1.9.1.423.g4596e3a

Re: [PATCH] tpm: Fix tpm init with no ACPI entry

[Peter Huewe]

Hi Derek,
Is this a regression?
Do you know since when?
Thanks
Peter
---
Sent from my mobile.

Re: [PATCH] tpm: Fix tpm init with no ACPI entry

[dbasehore .]

This is a regression introduced in "ACPI / TPM: match node name
instead of full path when searching for TPM device" which was authored
on December 19, 2013.

On Wed, May 7, 2014 at 11:09 PM, Peter Huewe <peterhuewe@gmx.de> wrote:
> Hi Derek,
> Is this a regression?
> Do you know since when?
> Thanks
> Peter
> ---
> Sent from my mobile.