* [cip-dev] [PATCH 0/2] Add PMU support to iwg2[02]m
@ 2018-10-15 10:23 Patryk Mungai
2018-10-15 10:23 ` [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node Patryk Mungai
2018-10-15 10:23 ` [cip-dev] [PATCH 2/2] ARM: dts: r8a7743: " Patryk Mungai
0 siblings, 2 replies; 11+ messages in thread
From: Patryk Mungai @ 2018-10-15 10:23 UTC (permalink / raw)
To: cip-dev
Backport PMU support for iwg2[02]m to the CIP Kernel from mainline.
Geert Uytterhoeven (2):
ARM: dts: r8a7745: Add PMU device node
ARM: dts: r8a7743: Add PMU device node
arch/arm/boot/dts/r8a7743.dtsi | 7 +++++++
arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
2 files changed, 14 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-15 10:23 [cip-dev] [PATCH 0/2] Add PMU support to iwg2[02]m Patryk Mungai
@ 2018-10-15 10:23 ` Patryk Mungai
2018-10-21 7:49 ` SZ Lin (林上智)
2018-10-15 10:23 ` [cip-dev] [PATCH 2/2] ARM: dts: r8a7743: " Patryk Mungai
1 sibling, 1 reply; 11+ messages in thread
From: Patryk Mungai @ 2018-10-15 10:23 UTC (permalink / raw)
To: cip-dev
From: Geert Uytterhoeven <geert+renesas@glider.be>
Commit 9562a6b1d0f6a287f5dda16a4538526c59408927 upstream.
Enable support for the ARM Performance Monitor Units in the Cortex-A7
CPU cores on RZ/G1E by adding a device node for the PMU.
New Linux output:
hw perfevents: enabled with armv7_cortex_a7 PMU driver, 5 counters available
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[Backport to CIP]
Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 69b383c..54b556b 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -93,6 +93,13 @@
};
};
+ pmu {
+ compatible = "arm,cortex-a7-pmu";
+ interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
+ <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-affinity = <&cpu0>, <&cpu1>;
+ };
+
soc {
compatible = "simple-bus";
interrupt-parent = <&gic>;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 2/2] ARM: dts: r8a7743: Add PMU device node
2018-10-15 10:23 [cip-dev] [PATCH 0/2] Add PMU support to iwg2[02]m Patryk Mungai
2018-10-15 10:23 ` [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node Patryk Mungai
@ 2018-10-15 10:23 ` Patryk Mungai
2018-10-21 7:50 ` SZ Lin (林上智)
1 sibling, 1 reply; 11+ messages in thread
From: Patryk Mungai @ 2018-10-15 10:23 UTC (permalink / raw)
To: cip-dev
From: Geert Uytterhoeven <geert+renesas@glider.be>
Commit fe60e933b053f00e53cd01fe323f25ebe8fecd52 upstream.
Enable support for the ARM Performance Monitor Units in the Cortex-A15
CPU cores on RZ/G1M by adding a device node for the PMU.
New Linux output:
hw perfevents: enabled with armv7_cortex_a15 PMU driver, 7 counters available
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[Backport to CIP]
Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index c78de96..264c8e0 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -76,6 +76,13 @@
};
};
+ pmu {
+ compatible = "arm,cortex-a15-pmu";
+ interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <&gic GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-affinity = <&cpu0>, <&cpu1>;
+ };
+
soc {
compatible = "simple-bus";
interrupt-parent = <&gic>;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-15 10:23 ` [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node Patryk Mungai
@ 2018-10-21 7:49 ` SZ Lin (林上智)
2018-10-21 8:05 ` 岩松信洋
0 siblings, 1 reply; 11+ messages in thread
From: SZ Lin (林上智) @ 2018-10-21 7:49 UTC (permalink / raw)
To: cip-dev
Hi,
>
> [Backport to CIP]
I suggest to address what you've modified from the upstream patch, it
would be helpful for maintainer's review task.
For example: [Context changes]
Just my two cents.
> Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
> index 69b383c..54b556b 100644
> --- a/arch/arm/boot/dts/r8a7745.dtsi
> +++ b/arch/arm/boot/dts/r8a7745.dtsi
> @@ -93,6 +93,13 @@
> };
> };
>
> + pmu {
> + compatible = "arm,cortex-a7-pmu";
> + interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
> + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>, <&cpu1>;
> + };
> +
> soc {
> compatible = "simple-bus";
> interrupt-parent = <&gic>;
> --
> 2.7.4
>
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 2/2] ARM: dts: r8a7743: Add PMU device node
2018-10-15 10:23 ` [cip-dev] [PATCH 2/2] ARM: dts: r8a7743: " Patryk Mungai
@ 2018-10-21 7:50 ` SZ Lin (林上智)
0 siblings, 0 replies; 11+ messages in thread
From: SZ Lin (林上智) @ 2018-10-21 7:50 UTC (permalink / raw)
To: cip-dev
Hi,
> [Backport to CIP]
Ditto.
> Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> arch/arm/boot/dts/r8a7743.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index c78de96..264c8e0 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -76,6 +76,13 @@
> };
> };
>
> + pmu {
> + compatible = "arm,cortex-a15-pmu";
> + interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> + <&gic GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>, <&cpu1>;
> + };
> +
> soc {
> compatible = "simple-bus";
> interrupt-parent = <&gic>;
> --
> 2.7.4
>
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-21 7:49 ` SZ Lin (林上智)
@ 2018-10-21 8:05 ` 岩松信洋
2018-10-21 16:40 ` Chris Paterson
0 siblings, 1 reply; 11+ messages in thread
From: 岩松信洋 @ 2018-10-21 8:05 UTC (permalink / raw)
To: cip-dev
Hi,
2018?10?21?(?) 16:49 SZ Lin (???) <sz.lin@moxa.com>:
>
> Hi,
>
> >
> > [Backport to CIP]
>
> I suggest to address what you've modified from the upstream patch, it
> would be helpful for maintainer's review task.
>
> For example: [Context changes]
>
I think so, too.
Patryk, could you please post with changes?
> Just my two cents.
Best regards,
Nobuhiro
>
> > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > ---
> > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
> > index 69b383c..54b556b 100644
> > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > @@ -93,6 +93,13 @@
> > };
> > };
> >
> > + pmu {
> > + compatible = "arm,cortex-a7-pmu";
> > + interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
> > + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > soc {
> > compatible = "simple-bus";
> > interrupt-parent = <&gic>;
> > --
> > 2.7.4
> >
> > _______________________________________________
> > cip-dev mailing list
> > cip-dev at lists.cip-project.org
> > https://lists.cip-project.org/mailman/listinfo/cip-dev
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-21 8:05 ` 岩松信洋
@ 2018-10-21 16:40 ` Chris Paterson
2018-10-22 6:53 ` SZ Lin (林上智)
0 siblings, 1 reply; 11+ messages in thread
From: Chris Paterson @ 2018-10-21 16:40 UTC (permalink / raw)
To: cip-dev
Hello SZ, Nobuhiro-san,
> From: cip-dev-bounces at lists.cip-project.org <cip-dev-bounces@lists.cip-
> project.org> On Behalf Of ????
> Sent: 21 October 2018 09:06
>
> Hi,
>
> 2018?10?21?(?) 16:49 SZ Lin (???) <sz.lin@moxa.com>:
> >
> > Hi,
> >
> > >
> > > [Backport to CIP]
> >
> > I suggest to address what you've modified from the upstream patch, it
> > would be helpful for maintainer's review task.
> >
> > For example: [Context changes]
> >
>
> I think so, too.
Me too, however for the patches in this series the changes are actually identical to the upstream commits.
The intention of [Backport to CIP] was just to split the signed-off tags between upstream and backport committers, as we moved the cherry-picked commit ID to the top of the patch.
Kind regards, Chris
> Patryk, could you please post with changes?
>
> > Just my two cents.
>
> Best regards,
> Nobuhiro
>
> >
> > > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
> > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > ---
> > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644
> > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > @@ -93,6 +93,13 @@
> > > };
> > > };
> > >
> > > + pmu {
> > > + compatible = "arm,cortex-a7-pmu";
> > > + interrupts-extended = <&gic GIC_SPI 82
> IRQ_TYPE_LEVEL_HIGH>,
> > > + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > > + };
> > > +
> > > soc {
> > > compatible = "simple-bus";
> > > interrupt-parent = <&gic>;
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > cip-dev mailing list
> > > cip-dev at lists.cip-project.org
> > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > _______________________________________________
> > cip-dev mailing list
> > cip-dev at lists.cip-project.org
> > https://lists.cip-project.org/mailman/listinfo/cip-dev
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-21 16:40 ` Chris Paterson
@ 2018-10-22 6:53 ` SZ Lin (林上智)
2018-10-22 15:42 ` Patryk Mungai Ndungu
0 siblings, 1 reply; 11+ messages in thread
From: SZ Lin (林上智) @ 2018-10-22 6:53 UTC (permalink / raw)
To: cip-dev
Hi,
> Me too, however for the patches in this series the changes are actually identical to the
> upstream commits.
>
> The intention of [Backport to CIP] was just to split the signed-off tags between upstream
> and backport committers, as we moved the cherry-picked commit ID to the top of the
> patch.
According to the guide of submitting patches [1] - "the line between the last Signed-off-by header and yours, indicating
the nature of your changes", I think it is unnecessary to add this comment in this case. Furthermore, it doesn't need to split
signed-off tags between upstream and backport committers in stable kernel [2].
Nevertheless, we can define our policy here if we decided to add this line for each CIP patches.
[1] https://www.kernel.org/doc/html/v4.18/process/submitting-patches.html
[2] https://lkml.org/lkml/2018/10/16/595
SZ
>
> Kind regards, Chris
>
> > Patryk, could you please post with changes?
> >
> > > Just my two cents.
> >
> > Best regards,
> > Nobuhiro
> >
> > >
> > > > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > ---
> > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644
> > > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > > @@ -93,6 +93,13 @@
> > > > };
> > > > };
> > > >
> > > > + pmu {
> > > > + compatible = "arm,cortex-a7-pmu";
> > > > + interrupts-extended = <&gic GIC_SPI 82
> > IRQ_TYPE_LEVEL_HIGH>,
> > > > + <&gic GIC_SPI 83
> IRQ_TYPE_LEVEL_HIGH>;
> > > > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > > > + };
> > > > +
> > > > soc {
> > > > compatible = "simple-bus";
> > > > interrupt-parent = <&gic>;
> > > > --
> > > > 2.7.4
> > > >
> > > > _______________________________________________
> > > > cip-dev mailing list
> > > > cip-dev at lists.cip-project.org
> > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > _______________________________________________
> > > cip-dev mailing list
> > > cip-dev at lists.cip-project.org
> > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > _______________________________________________
> > cip-dev mailing list
> > cip-dev at lists.cip-project.org
> > https://lists.cip-project.org/mailman/listinfo/cip-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-22 6:53 ` SZ Lin (林上智)
@ 2018-10-22 15:42 ` Patryk Mungai Ndungu
2018-10-23 13:23 ` 岩松信洋
0 siblings, 1 reply; 11+ messages in thread
From: Patryk Mungai Ndungu @ 2018-10-22 15:42 UTC (permalink / raw)
To: cip-dev
Hello Nobuhiro-san,
In light of all the previous comments, would you like me to change the [Backported to CIP] tag to describe the changes of the patch, or to get rid of it altogether before I send the patch?
Kind Regards,
Patryk
> -----Original Message-----
> From: cip-dev-bounces at lists.cip-project.org <cip-dev-bounces@lists.cip-
> project.org> On Behalf Of SZ Lin (???)
> Sent: 22 October 2018 07:53
> To: Chris Paterson <Chris.Paterson2@renesas.com>; ????
> <nobuhiro.iwamatsu@miraclelinux.com>
> Cc: cip-dev at lists.cip-project.org
> Subject: Re: [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
>
> Hi,
>
> > Me too, however for the patches in this series the changes are
> > actually identical to the upstream commits.
> >
> > The intention of [Backport to CIP] was just to split the signed-off
> > tags between upstream and backport committers, as we moved the
> > cherry-picked commit ID to the top of the patch.
>
> According to the guide of submitting patches [1] - "the line between the last
> Signed-off-by header and yours, indicating the nature of your changes", I
> think it is unnecessary to add this comment in this case. Furthermore, it
> doesn't need to split signed-off tags between upstream and backport
> committers in stable kernel [2].
>
> Nevertheless, we can define our policy here if we decided to add this line for
> each CIP patches.
>
> [1] https://www.kernel.org/doc/html/v4.18/process/submitting-
> patches.html
> [2] https://lkml.org/lkml/2018/10/16/595
>
> SZ
>
> >
> > Kind regards, Chris
> >
> > > Patryk, could you please post with changes?
> > >
> > > > Just my two cents.
> > >
> > > Best regards,
> > > Nobuhiro
> > >
> > > >
> > > > > Signed-off-by: Patryk Mungai
> > > > > <patryk.mungai-ndungu.kx@renesas.com>
> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > ---
> > > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> > > > > 1 file changed, 7 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644
> > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > > > @@ -93,6 +93,13 @@
> > > > > };
> > > > > };
> > > > >
> > > > > + pmu {
> > > > > + compatible = "arm,cortex-a7-pmu";
> > > > > + interrupts-extended = <&gic GIC_SPI 82
> > > IRQ_TYPE_LEVEL_HIGH>,
> > > > > + <&gic GIC_SPI 83
> > IRQ_TYPE_LEVEL_HIGH>;
> > > > > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > > > > + };
> > > > > +
> > > > > soc {
> > > > > compatible = "simple-bus";
> > > > > interrupt-parent = <&gic>;
> > > > > --
> > > > > 2.7.4
> > > > >
> > > > > _______________________________________________
> > > > > cip-dev mailing list
> > > > > cip-dev at lists.cip-project.org
> > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > > _______________________________________________
> > > > cip-dev mailing list
> > > > cip-dev at lists.cip-project.org
> > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > _______________________________________________
> > > cip-dev mailing list
> > > cip-dev at lists.cip-project.org
> > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-22 15:42 ` Patryk Mungai Ndungu
@ 2018-10-23 13:23 ` 岩松信洋
0 siblings, 0 replies; 11+ messages in thread
From: 岩松信洋 @ 2018-10-23 13:23 UTC (permalink / raw)
To: cip-dev
Hi, Patryk.
These patches has not changed from upstream commit.
So Could you resend the patch with [Backport to CIP] removed?
And if the patch has been modified from the upstream patch, please add the
[Backport to CIP] tag and the changes as before.
Best regards,
Nobuhiro
2018?10?23?(?) 0:42 Patryk Mungai Ndungu <patryk.mungai-ndungu.kx@renesas.com>:
>
> Hello Nobuhiro-san,
>
> In light of all the previous comments, would you like me to change the [Backported to CIP] tag to describe the changes of the patch, or to get rid of it altogether before I send the patch?
>
> Kind Regards,
>
> Patryk
>
>
>
> > -----Original Message-----
> > From: cip-dev-bounces at lists.cip-project.org <cip-dev-bounces@lists.cip-
> > project.org> On Behalf Of SZ Lin (???)
> > Sent: 22 October 2018 07:53
> > To: Chris Paterson <Chris.Paterson2@renesas.com>; ????
> > <nobuhiro.iwamatsu@miraclelinux.com>
> > Cc: cip-dev at lists.cip-project.org
> > Subject: Re: [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
> >
> > Hi,
> >
> > > Me too, however for the patches in this series the changes are
> > > actually identical to the upstream commits.
> > >
> > > The intention of [Backport to CIP] was just to split the signed-off
> > > tags between upstream and backport committers, as we moved the
> > > cherry-picked commit ID to the top of the patch.
> >
> > According to the guide of submitting patches [1] - "the line between the last
> > Signed-off-by header and yours, indicating the nature of your changes", I
> > think it is unnecessary to add this comment in this case. Furthermore, it
> > doesn't need to split signed-off tags between upstream and backport
> > committers in stable kernel [2].
> >
> > Nevertheless, we can define our policy here if we decided to add this line for
> > each CIP patches.
> >
> > [1] https://www.kernel.org/doc/html/v4.18/process/submitting-
> > patches.html
> > [2] https://lkml.org/lkml/2018/10/16/595
> >
> > SZ
> >
> > >
> > > Kind regards, Chris
> > >
> > > > Patryk, could you please post with changes?
> > > >
> > > > > Just my two cents.
> > > >
> > > > Best regards,
> > > > Nobuhiro
> > > >
> > > > >
> > > > > > Signed-off-by: Patryk Mungai
> > > > > > <patryk.mungai-ndungu.kx@renesas.com>
> > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > > ---
> > > > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> > > > > > 1 file changed, 7 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > > > > @@ -93,6 +93,13 @@
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > + pmu {
> > > > > > + compatible = "arm,cortex-a7-pmu";
> > > > > > + interrupts-extended = <&gic GIC_SPI 82
> > > > IRQ_TYPE_LEVEL_HIGH>,
> > > > > > + <&gic GIC_SPI 83
> > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > > > > > + };
> > > > > > +
> > > > > > soc {
> > > > > > compatible = "simple-bus";
> > > > > > interrupt-parent = <&gic>;
> > > > > > --
> > > > > > 2.7.4
> > > > > >
> > > > > > _______________________________________________
> > > > > > cip-dev mailing list
> > > > > > cip-dev at lists.cip-project.org
> > > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > > > _______________________________________________
> > > > > cip-dev mailing list
> > > > > cip-dev at lists.cip-project.org
> > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > > _______________________________________________
> > > > cip-dev mailing list
> > > > cip-dev at lists.cip-project.org
> > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > _______________________________________________
> > cip-dev mailing list
> > cip-dev at lists.cip-project.org
> > https://lists.cip-project.org/mailman/listinfo/cip-dev
>
>
>
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
2018-10-23 14:30 [cip-dev] [PATCH 0/2] Add PMU support to iwg2[02]m Patryk Mungai
@ 2018-10-23 14:30 ` Patryk Mungai
0 siblings, 0 replies; 11+ messages in thread
From: Patryk Mungai @ 2018-10-23 14:30 UTC (permalink / raw)
To: cip-dev
From: Geert Uytterhoeven <geert+renesas@glider.be>
Commit 9562a6b1d0f6a287f5dda16a4538526c59408927 upstream.
Enable support for the ARM Performance Monitor Units in the Cortex-A7
CPU cores on RZ/G1E by adding a device node for the PMU.
New Linux output:
hw perfevents: enabled with armv7_cortex_a7 PMU driver, 5 counters available
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 69b383c..54b556b 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -93,6 +93,13 @@
};
};
+ pmu {
+ compatible = "arm,cortex-a7-pmu";
+ interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
+ <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-affinity = <&cpu0>, <&cpu1>;
+ };
+
soc {
compatible = "simple-bus";
interrupt-parent = <&gic>;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-10-23 14:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15 10:23 [cip-dev] [PATCH 0/2] Add PMU support to iwg2[02]m Patryk Mungai
2018-10-15 10:23 ` [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node Patryk Mungai
2018-10-21 7:49 ` SZ Lin (林上智)
2018-10-21 8:05 ` 岩松信洋
2018-10-21 16:40 ` Chris Paterson
2018-10-22 6:53 ` SZ Lin (林上智)
2018-10-22 15:42 ` Patryk Mungai Ndungu
2018-10-23 13:23 ` 岩松信洋
2018-10-15 10:23 ` [cip-dev] [PATCH 2/2] ARM: dts: r8a7743: " Patryk Mungai
2018-10-21 7:50 ` SZ Lin (林上智)
2018-10-23 14:30 [cip-dev] [PATCH 0/2] Add PMU support to iwg2[02]m Patryk Mungai
2018-10-23 14:30 ` [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node Patryk Mungai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.