device link patches on 4.19.99 breaks functionality

device link patches on 4.19.99 breaks functionality

[Saravana Kannan]

4.19.99 seems to have picked up quite a few device link patches.
However, one of them [1] broke the ability to add stateful and
stateless links between the same two devices. Looks like the breakage
was fixed in the mainline kernel in subsequent commits [2] and [3].

Can we pull [2] and [3] into 4.19 please? And any other intermediate
device link patches up to [3].

[1] - 6fdc440366f1a99f344b629ac92f350aefd77911
[2] - 515db266a9da
[3] - fb583c8eeeb1 (this fixed a bug in [2])

Thanks,
Saravana

Re: device link patches on 4.19.99 breaks functionality

[Greg KH]

On Fri, Feb 21, 2020 at 01:21:00AM -0800, Saravana Kannan wrote:
> 4.19.99 seems to have picked up quite a few device link patches.
> However, one of them [1] broke the ability to add stateful and
> stateless links between the same two devices. Looks like the breakage
> was fixed in the mainline kernel in subsequent commits [2] and [3].
> 
> Can we pull [2] and [3] into 4.19 please? And any other intermediate
> device link patches up to [3].
> 
> [1] - 6fdc440366f1a99f344b629ac92f350aefd77911
> [2] - 515db266a9da
> [3] - fb583c8eeeb1 (this fixed a bug in [2])

"up to"?

515db266a9da does not apply to 4.19, so should I just drop [1] instead?

Or, can you provided a backported set of patches so I know exactly what
to apply?

thanks,

greg k-h

Re: device link patches on 4.19.99 breaks functionality

[Saravana Kannan]

On Thu, Feb 27, 2020 at 1:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Feb 21, 2020 at 01:21:00AM -0800, Saravana Kannan wrote:
> > 4.19.99 seems to have picked up quite a few device link patches.
> > However, one of them [1] broke the ability to add stateful and
> > stateless links between the same two devices. Looks like the breakage
> > was fixed in the mainline kernel in subsequent commits [2] and [3].
> >
> > Can we pull [2] and [3] into 4.19 please? And any other intermediate
> > device link patches up to [3].
> >
> > [1] - 6fdc440366f1a99f344b629ac92f350aefd77911
> > [2] - 515db266a9da
> > [3] - fb583c8eeeb1 (this fixed a bug in [2])
>
> "up to"?
>
> 515db266a9da does not apply to 4.19, so should I just drop [1] instead?
>
> Or, can you provided a backported set of patches so I know exactly what
> to apply?

Let me take a stab at backporting [2] and [3] or whatever else might
be necessary. What git repo/branch did you want me to try that on?

-Saravana

Re: device link patches on 4.19.99 breaks functionality

[Saravana Kannan]

On Thu, Feb 27, 2020 at 1:26 PM Saravana Kannan <saravanak@google.com> wrote:
>
> On Thu, Feb 27, 2020 at 1:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Feb 21, 2020 at 01:21:00AM -0800, Saravana Kannan wrote:
> > > 4.19.99 seems to have picked up quite a few device link patches.
> > > However, one of them [1] broke the ability to add stateful and
> > > stateless links between the same two devices. Looks like the breakage
> > > was fixed in the mainline kernel in subsequent commits [2] and [3].
> > >
> > > Can we pull [2] and [3] into 4.19 please? And any other intermediate
> > > device link patches up to [3].
> > >
> > > [1] - 6fdc440366f1a99f344b629ac92f350aefd77911
> > > [2] - 515db266a9da
> > > [3] - fb583c8eeeb1 (this fixed a bug in [2])
> >
> > "up to"?
> >
> > 515db266a9da does not apply to 4.19, so should I just drop [1] instead?
> >
> > Or, can you provided a backported set of patches so I know exactly what
> > to apply?
>
> Let me take a stab at backporting [2] and [3] or whatever else might
> be necessary. What git repo/branch did you want me to try that on?

I'm assuming this one:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=linux-4.19.y

-Saravana

Re: device link patches on 4.19.99 breaks functionality

[Greg KH]

On Thu, Feb 27, 2020 at 02:17:38PM -0800, Saravana Kannan wrote:
> On Thu, Feb 27, 2020 at 1:26 PM Saravana Kannan <saravanak@google.com> wrote:
> >
> > On Thu, Feb 27, 2020 at 1:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Feb 21, 2020 at 01:21:00AM -0800, Saravana Kannan wrote:
> > > > 4.19.99 seems to have picked up quite a few device link patches.
> > > > However, one of them [1] broke the ability to add stateful and
> > > > stateless links between the same two devices. Looks like the breakage
> > > > was fixed in the mainline kernel in subsequent commits [2] and [3].
> > > >
> > > > Can we pull [2] and [3] into 4.19 please? And any other intermediate
> > > > device link patches up to [3].
> > > >
> > > > [1] - 6fdc440366f1a99f344b629ac92f350aefd77911
> > > > [2] - 515db266a9da
> > > > [3] - fb583c8eeeb1 (this fixed a bug in [2])
> > >
> > > "up to"?
> > >
> > > 515db266a9da does not apply to 4.19, so should I just drop [1] instead?
> > >
> > > Or, can you provided a backported set of patches so I know exactly what
> > > to apply?
> >
> > Let me take a stab at backporting [2] and [3] or whatever else might
> > be necessary. What git repo/branch did you want me to try that on?
> 
> I'm assuming this one:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=linux-4.19.y

Yes, that is the one, thanks.

greg k-h