From: Saravana Kannan <saravanak@google.com> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Linus Walleij <linus.walleij@linaro.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, David Ahern <dsahern@kernel.org>, Android Kernel Team <kernel-team@android.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "open list:THERMAL" <linux-pm@vger.kernel.org>, Linux IOMMU <iommu@lists.linux-foundation.org>, netdev <netdev@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Alexander Stein <alexander.stein@ew.tq-group.com> Subject: Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Date: Fri, 1 Jul 2022 12:13:16 -0700 [thread overview] Message-ID: <CAGETcx_Y-9WBeRwf22v3NSuY8PGpPrTxtx_uBqe_Q7rD6mEQMQ@mail.gmail.com> (raw) In-Reply-To: <20220701150848.75eeprptmb5beip7@bogus> On Fri, Jul 1, 2022 at 8:08 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > Hi, Saravana, > > On Fri, Jul 01, 2022 at 01:26:12AM -0700, Saravana Kannan wrote: > > [...] > > > Can you check if this hack helps? If so, then I can think about > > whether we can pick it up without breaking everything else. Copy-paste > > tab mess up warning. > > Sorry for jumping in late and not even sure if this is right thread. > I have not bisected anything yet, but I am seeing issues on my Juno R2 > with SCMI enabled power domains and Coresight AMBA devices. > > OF: amba_device_add() failed (-19) for /etf@20010000 > OF: amba_device_add() failed (-19) for /tpiu@20030000 > OF: amba_device_add() failed (-19) for /funnel@20040000 > OF: amba_device_add() failed (-19) for /etr@20070000 > OF: amba_device_add() failed (-19) for /stm@20100000 > OF: amba_device_add() failed (-19) for /replicator@20120000 > OF: amba_device_add() failed (-19) for /cpu-debug@22010000 > OF: amba_device_add() failed (-19) for /etm@22040000 > OF: amba_device_add() failed (-19) for /cti@22020000 > OF: amba_device_add() failed (-19) for /funnel@220c0000 > OF: amba_device_add() failed (-19) for /cpu-debug@22110000 > OF: amba_device_add() failed (-19) for /etm@22140000 > OF: amba_device_add() failed (-19) for /cti@22120000 > OF: amba_device_add() failed (-19) for /cpu-debug@23010000 > OF: amba_device_add() failed (-19) for /etm@23040000 > OF: amba_device_add() failed (-19) for /cti@23020000 > OF: amba_device_add() failed (-19) for /funnel@230c0000 > OF: amba_device_add() failed (-19) for /cpu-debug@23110000 > OF: amba_device_add() failed (-19) for /etm@23140000 > OF: amba_device_add() failed (-19) for /cti@23120000 > OF: amba_device_add() failed (-19) for /cpu-debug@23210000 > OF: amba_device_add() failed (-19) for /etm@23240000 > OF: amba_device_add() failed (-19) for /cti@23220000 > OF: amba_device_add() failed (-19) for /cpu-debug@23310000 > OF: amba_device_add() failed (-19) for /etm@23340000 > OF: amba_device_add() failed (-19) for /cti@23320000 > OF: amba_device_add() failed (-19) for /cti@20020000 > OF: amba_device_add() failed (-19) for /cti@20110000 > OF: amba_device_add() failed (-19) for /funnel@20130000 > OF: amba_device_add() failed (-19) for /etf@20140000 > OF: amba_device_add() failed (-19) for /funnel@20150000 > OF: amba_device_add() failed (-19) for /cti@20160000 > > These are working fine with deferred probe in the mainline. > I tried the hack you have suggested here(rather Tony's version), Thanks for trying that. > also > tried with fw_devlink=0 and fw_devlink=1 0 and 1 aren't valid input to fw_devlink. But yeah, I don't expect disabling it to make anything better. > && fw_devlink.strict=0 > No change in the behaviour. > > The DTS are in arch/arm64/boot/dts/arm/juno-*-scmi.dts and there > coresight devices are mostly in juno-cs-r1r2.dtsi Thanks > Let me know if there is anything obvious or you want me to bisect which > means I need more time. I can do that next week. I'll let you know once I poke at the DTS. We need to figure out why fw_devlink wasn't blocking these from getting to the error (same as in Tony's case). But since these are amba devices, I think I have some guesses. This is an old series that had some issues in some cases and I haven't gotten around to looking at it. You can give that a shot if you can apply it to a recent tree. https://lore.kernel.org/lkml/20210304195101.3843496-1-saravanak@google.com/ After looking at that old patch again, I think I know what's going on. For normal devices, the pm domain attach happens AFTER the device is added and fw_devlink has had a chance to set up device links. And if the suppliers aren't ready, really_probe() won't get as far as dev_pm_domain_attach(). But for amba, the clock and pm domain suppliers are "grabbed" before adding the device. So with that old patch + always returning -EPROBE_DEFER in amba_device_add() if amba_read_periphid() fails should fix your issue. -Saravana
WARNING: multiple messages have this Message-ID (diff)
From: Saravana Kannan via iommu <iommu@lists.linux-foundation.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Andrew Lunn <andrew@lunn.ch>, Ulf Hansson <ulf.hansson@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Tony Lindgren <tony@atomide.com>, Linus Walleij <linus.walleij@linaro.org>, Eric Dumazet <edumazet@google.com>, Pavel Machek <pavel@ucw.cz>, Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>, Kevin Hilman <khilman@kernel.org>, Russell King <linux@armlinux.org.uk>, Alexander Stein <alexander.stein@ew.tq-group.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Android Kernel Team <kernel-team@android.com>, Len Brown <len.brown@intel.com>, "open list:THERMAL" <linux-pm@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Ahern <dsahern@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux IOMMU <iommu@lists.linux-foundation.org>, netdev <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Heiner Kallweit <hkallweit1@gmail.com> Subject: Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Date: Fri, 1 Jul 2022 12:13:16 -0700 [thread overview] Message-ID: <CAGETcx_Y-9WBeRwf22v3NSuY8PGpPrTxtx_uBqe_Q7rD6mEQMQ@mail.gmail.com> (raw) In-Reply-To: <20220701150848.75eeprptmb5beip7@bogus> On Fri, Jul 1, 2022 at 8:08 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > Hi, Saravana, > > On Fri, Jul 01, 2022 at 01:26:12AM -0700, Saravana Kannan wrote: > > [...] > > > Can you check if this hack helps? If so, then I can think about > > whether we can pick it up without breaking everything else. Copy-paste > > tab mess up warning. > > Sorry for jumping in late and not even sure if this is right thread. > I have not bisected anything yet, but I am seeing issues on my Juno R2 > with SCMI enabled power domains and Coresight AMBA devices. > > OF: amba_device_add() failed (-19) for /etf@20010000 > OF: amba_device_add() failed (-19) for /tpiu@20030000 > OF: amba_device_add() failed (-19) for /funnel@20040000 > OF: amba_device_add() failed (-19) for /etr@20070000 > OF: amba_device_add() failed (-19) for /stm@20100000 > OF: amba_device_add() failed (-19) for /replicator@20120000 > OF: amba_device_add() failed (-19) for /cpu-debug@22010000 > OF: amba_device_add() failed (-19) for /etm@22040000 > OF: amba_device_add() failed (-19) for /cti@22020000 > OF: amba_device_add() failed (-19) for /funnel@220c0000 > OF: amba_device_add() failed (-19) for /cpu-debug@22110000 > OF: amba_device_add() failed (-19) for /etm@22140000 > OF: amba_device_add() failed (-19) for /cti@22120000 > OF: amba_device_add() failed (-19) for /cpu-debug@23010000 > OF: amba_device_add() failed (-19) for /etm@23040000 > OF: amba_device_add() failed (-19) for /cti@23020000 > OF: amba_device_add() failed (-19) for /funnel@230c0000 > OF: amba_device_add() failed (-19) for /cpu-debug@23110000 > OF: amba_device_add() failed (-19) for /etm@23140000 > OF: amba_device_add() failed (-19) for /cti@23120000 > OF: amba_device_add() failed (-19) for /cpu-debug@23210000 > OF: amba_device_add() failed (-19) for /etm@23240000 > OF: amba_device_add() failed (-19) for /cti@23220000 > OF: amba_device_add() failed (-19) for /cpu-debug@23310000 > OF: amba_device_add() failed (-19) for /etm@23340000 > OF: amba_device_add() failed (-19) for /cti@23320000 > OF: amba_device_add() failed (-19) for /cti@20020000 > OF: amba_device_add() failed (-19) for /cti@20110000 > OF: amba_device_add() failed (-19) for /funnel@20130000 > OF: amba_device_add() failed (-19) for /etf@20140000 > OF: amba_device_add() failed (-19) for /funnel@20150000 > OF: amba_device_add() failed (-19) for /cti@20160000 > > These are working fine with deferred probe in the mainline. > I tried the hack you have suggested here(rather Tony's version), Thanks for trying that. > also > tried with fw_devlink=0 and fw_devlink=1 0 and 1 aren't valid input to fw_devlink. But yeah, I don't expect disabling it to make anything better. > && fw_devlink.strict=0 > No change in the behaviour. > > The DTS are in arch/arm64/boot/dts/arm/juno-*-scmi.dts and there > coresight devices are mostly in juno-cs-r1r2.dtsi Thanks > Let me know if there is anything obvious or you want me to bisect which > means I need more time. I can do that next week. I'll let you know once I poke at the DTS. We need to figure out why fw_devlink wasn't blocking these from getting to the error (same as in Tony's case). But since these are amba devices, I think I have some guesses. This is an old series that had some issues in some cases and I haven't gotten around to looking at it. You can give that a shot if you can apply it to a recent tree. https://lore.kernel.org/lkml/20210304195101.3843496-1-saravanak@google.com/ After looking at that old patch again, I think I know what's going on. For normal devices, the pm domain attach happens AFTER the device is added and fw_devlink has had a chance to set up device links. And if the suppliers aren't ready, really_probe() won't get as far as dev_pm_domain_attach(). But for amba, the clock and pm domain suppliers are "grabbed" before adding the device. So with that old patch + always returning -EPROBE_DEFER in amba_device_add() if amba_read_periphid() fails should fix your issue. -Saravana _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-07-01 19:13 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-01 7:06 [PATCH v2 0/9] deferred_probe_timeout logic clean up Saravana Kannan via iommu 2022-06-01 7:06 ` Saravana Kannan 2022-06-01 7:06 ` [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan 2022-06-01 7:06 ` Saravana Kannan via iommu 2022-06-09 11:44 ` Ulf Hansson 2022-06-09 11:44 ` Ulf Hansson 2022-06-09 19:29 ` Saravana Kannan 2022-06-09 19:29 ` Saravana Kannan via iommu 2022-06-21 7:28 ` Tony Lindgren 2022-06-21 7:28 ` Tony Lindgren 2022-06-21 19:34 ` Saravana Kannan 2022-06-21 19:34 ` Saravana Kannan via iommu 2022-06-22 4:58 ` Tony Lindgren 2022-06-22 4:58 ` Tony Lindgren 2022-06-22 19:09 ` Saravana Kannan 2022-06-22 19:09 ` Saravana Kannan via iommu 2022-06-23 7:01 ` Tony Lindgren 2022-06-23 7:01 ` Tony Lindgren 2022-06-23 8:21 ` Saravana Kannan 2022-06-23 8:21 ` Saravana Kannan via iommu 2022-06-27 9:10 ` Tony Lindgren 2022-06-27 9:10 ` Tony Lindgren 2022-06-30 23:10 ` Saravana Kannan 2022-06-30 23:10 ` Saravana Kannan via iommu 2022-06-30 23:26 ` Rob Herring 2022-06-30 23:26 ` Rob Herring 2022-06-30 23:30 ` Saravana Kannan 2022-06-30 23:30 ` Saravana Kannan via iommu 2022-07-01 5:33 ` Tony Lindgren 2022-07-01 5:33 ` Tony Lindgren 2022-07-01 6:12 ` Tony Lindgren 2022-07-01 6:12 ` Tony Lindgren 2022-07-01 8:10 ` Saravana Kannan 2022-07-01 8:10 ` Saravana Kannan via iommu 2022-07-01 8:26 ` Saravana Kannan via iommu 2022-07-01 8:26 ` Saravana Kannan 2022-07-01 13:00 ` Tony Lindgren 2022-07-01 13:00 ` Tony Lindgren 2022-07-12 7:12 ` Tony Lindgren 2022-07-13 0:49 ` Saravana Kannan 2022-07-13 8:06 ` Tony Lindgren 2022-07-01 15:08 ` Sudeep Holla 2022-07-01 15:08 ` Sudeep Holla 2022-07-01 19:13 ` Saravana Kannan [this message] 2022-07-01 19:13 ` Saravana Kannan via iommu 2022-07-05 8:44 ` Saravana Kannan 2022-07-05 8:44 ` Saravana Kannan via iommu 2022-07-01 7:38 ` Geert Uytterhoeven 2022-07-01 7:38 ` Geert Uytterhoeven 2022-06-23 12:08 ` Alexander Stein 2022-06-23 12:08 ` Alexander Stein 2022-07-01 0:37 ` Saravana Kannan 2022-07-01 0:37 ` Saravana Kannan via iommu 2022-07-01 6:01 ` (EXT) " Alexander Stein 2022-07-01 6:01 ` Alexander Stein 2022-07-01 7:02 ` Saravana Kannan 2022-07-01 7:02 ` Saravana Kannan via iommu 2022-07-04 7:07 ` (EXT) " Alexander Stein 2022-07-04 7:07 ` Alexander Stein 2022-07-05 1:24 ` Saravana Kannan 2022-07-05 1:24 ` Saravana Kannan via iommu 2022-07-06 13:02 ` Re: " Alexander Stein 2022-07-06 13:02 ` Alexander Stein 2022-07-13 0:45 ` Saravana Kannan 2022-07-14 6:41 ` Alexander Stein 2022-07-15 22:08 ` Saravana Kannan 2022-07-01 7:30 ` Geert Uytterhoeven 2022-07-01 7:30 ` Geert Uytterhoeven 2022-06-01 7:06 ` [PATCH v2 2/9] pinctrl: devicetree: " Saravana Kannan 2022-06-01 7:06 ` Saravana Kannan via iommu 2022-06-01 7:06 ` [PATCH v2 3/9] net: mdio: " Saravana Kannan 2022-06-01 7:06 ` Saravana Kannan via iommu 2022-07-05 9:11 ` Geert Uytterhoeven 2022-07-05 9:11 ` Geert Uytterhoeven 2022-07-13 1:40 ` Saravana Kannan 2022-07-13 11:39 ` Geert Uytterhoeven 2022-08-15 8:38 ` Geert Uytterhoeven 2022-06-01 7:07 ` [PATCH v2 4/9] driver core: Add wait_for_init_devices_probe helper function Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-01 7:07 ` [PATCH v2 5/9] net: ipconfig: Relax fw_devlink if we need to mount a network rootfs Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-01 7:07 ` [PATCH v2 6/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-07-20 17:31 ` Geert Uytterhoeven 2022-07-20 19:01 ` Saravana Kannan 2022-07-21 8:40 ` Geert Uytterhoeven 2022-06-01 7:07 ` [PATCH v2 7/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-22 7:47 ` Sascha Hauer 2022-06-22 7:47 ` Sascha Hauer 2022-06-22 8:44 ` Linus Walleij 2022-06-22 8:44 ` Linus Walleij 2022-06-22 10:52 ` Andy Shevchenko 2022-06-22 10:52 ` Andy Shevchenko 2022-06-22 11:18 ` Sascha Hauer 2022-06-22 11:18 ` Sascha Hauer 2022-06-22 19:40 ` Saravana Kannan via iommu 2022-06-22 19:40 ` Saravana Kannan 2022-06-22 20:35 ` Saravana Kannan 2022-06-22 20:35 ` Saravana Kannan via iommu 2022-06-22 22:30 ` Saravana Kannan 2022-06-22 22:30 ` Saravana Kannan via iommu 2022-06-28 13:09 ` Linus Walleij 2022-06-28 13:09 ` Linus Walleij 2022-06-01 7:07 ` [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-08-19 14:26 ` Jean-Philippe Brucker 2022-06-01 7:07 ` [PATCH v2 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-07 18:07 ` [PATCH v2 0/9] deferred_probe_timeout logic clean up Geert Uytterhoeven 2022-06-07 18:07 ` Geert Uytterhoeven 2022-06-08 0:55 ` Saravana Kannan via iommu 2022-06-08 0:55 ` Saravana Kannan 2022-06-08 4:17 ` Saravana Kannan via iommu 2022-06-08 4:17 ` Saravana Kannan 2022-06-08 10:25 ` Geert Uytterhoeven 2022-06-08 10:25 ` Geert Uytterhoeven 2022-06-08 18:12 ` Saravana Kannan 2022-06-08 18:12 ` Saravana Kannan via iommu 2022-06-08 18:47 ` Geert Uytterhoeven 2022-06-08 18:47 ` Geert Uytterhoeven 2022-06-08 21:07 ` Saravana Kannan 2022-06-08 21:07 ` Saravana Kannan via iommu 2022-06-08 22:49 ` Jakub Kicinski 2022-06-08 22:49 ` Jakub Kicinski 2022-06-08 23:15 ` Saravana Kannan via iommu 2022-06-08 23:15 ` Saravana Kannan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGETcx_Y-9WBeRwf22v3NSuY8PGpPrTxtx_uBqe_Q7rD6mEQMQ@mail.gmail.com \ --to=saravanak@google.com \ --cc=alexander.stein@ew.tq-group.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=dsahern@kernel.org \ --cc=edumazet@google.com \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=hkallweit1@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=kernel-team@android.com \ --cc=khilman@kernel.org \ --cc=kuba@kernel.org \ --cc=len.brown@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=pavel@ucw.cz \ --cc=rafael@kernel.org \ --cc=robh@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ --cc=will@kernel.org \ --cc=yoshfuji@linux-ipv6.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.