From: Saravana Kannan <saravanak@google.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Nathan Chancellor <nathan@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Rob Herring <robh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Will Deacon <will@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@kernel.org>,
Thierry Reding <treding@nvidia.com>,
Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
iommu@lists.linux-foundation.org, kernel-team@android.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, John Stultz <jstultz@google.com>
Subject: Re: [PATCH v1] driver core: Extend deferred probe timeout on driver registration
Date: Tue, 24 May 2022 10:46:49 -0700 [thread overview]
Message-ID: <CAGETcx_qTLwbjzMruLThLYV+MZD5W2Ox-QwLFQeW=eQgxzq-Hw@mail.gmail.com> (raw)
In-Reply-To: <Yo0KyWx+3oX3cMCS@linutronix.de>
On Tue, May 24, 2022 at 9:41 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> On 2022-05-23 20:43:06 [-0700], Saravana Kannan wrote:
> …
> > Thanks for all the help. I think I know what's going on.
>
> I, too got here because my boot recently was extended by 10 seconds and
> bisected to that commit in question.
>
> > If you revert the following commit, then you'll see that your device
> > no longer hangs with my changes.
> > 35a672363ab3 driver core: Ensure wait_for_device_probe() waits until
> > the deferred_probe_timeout fires
>
> Removing probe_timeout_waitqueue (as suggested) or setting the timeout
> to 0 avoids the delay.
In your case, I think it might be working as intended? Curious, what
was the call stack in your case where it was blocked?
-Saravana
WARNING: multiple messages have this Message-ID (diff)
From: Saravana Kannan via iommu <iommu@lists.linux-foundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-doc@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
John Stultz <jstultz@google.com>, Pavel Machek <pavel@ucw.cz>,
linux-s390@vger.kernel.org, Will Deacon <will@kernel.org>,
Rob Herring <robh@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Thierry Reding <treding@nvidia.com>,
kernel-team@android.com, linux-pm@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH v1] driver core: Extend deferred probe timeout on driver registration
Date: Tue, 24 May 2022 10:46:49 -0700 [thread overview]
Message-ID: <CAGETcx_qTLwbjzMruLThLYV+MZD5W2Ox-QwLFQeW=eQgxzq-Hw@mail.gmail.com> (raw)
In-Reply-To: <Yo0KyWx+3oX3cMCS@linutronix.de>
On Tue, May 24, 2022 at 9:41 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> On 2022-05-23 20:43:06 [-0700], Saravana Kannan wrote:
> …
> > Thanks for all the help. I think I know what's going on.
>
> I, too got here because my boot recently was extended by 10 seconds and
> bisected to that commit in question.
>
> > If you revert the following commit, then you'll see that your device
> > no longer hangs with my changes.
> > 35a672363ab3 driver core: Ensure wait_for_device_probe() waits until
> > the deferred_probe_timeout fires
>
> Removing probe_timeout_waitqueue (as suggested) or setting the timeout
> to 0 avoids the delay.
In your case, I think it might be working as intended? Curious, what
was the call stack in your case where it was blocked?
-Saravana
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-24 17:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 22:09 [PATCH v1] driver core: Extend deferred probe timeout on driver registration Saravana Kannan
2022-04-29 22:09 ` Saravana Kannan via iommu
2022-05-13 12:48 ` Mark Brown
2022-05-13 12:48 ` Mark Brown
2022-05-13 13:58 ` Rob Herring
2022-05-13 13:58 ` Rob Herring
2022-05-13 17:25 ` Saravana Kannan
2022-05-13 17:25 ` Saravana Kannan via iommu
2022-05-16 13:49 ` Rob Herring
2022-05-16 13:49 ` Rob Herring
2022-05-20 23:30 ` Nathan Chancellor
2022-05-20 23:30 ` Nathan Chancellor
2022-05-20 23:49 ` Saravana Kannan
2022-05-20 23:49 ` Saravana Kannan via iommu
2022-05-21 0:04 ` Nathan Chancellor
2022-05-21 0:04 ` Nathan Chancellor
2022-05-21 0:15 ` Saravana Kannan
2022-05-21 0:15 ` Saravana Kannan via iommu
2022-05-23 15:17 ` Nathan Chancellor
2022-05-23 15:17 ` Nathan Chancellor
2022-05-23 20:04 ` Saravana Kannan
2022-05-23 20:04 ` Saravana Kannan via iommu
2022-05-23 22:14 ` Nathan Chancellor
2022-05-23 22:14 ` Nathan Chancellor
2022-05-24 3:43 ` Saravana Kannan
2022-05-24 3:43 ` Saravana Kannan via iommu
2022-05-24 16:41 ` Sebastian Andrzej Siewior
2022-05-24 16:41 ` Sebastian Andrzej Siewior
2022-05-24 17:46 ` Saravana Kannan [this message]
2022-05-24 17:46 ` Saravana Kannan via iommu
2022-05-25 7:11 ` Sebastian Andrzej Siewior
2022-05-25 7:11 ` Sebastian Andrzej Siewior
2022-05-25 19:49 ` Saravana Kannan
2022-05-25 19:49 ` Saravana Kannan via iommu
2022-05-29 8:34 ` Niklas Cassel
2022-05-29 8:34 ` Niklas Cassel via iommu
2022-05-30 4:59 ` Saravana Kannan
2022-05-30 4:59 ` Saravana Kannan via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGETcx_qTLwbjzMruLThLYV+MZD5W2Ox-QwLFQeW=eQgxzq-Hw@mail.gmail.com' \
--to=saravanak@google.com \
--cc=bigeasy@linutronix.de \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.