All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF
@ 2020-09-16 15:10 gr embeter
  2020-09-16 15:30 ` [OE-core] " Christopher Larson
  0 siblings, 1 reply; 6+ messages in thread
From: gr embeter @ 2020-09-16 15:10 UTC (permalink / raw)
  To: OE-core

Retrieve multiconfig automatically from meta-layer if it exists,
so that it is possible to use it "out-of-the-box".

Signed-off-by: Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>
---
 scripts/oe-setup-builddir | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
index 30eaa8efbe1f..0077c13110b9 100755
--- a/scripts/oe-setup-builddir
+++ b/scripts/oe-setup-builddir
@@ -65,6 +65,7 @@ if [ -n "$TEMPLATECONF" ]; then
     OECORELAYERCONF="$TEMPLATECONF/bblayers.conf.sample"
     OECORELOCALCONF="$TEMPLATECONF/local.conf.sample"
     OECORENOTESCONF="$TEMPLATECONF/conf-notes.txt"
+    OECOREMULTICONF="$TEMPLATECONF/multiconfig"
 fi

 unset SHOWYPDOC
@@ -80,6 +81,9 @@ for more information as common configuration options
are commented.

 EOM
     cp -f $OECORELOCALCONF "$BUILDDIR/conf/local.conf"
+    if [ -d "$OECOREMULTICONF" ]; then
+        cp -af -t "$BUILDDIR/conf" "$OECOREMULTICONF"
+    fi
     SHOWYPDOC=yes
 fi

-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF
  2020-09-16 15:10 [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF gr embeter
@ 2020-09-16 15:30 ` Christopher Larson
  2020-09-16 17:08   ` gr embeter
  0 siblings, 1 reply; 6+ messages in thread
From: Christopher Larson @ 2020-09-16 15:30 UTC (permalink / raw)
  To: gr embeter; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

Why copy this from TEMPLATECONF when they can be supplied by any layer in
your BBLAYERS?

On Wed, Sep 16, 2020 at 8:10 AM gr embeter <grembeter@gmail.com> wrote:

> Retrieve multiconfig automatically from meta-layer if it exists,
> so that it is possible to use it "out-of-the-box".
>
> Signed-off-by: Grygorii Tertychnyi <
> grygorii.tertychnyi@leica-geosystems.com>
> ---
>  scripts/oe-setup-builddir | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
> index 30eaa8efbe1f..0077c13110b9 100755
> --- a/scripts/oe-setup-builddir
> +++ b/scripts/oe-setup-builddir
> @@ -65,6 +65,7 @@ if [ -n "$TEMPLATECONF" ]; then
>      OECORELAYERCONF="$TEMPLATECONF/bblayers.conf.sample"
>      OECORELOCALCONF="$TEMPLATECONF/local.conf.sample"
>      OECORENOTESCONF="$TEMPLATECONF/conf-notes.txt"
> +    OECOREMULTICONF="$TEMPLATECONF/multiconfig"
>  fi
>
>  unset SHOWYPDOC
> @@ -80,6 +81,9 @@ for more information as common configuration options
> are commented.
>
>  EOM
>      cp -f $OECORELOCALCONF "$BUILDDIR/conf/local.conf"
> +    if [ -d "$OECOREMULTICONF" ]; then
> +        cp -af -t "$BUILDDIR/conf" "$OECOREMULTICONF"
> +    fi
>      SHOWYPDOC=yes
>  fi
>
> --
> 2.25.1
>
> 
>
>

-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2126 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF
  2020-09-16 15:30 ` [OE-core] " Christopher Larson
@ 2020-09-16 17:08   ` gr embeter
  2020-09-16 22:42     ` Mark Hatle
  0 siblings, 1 reply; 6+ messages in thread
From: gr embeter @ 2020-09-16 17:08 UTC (permalink / raw)
  To: Christopher Larson; +Cc: OE-core

> Why copy this from TEMPLATECONF when they can be supplied by any layer in your BBLAYERS?

At the stage of creating build directory I think it is logically to
use TEMPLATECONF both for "local.conf" and "multiconfig"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF
  2020-09-16 17:08   ` gr embeter
@ 2020-09-16 22:42     ` Mark Hatle
  2020-09-17  6:39       ` gr embeter
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Hatle @ 2020-09-16 22:42 UTC (permalink / raw)
  To: gr embeter, Christopher Larson; +Cc: OE-core

In my configurations, we refernce the multiconfig directories inside of our many
layers.  I definitely don't want the copied into the conf/* directory structure,
since I don't want users modifying the prebuilt ones.

--Mark

On 9/16/20 12:08 PM, gr embeter wrote:
>> Why copy this from TEMPLATECONF when they can be supplied by any layer in your BBLAYERS?
> 
> At the stage of creating build directory I think it is logically to
> use TEMPLATECONF both for "local.conf" and "multiconfig"
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF
  2020-09-16 22:42     ` Mark Hatle
@ 2020-09-17  6:39       ` gr embeter
  2020-09-17 20:28         ` Mark Hatle
  0 siblings, 1 reply; 6+ messages in thread
From: gr embeter @ 2020-09-17  6:39 UTC (permalink / raw)
  To: Mark Hatle; +Cc: Christopher Larson, OE-core

Just for the sake of knowing, how do you reference multiconfig directories?
Do you copy them manually to $BUILDDIR/conf after setup-env is done?
I mean when I run `bitbake multiconfig:configA:core-image-minimal'
there should be "$BUILDDIR/conf/multiconfig/configA.conf" file, right?

On Thu, Sep 17, 2020 at 12:42 AM Mark Hatle
<mark.hatle@kernel.crashing.org> wrote:
>
> In my configurations, we refernce the multiconfig directories inside of our many
> layers.  I definitely don't want the copied into the conf/* directory structure,
> since I don't want users modifying the prebuilt ones.
>
> --Mark
>
> On 9/16/20 12:08 PM, gr embeter wrote:
> >> Why copy this from TEMPLATECONF when they can be supplied by any layer in your BBLAYERS?
> >
> > At the stage of creating build directory I think it is logically to
> > use TEMPLATECONF both for "local.conf" and "multiconfig"
> >
> >
> >
> > 
> >

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF
  2020-09-17  6:39       ` gr embeter
@ 2020-09-17 20:28         ` Mark Hatle
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Hatle @ 2020-09-17 20:28 UTC (permalink / raw)
  To: gr embeter; +Cc: OE-core

On 9/17/20 1:39 AM, gr embeter wrote:
> Just for the sake of knowing, how do you reference multiconfig directories?
> Do you copy them manually to $BUILDDIR/conf after setup-env is done?
> I mean when I run `bitbake multiconfig:configA:core-image-minimal'
> there should be "$BUILDDIR/conf/multiconfig/configA.conf" file, right?


My layer contains:

my_layer/conf/multiconfig/multiconfig1.conf
my_layer/conf/multiconfig/multiconfig2.conf
my_layer/conf/multiconfig/multiconfig3.conf
my_layer/conf/multiconfig/multiconfig4.conf

My build directory:

conf/bblayers.conf contains:

BBLAYERS ?= " \
  /scratch1/fray/xilinx/poky/meta \
  /scratch1/fray/xilinx/poky/meta-poky \
  /scratch1/fray/xilinx/poky/meta-yocto-bsp \
  /scratch1/fray/xilinx/my_layer \
  "

conf/local.conf contains:

BBMULTICONFIG = "multiconfig1 multiconfig2 multiconfig3 multiconfig4"

...

The user is responsible for providing their own BBMULTICONFIG.  However, if you
want to provide a default one, you can already including the BBMULTICONFIG for
the setting in your layer set.

--Mark


> On Thu, Sep 17, 2020 at 12:42 AM Mark Hatle
> <mark.hatle@kernel.crashing.org> wrote:
>>
>> In my configurations, we refernce the multiconfig directories inside of our many
>> layers.  I definitely don't want the copied into the conf/* directory structure,
>> since I don't want users modifying the prebuilt ones.
>>
>> --Mark
>>
>> On 9/16/20 12:08 PM, gr embeter wrote:
>>>> Why copy this from TEMPLATECONF when they can be supplied by any layer in your BBLAYERS?
>>>
>>> At the stage of creating build directory I think it is logically to
>>> use TEMPLATECONF both for "local.conf" and "multiconfig"
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> 
>>>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-17 20:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 15:10 [PATCH] oe-setup-builddir: create conf/multiconfig/ from TEMPLATECONF gr embeter
2020-09-16 15:30 ` [OE-core] " Christopher Larson
2020-09-16 17:08   ` gr embeter
2020-09-16 22:42     ` Mark Hatle
2020-09-17  6:39       ` gr embeter
2020-09-17 20:28         ` Mark Hatle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.