All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
@ 2022-01-11  3:40 ` lzmlzm
  0 siblings, 0 replies; 6+ messages in thread
From: lzmlzm @ 2022-01-11  3:40 UTC (permalink / raw)
  To: a.hajda, narmstrong, robert.foss
  Cc: Laurent.pinchart, jonas, jernej.skrabec, airlied, daniel,
	dri-devel, linux-kernel, lzmlzm

Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>
---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..e0feb4fd9780 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
 	if (!lt9611)
 		return -ENOMEM;
 
-	lt9611->dev = &client->dev;
+	lt9611->dev = dev;
 	lt9611->client = client;
 	lt9611->sleep = false;
 
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..e50e42312e82 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
 	if (!lt9611uxc)
 		return -ENOMEM;
 
-	lt9611uxc->dev = &client->dev;
+	lt9611uxc->dev = dev;
 	lt9611uxc->client = client;
 	mutex_init(&lt9611uxc->ocm_lock);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
@ 2022-01-11  3:40 ` lzmlzm
  0 siblings, 0 replies; 6+ messages in thread
From: lzmlzm @ 2022-01-11  3:40 UTC (permalink / raw)
  To: a.hajda, narmstrong, robert.foss
  Cc: jernej.skrabec, jonas, airlied, lzmlzm, linux-kernel, dri-devel,
	Laurent.pinchart

Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>
---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..e0feb4fd9780 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
 	if (!lt9611)
 		return -ENOMEM;
 
-	lt9611->dev = &client->dev;
+	lt9611->dev = dev;
 	lt9611->client = client;
 	lt9611->sleep = false;
 
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..e50e42312e82 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
 	if (!lt9611uxc)
 		return -ENOMEM;
 
-	lt9611uxc->dev = &client->dev;
+	lt9611uxc->dev = dev;
 	lt9611uxc->client = client;
 	mutex_init(&lt9611uxc->ocm_lock);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
  2022-01-11  3:40 ` lzmlzm
@ 2022-01-13 10:14   ` Robert Foss
  -1 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-01-13 10:14 UTC (permalink / raw)
  To: lzmlzm
  Cc: a.hajda, narmstrong, laurent.pinchart, jonas, jernej.skrabec,
	airlied, daniel, dri-devel, linux-kernel

Hello,

Thanks for submitting this cleanup patch.

On Tue, 11 Jan 2022 at 04:41, lzmlzm <lzmlzmhh@gmail.com> wrote:
>

A commit message is necessary for all changes, no matter how trivial.

> Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>

Is your name listed correctly above? For the 'Signed-off-by' tag to be
meaningful, a real name needs to be supplied.

> ---
>  drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..e0feb4fd9780 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
>         if (!lt9611)
>                 return -ENOMEM;
>
> -       lt9611->dev = &client->dev;
> +       lt9611->dev = dev;
>         lt9611->client = client;
>         lt9611->sleep = false;
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 33f9716da0ee..e50e42312e82 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
>         if (!lt9611uxc)
>                 return -ENOMEM;
>
> -       lt9611uxc->dev = &client->dev;
> +       lt9611uxc->dev = dev;
>         lt9611uxc->client = client;
>         mutex_init(&lt9611uxc->ocm_lock);
>
> --

With these two issues fixed, please submit a v2 of this patch.


Rob.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
@ 2022-01-13 10:14   ` Robert Foss
  0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-01-13 10:14 UTC (permalink / raw)
  To: lzmlzm
  Cc: jonas, airlied, dri-devel, narmstrong, linux-kernel,
	jernej.skrabec, a.hajda, laurent.pinchart

Hello,

Thanks for submitting this cleanup patch.

On Tue, 11 Jan 2022 at 04:41, lzmlzm <lzmlzmhh@gmail.com> wrote:
>

A commit message is necessary for all changes, no matter how trivial.

> Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>

Is your name listed correctly above? For the 'Signed-off-by' tag to be
meaningful, a real name needs to be supplied.

> ---
>  drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..e0feb4fd9780 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
>         if (!lt9611)
>                 return -ENOMEM;
>
> -       lt9611->dev = &client->dev;
> +       lt9611->dev = dev;
>         lt9611->client = client;
>         lt9611->sleep = false;
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 33f9716da0ee..e50e42312e82 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
>         if (!lt9611uxc)
>                 return -ENOMEM;
>
> -       lt9611uxc->dev = &client->dev;
> +       lt9611uxc->dev = dev;
>         lt9611uxc->client = client;
>         mutex_init(&lt9611uxc->ocm_lock);
>
> --

With these two issues fixed, please submit a v2 of this patch.


Rob.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
  2022-01-13 10:14   ` Robert Foss
  (?)
@ 2022-01-13 11:21   ` Zhiming Liu
  -1 siblings, 0 replies; 6+ messages in thread
From: Zhiming Liu @ 2022-01-13 11:21 UTC (permalink / raw)
  To: Robert Foss
  Cc: jonas, airlied, dri-devel, narmstrong, linux-kernel,
	jernej.skrabec, a.hajda, laurent.pinchart

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

Hello Robert,

I am new to linux kernel development, thank you very much for your patient
reply.I will attach V2 of patch in the next email.

Best regards
Zhiming Liu

Robert Foss <robert.foss@linaro.org> 于2022年1月13日周四 18:14写道：

> Hello,
>
> Thanks for submitting this cleanup patch.
>
> On Tue, 11 Jan 2022 at 04:41, lzmlzm <lzmlzmhh@gmail.com> wrote:
> >
>
> A commit message is necessary for all changes, no matter how trivial.
>
> > Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>
>
> Is your name listed correctly above? For the 'Signed-off-by' tag to be
> meaningful, a real name needs to be supplied.
>
> > ---
> >  drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
> >  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c
> b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > index dafb1b47c15f..e0feb4fd9780 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
> >         if (!lt9611)
> >                 return -ENOMEM;
> >
> > -       lt9611->dev = &client->dev;
> > +       lt9611->dev = dev;
> >         lt9611->client = client;
> >         lt9611->sleep = false;
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > index 33f9716da0ee..e50e42312e82 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> >         if (!lt9611uxc)
> >                 return -ENOMEM;
> >
> > -       lt9611uxc->dev = &client->dev;
> > +       lt9611uxc->dev = dev;
> >         lt9611uxc->client = client;
> >         mutex_init(&lt9611uxc->ocm_lock);
> >
> > --
>
> With these two issues fixed, please submit a v2 of this patch.
>
>
> Rob.
>

[-- Attachment #2: Type: text/html, Size: 2831 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
  2022-01-13 10:14   ` Robert Foss
  (?)
  (?)
@ 2022-01-13 11:22   ` Zhiming Liu
  -1 siblings, 0 replies; 6+ messages in thread
From: Zhiming Liu @ 2022-01-13 11:22 UTC (permalink / raw)
  To: Robert Foss
  Cc: jonas, airlied, dri-devel, narmstrong, linux-kernel,
	jernej.skrabec, a.hajda, laurent.pinchart

[-- Attachment #1: Type: text/plain, Size: 4032 bytes --]

From 10b677e995ab1f32df79896dbdb7cda779d3f798 Mon Sep 17 00:00:00 2001
From: Zhiming Liu <lzmlzmhh@gmail.com>
Date: Thu, 13 Jan 2022 19:09:37 +0800
Subject: [PATCH v2] Signed-off-by: Zhiming Liu <lzmlzmhh@gmail.com>

bridge : drm : Remove extra device acquisition method of i2c client in
lt9611 driver.

We have get the device of i2c client in probe function.So we should
remove extra device acquisition method of i2c client in lt9611 driver.
---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 4 ++--
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c
b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..feb128a4557d 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
  if (!lt9611)
  return -ENOMEM;

- lt9611->dev = &client->dev;
+ lt9611->dev = dev;
  lt9611->client = client;
  lt9611->sleep = false;

@@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,
  return PTR_ERR(lt9611->regmap);
  }

- ret = lt9611_parse_dt(&client->dev, lt9611);
+ ret = lt9611_parse_dt(dev, lt9611);
  if (ret) {
  dev_err(dev, "failed to parse device tree\n");
  return ret;
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..3d62e6bf6892 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
  if (!lt9611uxc)
  return -ENOMEM;

- lt9611uxc->dev = &client->dev;
+ lt9611uxc->dev = dev;
  lt9611uxc->client = client;
  mutex_init(&lt9611uxc->ocm_lock);

@@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
  return PTR_ERR(lt9611uxc->regmap);
  }

- ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);
+ ret = lt9611uxc_parse_dt(dev, lt9611uxc);
  if (ret) {
  dev_err(dev, "failed to parse device tree\n");
  return ret;
-- 
2.25.1

Robert Foss <robert.foss@linaro.org> 于2022年1月13日周四 18:14写道：

> Hello,
>
> Thanks for submitting this cleanup patch.
>
> On Tue, 11 Jan 2022 at 04:41, lzmlzm <lzmlzmhh@gmail.com> wrote:
> >
>
> A commit message is necessary for all changes, no matter how trivial.
>
> > Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>
>
> Is your name listed correctly above? For the 'Signed-off-by' tag to be
> meaningful, a real name needs to be supplied.
>
> > ---
> >  drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
> >  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c
> b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > index dafb1b47c15f..e0feb4fd9780 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
> >         if (!lt9611)
> >                 return -ENOMEM;
> >
> > -       lt9611->dev = &client->dev;
> > +       lt9611->dev = dev;
> >         lt9611->client = client;
> >         lt9611->sleep = false;
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > index 33f9716da0ee..e50e42312e82 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> >         if (!lt9611uxc)
> >                 return -ENOMEM;
> >
> > -       lt9611uxc->dev = &client->dev;
> > +       lt9611uxc->dev = dev;
> >         lt9611uxc->client = client;
> >         mutex_init(&lt9611uxc->ocm_lock);
> >
> > --
>
> With these two issues fixed, please submit a v2 of this patch.
>
>
> Rob.
>

[-- Attachment #2: Type: text/html, Size: 5093 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-14  8:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11  3:40 [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver lzmlzm
2022-01-11  3:40 ` lzmlzm
2022-01-13 10:14 ` Robert Foss
2022-01-13 10:14   ` Robert Foss
2022-01-13 11:21   ` Zhiming Liu
2022-01-13 11:22   ` Zhiming Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.