* [PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019
@ 2016-07-01 11:07 ` Vasanthakumar Thiagarajan
0 siblings, 0 replies; 6+ messages in thread
From: Vasanthakumar Thiagarajan @ 2016-07-01 11:07 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Vasanthakumar Thiagarajan
As hw cycle counters in QCA4019 wraparound independantly in QCA4019
it is possible cycle counter and rx clear counter would wraparound
at the same time. Current logic assumes only one of the counters
would wraparound at anytime. Fix this by moving 'else' part to
another 'if'.
Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c
index bd86e7a..7462627 100644
--- a/drivers/net/wireless/ath/ath10k/hw.c
+++ b/drivers/net/wireless/ath/ath10k/hw.c
@@ -198,7 +198,8 @@ void ath10k_hw_fill_survey_time(struct ath10k *ar, struct survey_info *survey,
case ATH10K_HW_CC_WRAP_SHIFTED_EACH:
if (cc < cc_prev)
cc_fix = 0x7fffffff;
- else
+
+ if (rcc < rcc_prev)
rcc_fix = 0x7fffffff;
break;
case ATH10K_HW_CC_WRAP_DISABLED:
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019
@ 2016-07-01 11:07 ` Vasanthakumar Thiagarajan
0 siblings, 0 replies; 6+ messages in thread
From: Vasanthakumar Thiagarajan @ 2016-07-01 11:07 UTC (permalink / raw)
To: ath10k; +Cc: Vasanthakumar Thiagarajan, linux-wireless
As hw cycle counters in QCA4019 wraparound independantly in QCA4019
it is possible cycle counter and rx clear counter would wraparound
at the same time. Current logic assumes only one of the counters
would wraparound at anytime. Fix this by moving 'else' part to
another 'if'.
Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c
index bd86e7a..7462627 100644
--- a/drivers/net/wireless/ath/ath10k/hw.c
+++ b/drivers/net/wireless/ath/ath10k/hw.c
@@ -198,7 +198,8 @@ void ath10k_hw_fill_survey_time(struct ath10k *ar, struct survey_info *survey,
case ATH10K_HW_CC_WRAP_SHIFTED_EACH:
if (cc < cc_prev)
cc_fix = 0x7fffffff;
- else
+
+ if (rcc < rcc_prev)
rcc_fix = 0x7fffffff;
break;
case ATH10K_HW_CC_WRAP_DISABLED:
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019
2016-07-01 11:07 ` Vasanthakumar Thiagarajan
@ 2016-07-04 0:33 ` Julian Calaby
-1 siblings, 0 replies; 6+ messages in thread
From: Julian Calaby @ 2016-07-04 0:33 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: ath10k, linux-wireless
Hi All,
On Fri, Jul 1, 2016 at 9:07 PM, Vasanthakumar Thiagarajan
<vthiagar@qti.qualcomm.com> wrote:
> As hw cycle counters in QCA4019 wraparound independantly in QCA4019
> it is possible cycle counter and rx clear counter would wraparound
> at the same time. Current logic assumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
>
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019
@ 2016-07-04 0:33 ` Julian Calaby
0 siblings, 0 replies; 6+ messages in thread
From: Julian Calaby @ 2016-07-04 0:33 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless, ath10k
Hi All,
On Fri, Jul 1, 2016 at 9:07 PM, Vasanthakumar Thiagarajan
<vthiagar@qti.qualcomm.com> wrote:
> As hw cycle counters in QCA4019 wraparound independantly in QCA4019
> it is possible cycle counter and rx clear counter would wraparound
> at the same time. Current logic assumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
>
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ath10k: Fix possible wrong rx_busy time reporting in QCA4019
2016-07-01 11:07 ` Vasanthakumar Thiagarajan
@ 2016-07-08 14:06 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-07-08 14:06 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan
Cc: ath10k, Vasanthakumar Thiagarajan, linux-wireless
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> wrote:
> As hw cycle counters in QCA4019 wraparound independantly in QCA4019
> it is possible cycle counter and rx clear counter would wraparound
> at the same time. Current logic assumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
>
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks, 1 patch applied to ath-next branch of ath.git:
c11e99396d0f ath10k: fix possible wrong rx_busy time reporting in QCA4019
--
Sent by pwcli
https://patchwork.kernel.org/patch/9209723/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ath10k: Fix possible wrong rx_busy time reporting in QCA4019
@ 2016-07-08 14:06 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-07-08 14:06 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless, ath10k
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> wrote:
> As hw cycle counters in QCA4019 wraparound independantly in QCA4019
> it is possible cycle counter and rx clear counter would wraparound
> at the same time. Current logic assumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
>
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks, 1 patch applied to ath-next branch of ath.git:
c11e99396d0f ath10k: fix possible wrong rx_busy time reporting in QCA4019
--
Sent by pwcli
https://patchwork.kernel.org/patch/9209723/
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-08 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-01 11:07 [PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019 Vasanthakumar Thiagarajan
2016-07-01 11:07 ` Vasanthakumar Thiagarajan
2016-07-04 0:33 ` Julian Calaby
2016-07-04 0:33 ` Julian Calaby
2016-07-08 14:06 ` Kalle Valo
2016-07-08 14:06 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.