From: Julian Calaby <julian.calaby@gmail.com>
To: icenowy@aosc.io
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
devicetree <devicetree@vger.kernel.org>,
"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH 3/4] arm64: allwinner: h5: add compatible string for DE2 CCU
Date: Sun, 17 Sep 2017 12:35:37 +1000 [thread overview]
Message-ID: <CAGRGNgVNTvUtu47dQafHkRrW8wQDyT84NTZ=sWT+S3o6zpwAog@mail.gmail.com> (raw)
In-Reply-To: <20170911155529.62891-4-icenowy@aosc.io>
Hi Icenowy,
On Tue, Sep 12, 2017 at 1:55 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> The DE2 CCU on Allwinner H5 SoC has a slightly different behavior than
> the one on H3, so the compatible string is not set in the common DTSI
> file.
>
> Add the compatible string of H5 DE2 CCU in H5 DTSI file.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index d9a720bff05d..e237c05cfdb4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -98,6 +98,10 @@
> compatible = "allwinner,sun50i-h5-ccu";
> };
>
> +&display_clocks {
> + compatible = "allwinner,sun50i-h5-de2-clk";
> +};
> +
This is what I get for reviewing before reading the full patch set.
Shouldn't this be rolled into the previous patch?
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
WARNING: multiple messages have this Message-ID (diff)
From: Julian Calaby <julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: icenowy-h8G6r0blFSE@public.gmane.org
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Mailing List,
Arm"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 3/4] arm64: allwinner: h5: add compatible string for DE2 CCU
Date: Sun, 17 Sep 2017 12:35:37 +1000 [thread overview]
Message-ID: <CAGRGNgVNTvUtu47dQafHkRrW8wQDyT84NTZ=sWT+S3o6zpwAog@mail.gmail.com> (raw)
In-Reply-To: <20170911155529.62891-4-icenowy-h8G6r0blFSE@public.gmane.org>
Hi Icenowy,
On Tue, Sep 12, 2017 at 1:55 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote:
> The DE2 CCU on Allwinner H5 SoC has a slightly different behavior than
> the one on H3, so the compatible string is not set in the common DTSI
> file.
>
> Add the compatible string of H5 DE2 CCU in H5 DTSI file.
>
> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index d9a720bff05d..e237c05cfdb4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -98,6 +98,10 @@
> compatible = "allwinner,sun50i-h5-ccu";
> };
>
> +&display_clocks {
> + compatible = "allwinner,sun50i-h5-de2-clk";
> +};
> +
This is what I get for reviewing before reading the full patch set.
Shouldn't this be rolled into the previous patch?
Thanks,
--
Julian Calaby
Email: julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Profile: http://www.google.com/profiles/julian.calaby/
WARNING: multiple messages have this Message-ID (diff)
From: julian.calaby@gmail.com (Julian Calaby)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 3/4] arm64: allwinner: h5: add compatible string for DE2 CCU
Date: Sun, 17 Sep 2017 12:35:37 +1000 [thread overview]
Message-ID: <CAGRGNgVNTvUtu47dQafHkRrW8wQDyT84NTZ=sWT+S3o6zpwAog@mail.gmail.com> (raw)
In-Reply-To: <20170911155529.62891-4-icenowy@aosc.io>
Hi Icenowy,
On Tue, Sep 12, 2017 at 1:55 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> The DE2 CCU on Allwinner H5 SoC has a slightly different behavior than
> the one on H3, so the compatible string is not set in the common DTSI
> file.
>
> Add the compatible string of H5 DE2 CCU in H5 DTSI file.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index d9a720bff05d..e237c05cfdb4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -98,6 +98,10 @@
> compatible = "allwinner,sun50i-h5-ccu";
> };
>
> +&display_clocks {
> + compatible = "allwinner,sun50i-h5-de2-clk";
> +};
> +
This is what I get for reviewing before reading the full patch set.
Shouldn't this be rolled into the previous patch?
Thanks,
--
Julian Calaby
Email: julian.calaby at gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2017-09-17 2:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 15:55 [PATCH 0/4] Add SimpleFB support for Allwinner H3 SoC Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-11 15:55 ` [PATCH 1/4] dt-bindings: simplefb-sunxi: add pipelines for DE2 Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-18 21:08 ` Rob Herring
2017-09-18 21:08 ` Rob Herring
2017-09-18 21:08 ` Rob Herring
2017-09-11 15:55 ` [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device node for H3 Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-17 2:34 ` [linux-sunxi] " Julian Calaby
2017-09-17 2:34 ` Julian Calaby
2017-09-17 2:34 ` Julian Calaby
2017-10-27 8:01 ` icenowy
2017-10-27 8:01 ` icenowy at aosc.io
2017-09-11 15:55 ` [PATCH 3/4] arm64: allwinner: h5: add compatible string for DE2 CCU Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-09-17 2:35 ` Julian Calaby [this message]
2017-09-17 2:35 ` [linux-sunxi] " Julian Calaby
2017-09-17 2:35 ` Julian Calaby
2017-09-11 15:55 ` [PATCH 4/4] ARM: sunxi: h3/h5: add simplefb nodes Icenowy Zheng
2017-09-11 15:55 ` Icenowy Zheng
2017-10-27 4:07 ` [PATCH 0/4] Add SimpleFB support for Allwinner H3 SoC icenowy
2017-10-27 4:07 ` icenowy at aosc.io
2017-10-27 4:07 ` icenowy-h8G6r0blFSE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRGNgVNTvUtu47dQafHkRrW8wQDyT84NTZ=sWT+S3o6zpwAog@mail.gmail.com' \
--to=julian.calaby@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.