All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Calaby <julian.calaby@gmail.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Johnny Kim <johnny.kim@atmel.com>,
	Austin Shin <austin.shin@atmel.com>,
	Chris Park <chris.park@atmel.com>, Tony Cho <tony.cho@atmel.com>,
	Glen Lee <glen.lee@atmel.com>, Leo Kim <leo.kim@atmel.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()
Date: Thu, 23 Jun 2016 21:29:30 +1000	[thread overview]
Message-ID: <CAGRGNgW52h=X1_Pac+VJKmpBC_MODzu00JnfDOk180FYmvPKyg@mail.gmail.com> (raw)
In-Reply-To: <576BC73B.9070503@osg.samsung.com>

Hi Luis,

On Thu, Jun 23, 2016 at 9:25 PM, Luis de Bethencourt
<luisbg@osg.samsung.com> wrote:
> On 23/06/16 02:29, Julian Calaby wrote:
>> Hi All,
>>
>> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
>> <luisbg@osg.samsung.com> wrote:
>>> The common format to check if a function returned an error pointer is to
>>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>>>
>>> Also, if there was an error returning -EINVAL instead of -1 is more
>>> appropriate.
>>
>> These two changes could be argued to be separate changes deserving of
>> their own patches.
>>
>>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>>
>> However if everyone else is ok with that, this is:
>>
>> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
>>
>> Thanks,
>>
>
> Hi Julian,
>
> If you don't mind I will resend as two separate patches and include your
> Reviewed-by in both.

Providing there are no changes other than rebasing and splitting, I'm
fine with that.,

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

      reply	other threads:[~2016-06-23 11:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 12:39 [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init() Luis de Bethencourt
2016-06-23  1:29 ` Julian Calaby
2016-06-23 11:25   ` Luis de Bethencourt
2016-06-23 11:29     ` Julian Calaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGRGNgW52h=X1_Pac+VJKmpBC_MODzu00JnfDOk180FYmvPKyg@mail.gmail.com' \
    --to=julian.calaby@gmail.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=glen.lee@atmel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.