All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Remove superfluous header files
@ 2015-10-04 21:08 Ola Olsson
  2015-10-04 22:26 ` Julian Calaby
  2015-10-08  9:37 ` Johannes Berg
  0 siblings, 2 replies; 3+ messages in thread
From: Ola Olsson @ 2015-10-04 21:08 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless

if.h only contains if_nametoindex and the reverse.
Lets remove the inclusion in the source files where
these functions are not called.

Signed-off-by: Ola Olsson <ola.olsson@sonymobile.com>
---
 coalesce.c  |    1 -
 hwsim.c     |    1 -
 info.c      |    1 -
 interface.c |    1 -
 mesh.c      |    1 -
 ocb.c       |    1 -
 p2p.c       |    1 -
 phy.c       |    1 -
 reg.c       |    1 -
 roc.c       |    1 -
 vendor.c    |    1 -
 wowlan.c    |    1 -
 12 files changed, 12 deletions(-)

diff --git a/coalesce.c b/coalesce.c
index 6cdc469..fabf44a 100644
--- a/coalesce.c
+++ b/coalesce.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>
 #include <stdio.h>
diff --git a/hwsim.c b/hwsim.c
index faa197b..6f82207 100644
--- a/hwsim.c
+++ b/hwsim.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>

diff --git a/info.c b/info.c
index c23e378..8e87397 100644
--- a/info.c
+++ b/info.c
@@ -1,6 +1,5 @@
 #include <stdbool.h>
 #include <errno.h>
-#include <net/if.h>

 #include <netlink/genl/genl.h>
 #include <netlink/genl/family.h>
diff --git a/interface.c b/interface.c
index 4f0821d..87d86cc 100644
--- a/interface.c
+++ b/interface.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>
 #include <stdbool.h>
diff --git a/mesh.c b/mesh.c
index 0090530..290b8c2 100644
--- a/mesh.c
+++ b/mesh.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>

diff --git a/ocb.c b/ocb.c
index fc48ecf..d28da7f 100644
--- a/ocb.c
+++ b/ocb.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>

diff --git a/p2p.c b/p2p.c
index bcfa01c..2067916 100644
--- a/p2p.c
+++ b/p2p.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>

diff --git a/phy.c b/phy.c
index 39b68c4..6d4139e 100644
--- a/phy.c
+++ b/phy.c
@@ -1,6 +1,5 @@
 #include <stdbool.h>
 #include <errno.h>
-#include <net/if.h>
 #include <strings.h>
 #include <sys/param.h>
 #include <sys/stat.h>
diff --git a/reg.c b/reg.c
index ee607a5..1dca13a 100644
--- a/reg.c
+++ b/reg.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>
 #include <stdbool.h>
diff --git a/roc.c b/roc.c
index ef2bf16..c6eda10 100644
--- a/roc.c
+++ b/roc.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>

diff --git a/vendor.c b/vendor.c
index 5a69375..d0b4f9e 100644
--- a/vendor.c
+++ b/vendor.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>

diff --git a/wowlan.c b/wowlan.c
index d3b565c..e1d3750 100644
--- a/wowlan.c
+++ b/wowlan.c
@@ -1,4 +1,3 @@
-#include <net/if.h>
 #include <errno.h>
 #include <string.h>
 #include <stdio.h>
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove superfluous header files
  2015-10-04 21:08 [PATCH] Remove superfluous header files Ola Olsson
@ 2015-10-04 22:26 ` Julian Calaby
  2015-10-08  9:37 ` Johannes Berg
  1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2015-10-04 22:26 UTC (permalink / raw)
  To: Ola Olsson; +Cc: Johannes Berg, linux-wireless

Hi Ola,

On Mon, Oct 5, 2015 at 8:08 AM, Ola Olsson <ola1olsson@gmail.com> wrote:
> if.h only contains if_nametoindex and the reverse.
> Lets remove the inclusion in the source files where
> these functions are not called.

Minor note: in the future, you might want to include the name of the
project ("iw") in your subject line, i.e.
[PATCH] iw: Remove superfluous header files

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove superfluous header files
  2015-10-04 21:08 [PATCH] Remove superfluous header files Ola Olsson
  2015-10-04 22:26 ` Julian Calaby
@ 2015-10-08  9:37 ` Johannes Berg
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2015-10-08  9:37 UTC (permalink / raw)
  To: Ola Olsson; +Cc: linux-wireless

On Sun, 2015-10-04 at 23:08 +0200, Ola Olsson wrote:
> if.h only contains if_nametoindex and the reverse.
> Lets remove the inclusion in the source files where
> these functions are not called.
> 
Applied, with updated subject.

Thanks!

johannes

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-08  9:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-04 21:08 [PATCH] Remove superfluous header files Ola Olsson
2015-10-04 22:26 ` Julian Calaby
2015-10-08  9:37 ` Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.