From: Julian Calaby <julian.calaby@gmail.com> To: "João Paulo Rechi Vita" <jprvita@gmail.com> Cc: "Johannes Berg" <johannes@sipsolutions.net>, "David S. Miller" <davem@davemloft.net>, "Darren Hart" <dvhart@infradead.org>, linux-wireless <linux-wireless@vger.kernel.org>, netdev <netdev@vger.kernel.org>, platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux@endlessm.com, "João Paulo Rechi Vita" <jprvita@endlessm.com> Subject: Re: [PATCH 1/9] rfkill: Improve documentation language Date: Tue, 9 Feb 2016 09:37:32 +1100 [thread overview] Message-ID: <CAGRGNgX7ANq_dTSkRCqnU2H5DQsLCf5Ni7M-n7Z_RSieOf=mOw@mail.gmail.com> (raw) In-Reply-To: <1454946096-9752-2-git-send-email-jprvita@endlessm.com> Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita <jprvita@gmail.com> wrote: > Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com> Looks right to me. Reviewed-by: Julian Calaby <julian.calaby@gmail.com> > --- > net/rfkill/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/core.c > index a805831..ffbc375 100644 > --- a/net/rfkill/core.c > +++ b/net/rfkill/core.c > @@ -282,8 +282,8 @@ static void rfkill_set_block(struct rfkill *rfkill, bool blocked) > spin_lock_irqsave(&rfkill->lock, flags); > if (err) { > /* > - * Failed -- reset status to _prev, this may be different > - * from what set set _PREV to earlier in this function > + * Failed -- reset status to _PREV, which may be different > + * from what we have set _PREV to earlier in this function > * if rfkill_set_sw_state was invoked. > */ > if (rfkill->state & RFKILL_BLOCK_SW_PREV) > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
WARNING: multiple messages have this Message-ID (diff)
From: Julian Calaby <julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: "João Paulo Rechi Vita" <jprvita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: "Johannes Berg" <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, "Darren Hart" <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, linux-wireless <linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-6IF/jdPJHihWk0Htik3J/w@public.gmane.org, "João Paulo Rechi Vita" <jprvita-6IF/jdPJHihWk0Htik3J/w@public.gmane.org> Subject: Re: [PATCH 1/9] rfkill: Improve documentation language Date: Tue, 9 Feb 2016 09:37:32 +1100 [thread overview] Message-ID: <CAGRGNgX7ANq_dTSkRCqnU2H5DQsLCf5Ni7M-n7Z_RSieOf=mOw@mail.gmail.com> (raw) In-Reply-To: <1454946096-9752-2-git-send-email-jprvita-6IF/jdPJHihWk0Htik3J/w@public.gmane.org> Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita <jprvita@gmail.com> wrote: > Signed-off-by: João Paulo Rechi Vita <jprvita-6IF/jdPJHihWk0Htik3J/w@public.gmane.org> Looks right to me. Reviewed-by: Julian Calaby <julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > net/rfkill/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/core.c > index a805831..ffbc375 100644 > --- a/net/rfkill/core.c > +++ b/net/rfkill/core.c > @@ -282,8 +282,8 @@ static void rfkill_set_block(struct rfkill *rfkill, bool blocked) > spin_lock_irqsave(&rfkill->lock, flags); > if (err) { > /* > - * Failed -- reset status to _prev, this may be different > - * from what set set _PREV to earlier in this function > + * Failed -- reset status to _PREV, which may be different > + * from what we have set _PREV to earlier in this function > * if rfkill_set_sw_state was invoked. > */ > if (rfkill->state & RFKILL_BLOCK_SW_PREV) > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Julian Calaby Email: julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2016-02-08 22:37 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-08 15:41 [PATCH 0/9] RFKill airplane-mode indicator João Paulo Rechi Vita 2016-02-08 15:41 ` [PATCH 1/9] rfkill: Improve documentation language João Paulo Rechi Vita 2016-02-08 22:37 ` Julian Calaby [this message] 2016-02-08 22:37 ` Julian Calaby 2016-02-08 15:41 ` [PATCH 2/9] rfkill: Remove extra blank line João Paulo Rechi Vita 2016-02-08 22:38 ` Julian Calaby 2016-02-08 15:41 ` [PATCH 3/9] rfkill: Point to the correct deprecated doc location João Paulo Rechi Vita 2016-02-08 22:39 ` Julian Calaby 2016-02-08 15:41 ` [PATCH 4/9] rfkill: Move "state" sysfs file back to stable João Paulo Rechi Vita 2016-02-08 15:41 ` [PATCH 5/9] rfkill: Factor rfkill_global_states[].cur assignments João Paulo Rechi Vita 2016-02-08 22:40 ` Julian Calaby 2016-02-08 22:40 ` Julian Calaby 2016-02-08 15:41 ` [PATCH 6/9] rfkill: Add documentation about LED triggers João Paulo Rechi Vita 2016-02-08 15:41 ` [PATCH 7/9] rfkill: Create "rfkill-airplane_mode" LED trigger João Paulo Rechi Vita 2016-02-18 20:08 ` Johannes Berg 2016-02-22 16:10 ` João Paulo Rechi Vita 2016-02-08 15:41 ` [PATCH 8/9] rfkill: Userspace control for airplane mode João Paulo Rechi Vita 2016-02-08 15:41 ` João Paulo Rechi Vita 2016-02-08 16:11 ` Dan Williams 2016-02-08 17:22 ` João Paulo Rechi Vita 2016-02-10 16:07 ` Johannes Berg 2016-02-10 16:07 ` Johannes Berg 2016-02-10 16:53 ` Dan Williams 2016-02-10 17:12 ` Johannes Berg 2016-02-16 15:12 ` João Paulo Rechi Vita 2016-02-08 16:20 ` Marcel Holtmann 2016-02-08 16:20 ` Marcel Holtmann 2016-02-08 17:18 ` Johannes Berg 2016-02-08 17:22 ` João Paulo Rechi Vita 2016-02-08 22:53 ` Julian Calaby 2016-02-09 21:35 ` João Paulo Rechi Vita 2016-02-09 21:35 ` João Paulo Rechi Vita 2016-02-09 21:36 ` João Paulo Rechi Vita 2016-02-09 22:01 ` Julian Calaby 2016-02-18 20:12 ` Johannes Berg 2016-02-22 16:11 ` João Paulo Rechi Vita 2016-02-08 15:41 ` [PATCH 9/9] rfkill: Notify userspace of airplane-mode state changes João Paulo Rechi Vita
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGRGNgX7ANq_dTSkRCqnU2H5DQsLCf5Ni7M-n7Z_RSieOf=mOw@mail.gmail.com' \ --to=julian.calaby@gmail.com \ --cc=davem@davemloft.net \ --cc=dvhart@infradead.org \ --cc=johannes@sipsolutions.net \ --cc=jprvita@endlessm.com \ --cc=jprvita@gmail.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linux@endlessm.com \ --cc=netdev@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.