From: Julian Calaby <julian.calaby@gmail.com> To: Kalle Valo <kvalo@codeaurora.org> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>, "John W. Linville" <linville@tuxdriver.com>, Joe Perches <joe@perches.com>, linux-wireless <linux-wireless@vger.kernel.org>, kbuild test robot <lkp@intel.com>, kernel-janitors <kernel-janitors@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: wireless-drivers: random cleanup patches piling up Date: Wed, 16 Mar 2016 20:42:09 +1100 [thread overview] Message-ID: <CAGRGNgX=a9gfnYG6eW2p1CnHnH22pFO7_pDcF4pHSieeUC2s-Q@mail.gmail.com> (raw) In-Reply-To: <87pouulqut.fsf@kamboji.qca.qualcomm.com> Hi Kalle, On Wed, Mar 16, 2016 at 8:22 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Julian Calaby <julian.calaby@gmail.com> writes: > >> Hi Kalle, >> >> On Mon, Feb 1, 2016 at 7:21 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>> Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes: >>> >>>> Sure, I am starting that way. I checked in patchwork and I do not see >>>> any checkpatch related patch pending (except staging, which Greg will >>>> handle). I think you must have cleared all of them. >>> >>> They are in deferred state. The search functionality in patchwork is not >>> that intuitive and they are not easy to find so here's a direct link: >>> >>> https://patchwork.kernel.org/project/linux-wireless/list/?state=10&order=date >> >> I'm currently going through that list and producing a bundle of >> "applyable" patches. > > Nice. Thanks, I figured that checking the deferred list on patchwork at some point would be a good plan. After a release seemed like a good time to do it. >> My criteria is: >> 1. The change is sane. >> 2. It's either obviously correct, I can review it, or someone else has >> reviewed or acked it. >> 3. No changes other than rebasing and fixing commit messages are >> required to apply it. > > BTW, 'git am -s -3' is the best way to apply a patch. The three way > merge is awesome (if the submitter has sent the patch correctly). > >> Some of these patches need work on their commit messages, some are >> complicated enough that I feel I should be providing review notes so >> someone else can double check my review, and all of them should be >> rebased and compile tested. Also, some are controversial, so I'll be >> segregating them from the main set. >> >> How would you like me to communicate this list to you? I'm happy to >> provide branches you can pull from or I could just post updated >> versions to the list and give reviewed-by tags to those that don't >> need more work. >> >> Every patch will get an email on linux-wireless regardless. > > I guess posting the patches to linux-wireless is the easiest for > everyone? I have a script which automatically takes patches from > patchwork so that's very easy for me. But remember to use Signed-off-by > instead of Reviewed-by as you are resending the patches. If they end up being exactly identical to the original, I'll just add reviewed-bys to the original patches, otherwise I'll do exactly that. > Thanks you, your help here is very much appreciated. No problem! -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
WARNING: multiple messages have this Message-ID (diff)
From: Julian Calaby <julian.calaby@gmail.com> To: Kalle Valo <kvalo@codeaurora.org> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>, "John W. Linville" <linville@tuxdriver.com>, Joe Perches <joe@perches.com>, linux-wireless <linux-wireless@vger.kernel.org>, kbuild test robot <lkp@intel.com>, kernel-janitors <kernel-janitors@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: wireless-drivers: random cleanup patches piling up Date: Wed, 16 Mar 2016 09:42:09 +0000 [thread overview] Message-ID: <CAGRGNgX=a9gfnYG6eW2p1CnHnH22pFO7_pDcF4pHSieeUC2s-Q@mail.gmail.com> (raw) In-Reply-To: <87pouulqut.fsf@kamboji.qca.qualcomm.com> Hi Kalle, On Wed, Mar 16, 2016 at 8:22 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Julian Calaby <julian.calaby@gmail.com> writes: > >> Hi Kalle, >> >> On Mon, Feb 1, 2016 at 7:21 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>> Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes: >>> >>>> Sure, I am starting that way. I checked in patchwork and I do not see >>>> any checkpatch related patch pending (except staging, which Greg will >>>> handle). I think you must have cleared all of them. >>> >>> They are in deferred state. The search functionality in patchwork is not >>> that intuitive and they are not easy to find so here's a direct link: >>> >>> https://patchwork.kernel.org/project/linux-wireless/list/?state\x10&orderÚte >> >> I'm currently going through that list and producing a bundle of >> "applyable" patches. > > Nice. Thanks, I figured that checking the deferred list on patchwork at some point would be a good plan. After a release seemed like a good time to do it. >> My criteria is: >> 1. The change is sane. >> 2. It's either obviously correct, I can review it, or someone else has >> reviewed or acked it. >> 3. No changes other than rebasing and fixing commit messages are >> required to apply it. > > BTW, 'git am -s -3' is the best way to apply a patch. The three way > merge is awesome (if the submitter has sent the patch correctly). > >> Some of these patches need work on their commit messages, some are >> complicated enough that I feel I should be providing review notes so >> someone else can double check my review, and all of them should be >> rebased and compile tested. Also, some are controversial, so I'll be >> segregating them from the main set. >> >> How would you like me to communicate this list to you? I'm happy to >> provide branches you can pull from or I could just post updated >> versions to the list and give reviewed-by tags to those that don't >> need more work. >> >> Every patch will get an email on linux-wireless regardless. > > I guess posting the patches to linux-wireless is the easiest for > everyone? I have a script which automatically takes patches from > patchwork so that's very easy for me. But remember to use Signed-off-by > instead of Reviewed-by as you are resending the patches. If they end up being exactly identical to the original, I'll just add reviewed-bys to the original patches, otherwise I'll do exactly that. > Thanks you, your help here is very much appreciated. No problem! -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-16 9:42 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-21 14:58 wireless-drivers: random cleanup patches piling up Kalle Valo 2016-01-21 19:46 ` Larry Finger 2016-01-22 12:11 ` Kalle Valo 2016-01-21 22:32 ` Julian Calaby 2016-01-22 12:17 ` Kalle Valo 2016-01-22 13:13 ` Julian Calaby 2016-01-22 0:52 ` Joe Perches 2016-01-22 0:52 ` Joe Perches 2016-01-22 7:30 ` Dan Carpenter 2016-01-22 7:30 ` Dan Carpenter 2016-01-22 12:21 ` Kalle Valo 2016-01-22 12:21 ` Kalle Valo 2016-01-22 15:12 ` John W. Linville 2016-01-22 15:12 ` John W. Linville 2016-01-22 15:54 ` Kalle Valo 2016-01-22 15:54 ` Kalle Valo 2016-01-26 5:28 ` Sudip Mukherjee 2016-01-26 5:40 ` Sudip Mukherjee 2016-01-29 8:08 ` Kalle Valo 2016-01-29 8:08 ` Kalle Valo 2016-02-01 4:41 ` Sudip Mukherjee 2016-02-01 4:53 ` Sudip Mukherjee 2016-02-01 8:21 ` Kalle Valo 2016-02-01 8:21 ` Kalle Valo 2016-03-16 0:57 ` Julian Calaby 2016-03-16 0:57 ` Julian Calaby 2016-03-16 9:22 ` Kalle Valo 2016-03-16 9:22 ` Kalle Valo 2016-03-16 9:42 ` Julian Calaby [this message] 2016-03-16 9:42 ` Julian Calaby 2016-03-18 1:06 ` Julian Calaby 2016-03-18 1:06 ` Julian Calaby 2016-01-22 18:05 ` Joe Perches 2016-01-22 18:05 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGRGNgX=a9gfnYG6eW2p1CnHnH22pFO7_pDcF4pHSieeUC2s-Q@mail.gmail.com' \ --to=julian.calaby@gmail.com \ --cc=joe@perches.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=lkp@intel.com \ --cc=sudipm.mukherjee@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.