From: Daniel Latypov <dlatypov@google.com> To: David Gow <davidgow@google.com> Cc: Brendan Higgins <brendanhiggins@google.com>, Shuah Khan <shuah@kernel.org>, Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, KUnit Development <kunit-dev@googlegroups.com>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, linux-um@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] kunit: arch/um/configs: Enable KUNIT_ALL_TESTS by default Date: Tue, 18 May 2021 13:14:11 -0700 [thread overview] Message-ID: <CAGS_qxoAvQpX=Q4dZe6Rynfwmete6Vek5u9VYud8zLtqonGF8w@mail.gmail.com> (raw) In-Reply-To: <20210518035825.1885357-1-davidgow@google.com> On Mon, May 17, 2021 at 8:58 PM 'David Gow' via KUnit Development <kunit-dev@googlegroups.com> wrote: > > Make the default .kunitconfig (specified in > arch/um/configs/kunit_defconfig) specify CONFIG_KUNIT_ALL_TESTS by > default. KUNIT_ALL_TESTS runs all tests which have satisfied > dependencies in the current .config (which would be the architecture > defconfig). > > Currently, the default .kunitconfig enables only the example tests and > KUnit's own tests. While this does provide a good example of what a > .kunitconfig for running a few individual tests should look like, it > does mean that kunit_tool runs a pretty paltry collection of tests by > default. From the perspective of someone trying out KUnit for the first time, I'd personally * try out `kunit.py run` * then maybe grep for a test/suite name that sounds interesting. So I'm strongly in favor of the default running a wider variety of tests. The build and execution time is still very quick, so no complaints there. I also think this makes the set of (most of) the existing tests more discoverable then grepping around for #include <kunit/test.h> or similar indicators. But I'm also biased in that I like seeing larger numbers of tests. > > A default run of ./tools/testing/kunit/kunit.py run now runs 70 tests > instead of 14. > > Signed-off-by: David Gow <davidgow@google.com> Acked-by: Daniel Latypov <dlatypov@google.com> > --- > arch/um/configs/kunit_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/um/configs/kunit_defconfig b/arch/um/configs/kunit_defconfig > index 9235b7d42d38..becf3432a375 100644 > --- a/arch/um/configs/kunit_defconfig > +++ b/arch/um/configs/kunit_defconfig > @@ -1,3 +1,2 @@ > CONFIG_KUNIT=y > -CONFIG_KUNIT_TEST=y > -CONFIG_KUNIT_EXAMPLE_TEST=y I think it's maybe still useful to have an example of selecting a specific test. I'd lean towards keeping one or both of these. KUNIT_TEST might not be as clear as KUNIT_EXAMPLE_TEST, so I'd lean towards keeping that one, if we don't want both. > +CONFIG_KUNIT_ALL_TESTS=y > -- > 2.31.1.751.gd2f1c929bd-goog > > -- > You received this message because you are subscribed to the Google Groups "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20210518035825.1885357-1-davidgow%40google.com.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Latypov <dlatypov@google.com> To: David Gow <davidgow@google.com> Cc: Brendan Higgins <brendanhiggins@google.com>, Shuah Khan <shuah@kernel.org>, Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, KUnit Development <kunit-dev@googlegroups.com>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, linux-um@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] kunit: arch/um/configs: Enable KUNIT_ALL_TESTS by default Date: Tue, 18 May 2021 13:14:11 -0700 [thread overview] Message-ID: <CAGS_qxoAvQpX=Q4dZe6Rynfwmete6Vek5u9VYud8zLtqonGF8w@mail.gmail.com> (raw) In-Reply-To: <20210518035825.1885357-1-davidgow@google.com> On Mon, May 17, 2021 at 8:58 PM 'David Gow' via KUnit Development <kunit-dev@googlegroups.com> wrote: > > Make the default .kunitconfig (specified in > arch/um/configs/kunit_defconfig) specify CONFIG_KUNIT_ALL_TESTS by > default. KUNIT_ALL_TESTS runs all tests which have satisfied > dependencies in the current .config (which would be the architecture > defconfig). > > Currently, the default .kunitconfig enables only the example tests and > KUnit's own tests. While this does provide a good example of what a > .kunitconfig for running a few individual tests should look like, it > does mean that kunit_tool runs a pretty paltry collection of tests by > default. From the perspective of someone trying out KUnit for the first time, I'd personally * try out `kunit.py run` * then maybe grep for a test/suite name that sounds interesting. So I'm strongly in favor of the default running a wider variety of tests. The build and execution time is still very quick, so no complaints there. I also think this makes the set of (most of) the existing tests more discoverable then grepping around for #include <kunit/test.h> or similar indicators. But I'm also biased in that I like seeing larger numbers of tests. > > A default run of ./tools/testing/kunit/kunit.py run now runs 70 tests > instead of 14. > > Signed-off-by: David Gow <davidgow@google.com> Acked-by: Daniel Latypov <dlatypov@google.com> > --- > arch/um/configs/kunit_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/um/configs/kunit_defconfig b/arch/um/configs/kunit_defconfig > index 9235b7d42d38..becf3432a375 100644 > --- a/arch/um/configs/kunit_defconfig > +++ b/arch/um/configs/kunit_defconfig > @@ -1,3 +1,2 @@ > CONFIG_KUNIT=y > -CONFIG_KUNIT_TEST=y > -CONFIG_KUNIT_EXAMPLE_TEST=y I think it's maybe still useful to have an example of selecting a specific test. I'd lean towards keeping one or both of these. KUNIT_TEST might not be as clear as KUNIT_EXAMPLE_TEST, so I'd lean towards keeping that one, if we don't want both. > +CONFIG_KUNIT_ALL_TESTS=y > -- > 2.31.1.751.gd2f1c929bd-goog > > -- > You received this message because you are subscribed to the Google Groups "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20210518035825.1885357-1-davidgow%40google.com. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2021-05-18 20:14 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-18 3:58 [PATCH] kunit: arch/um/configs: Enable KUNIT_ALL_TESTS by default David Gow 2021-05-18 3:58 ` David Gow 2021-05-18 20:14 ` Daniel Latypov [this message] 2021-05-18 20:14 ` Daniel Latypov 2021-05-18 21:15 ` Brendan Higgins 2021-05-18 21:15 ` Brendan Higgins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGS_qxoAvQpX=Q4dZe6Rynfwmete6Vek5u9VYud8zLtqonGF8w@mail.gmail.com' \ --to=dlatypov@google.com \ --cc=brendanhiggins@google.com \ --cc=davidgow@google.com \ --cc=jdike@addtoit.com \ --cc=kunit-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=richard@nod.at \ --cc=shuah@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.